Re: [Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

2018-05-22 Thread Eric Engestrom
On Monday, 2018-05-21 11:42:37 -0700, Ian Romanick wrote: > On 05/17/2018 05:05 AM, Eric Engestrom wrote: > > From: Andrea Azzarone > > > > Since make_surface() can fail we need to check the result before > > dereferencing it. > > > > Bug: https://github.com/mesa3d/mesa/pull/5 > > Bug: https://

Re: [Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

2018-05-21 Thread Ian Romanick
On 05/17/2018 05:05 AM, Eric Engestrom wrote: > From: Andrea Azzarone > > Since make_surface() can fail we need to check the result before > dereferencing it. > > Bug: https://github.com/mesa3d/mesa/pull/5 > Bug: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1760415 > Reviewed-by:

Re: [Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

2018-05-17 Thread Nanley Chery
On Thu, May 17, 2018 at 01:05:13PM +0100, Eric Engestrom wrote: > From: Andrea Azzarone > > Since make_surface() can fail we need to check the result before > dereferencing it. > This line should be wrapped to 75 characters or less (see https://www.mesa3d.org/submittingpatches.html). > Bug: h