Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-20 Thread Lionel Landwerlin
On 15/08/18 10:45, andrey simiklit wrote: Hi all, Thanks for your reply. We shouldn't even get to use the iterator if it's an unknown instruction. The decoder should just advance dword by dword until it finds something that makes sense again. Got it) So this is an

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-15 Thread andrey simiklit
Hi all, Thanks for your reply. We shouldn't even get to use the iterator if it's an unknown instruction. > The decoder should just advance dword by dword until it finds something > that > makes sense again. > Got it) So this is an expected behavior there: return iter_group_offset_bits(iter,

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-14 Thread Lionel Landwerlin
On 14/08/18 16:16, Rafael Antognolli wrote: On Tue, Aug 14, 2018 at 03:36:18PM +0100, Lionel Landwerlin wrote: On 14/08/18 12:55, asimiklit.work wrote: Hi Lionel, Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-14 Thread Rafael Antognolli
On Tue, Aug 14, 2018 at 03:36:18PM +0100, Lionel Landwerlin wrote: > On 14/08/18 12:55, asimiklit.work wrote: > > Hi Lionel, > > > Hi Andrii, > > > > > > Again sorry, I don't think this is the right fix. > > > I'm sending another patch to fix the parsing of > > > MI_BATCH_BUFFER_START which seems

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-14 Thread Lionel Landwerlin
On 14/08/18 12:55, asimiklit.work wrote: Hi Lionel, Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START which seems to be the actual issue. Thanks for working on this, Thanks for your fast reply. I agree that

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-14 Thread asimiklit.work
Hi Lionel, Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START which seems to be the actual issue. Thanks for working on this, Thanks for your fast reply. I agree that it is not correct patch for this issue but

Re: [Mesa-dev] [PATCH v2] intel/decoder: fix the possible out of bounds group_iter

2018-08-14 Thread Lionel Landwerlin
Hi Andrii, Again sorry, I don't think this is the right fix. I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START which seems to be the actual issue. Thanks for working on this, - Lionel On 14/08/18 10:04, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit The