Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 10:20 AM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 6:01 PM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst > wrote: > >> > >> On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-10 Thread Karol Herbst
On Tue, Apr 10, 2018 at 6:01 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst wrote: >> >> On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand >> wrote: >> > I still don't see anything to make nir_validate not

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand > wrote: > > I still don't see anything to make nir_validate not fail out on you if it > > sees a read or a write to/from an IMAGE or SAMPLER. > > > >

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-10 Thread Karol Herbst
On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand wrote: > I still don't see anything to make nir_validate not fail out on you if it > sees a read or a write to/from an IMAGE or SAMPLER. > what kind of glsl code are you talking about here? I wrote some tests and things just

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

2018-04-10 Thread Jason Ekstrand
I still don't see anything to make nir_validate not fail out on you if it sees a read or a write to/from an IMAGE or SAMPLER. On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > v2: fix assertion for bindless to non bindless assignments > > Signed-off-by: Karol Herbst