Re: [Mesa-dev] [PATCH v3] *** Decode fields spanning across two DWords correctly ***

2016-09-20 Thread Gandikota, Sirisha 


>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Kenneth Graunke
>Sent: Tuesday, September 20, 2016 4:28 PM
>To: mesa-dev@lists.freedesktop.org
>Subject: Re: [Mesa-dev] [PATCH v3] *** Decode fields spanning across two
>DWords correctly ***
>
>On Tuesday, September 20, 2016 3:59:27 PM PDT Sirisha Gandikota wrote:
>> From: Sirisha Gandikota <sirisha.gandik...@intel.com>
>>
>> The first version of aubinator did not take into account the fields
>> spanning across 2 DWords. Hence fields like 64bit address/offset and
>> int were not decoded correctly. This patch should fix that issue.
>>
>> v2: Aptly renamed dw to qw in the method gen_field_iterator_next() and
>> removed extra white space in the same method (Anuj)
>>
>> v3: Change all instances of dw to qw (Anuj)
>>
>> Tested on HSW, BDW, SKL aub files
>>
>>
>> Sirisha Gandikota (1):
>>   aubinator: Fix the decoding of values that span two Dwords
>>
>>  src/intel/tools/decoder.c | 50
>> +++
>>  1 file changed, 37 insertions(+), 13 deletions(-)
>
>Hi Sirisha,
>
>You don't need to send a cover letter (--compose) for single patches.
>We generally only do that for patch series.
>
[SG] Thanks Ken... point noted! :)
>--Ken
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3] *** Decode fields spanning across two DWords correctly ***

2016-09-20 Thread Kenneth Graunke 
On Tuesday, September 20, 2016 3:59:27 PM PDT Sirisha Gandikota wrote:
> From: Sirisha Gandikota 
> 
> The first version of aubinator did not take into account the fields
> spanning across 2 DWords. Hence fields like 64bit address/offset and
> int were not decoded correctly. This patch should fix that issue.
> 
> v2: Aptly renamed dw to qw in the method gen_field_iterator_next()
> and removed extra white space in the same method (Anuj)
> 
> v3: Change all instances of dw to qw (Anuj)
> 
> Tested on HSW, BDW, SKL aub files
> 
> 
> Sirisha Gandikota (1):
>   aubinator: Fix the decoding of values that span two Dwords
> 
>  src/intel/tools/decoder.c | 50 
> +++
>  1 file changed, 37 insertions(+), 13 deletions(-)

Hi Sirisha,

You don't need to send a cover letter (--compose) for single patches.
We generally only do that for patch series.

--Ken


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev