Re: [Mesa3d-dev] [RFC] Move _mesa_memcpy to imports.h and inline it

2009-12-04 Thread Eric Anholt
On Fri, 4 Dec 2009 02:24:26 -0800, Kenneth Graunke wrote: > On Thursday 03 December 2009 12:47:36 Brian Paul wrote: > [snip] > > I've been meaning to go over imports.[ch] and make a bunch of the > > wrapper functions inlines. > > > > A lot of the wrappers aren't needed any more. Back before val

[Mesa3d-dev] [Bug 25016] missing/corrupted textures since texformat-rework branch merge

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 --- Comment #8 from Maciej Cencora 2009-12-04 15:02:18 PST --- Created an attachment (id=31756) --> (http://bugs.freedesktop.org/attachment.cgi?id=31756) proposed patch Fabio: Could you try this patch? -- Configure bugmail: http://bugs.

[Mesa3d-dev] [gallium] what is wrong when i need FLUSH_CURRENT in st_teximage_flush_before_map()

2009-12-04 Thread Maarten Maathuis
I recently noticed a regression in the nv50 gallium driver, with a few hours of bisecting i figured out i need FLUSH_CURRENT called unconditionally in st_teximage_flush_before_map(). Otherwise in warzone2100 several small textures (glyphs) go missing. Does this make any sense or perhaps provide a h

Re: [Mesa3d-dev] [RFC] Move _mesa_memcpy to imports.h and inline it

2009-12-04 Thread Kenneth Graunke
On Friday 04 December 2009 07:39:47 Brian Paul wrote: [snip] > > I've attached patches to remove a number of the wrappers, should you > > decide you want to go that way. > > Thanks. I think I'll sit on these for a while though. There's a few > feature branches that will get merged in coming week

Re: [Mesa3d-dev] [RFC] Move _mesa_memcpy to imports.h and inline it

2009-12-04 Thread Kenneth Graunke
On Friday 04 December 2009 07:50:15 Roland Scheidegger wrote: [snip] > > diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c > > index 6a34aec..0f10111 100644 > > --- a/src/mesa/main/imports.c > > +++ b/src/mesa/main/imports.c > > @@ -268,17 +268,6 @@ _mesa_bzero( void *dst, size_t n ) >

[Mesa3d-dev] [Bug 25016] missing/corrupted textures since texformat-rework branch merge

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 --- Comment #7 from Maciej Cencora 2009-12-04 08:57:55 PST --- (In reply to comment #6) > I'm taking a quick look at the diffs between > 0ea575d721821262a862ceef010db9b1a8b4a6d9 and > 1f196b786d6bd0c6a5dbdc638574ff716cc3d4de > > One thing t

Re: [Mesa3d-dev] [RFC] Move _mesa_memcpy to imports.h and inline it

2009-12-04 Thread Roland Scheidegger
On 04.12.2009 11:24, Kenneth Graunke wrote: > On Thursday 03 December 2009 12:47:36 Brian Paul wrote: > [snip] >> I've been meaning to go over imports.[ch] and make a bunch of the >> wrapper functions inlines. >> >> A lot of the wrappers aren't needed any more. Back before valgrind I >> used the m

Re: [Mesa3d-dev] [RFC] Move _mesa_memcpy to imports.h and inline it

2009-12-04 Thread Brian Paul
Kenneth Graunke wrote: > On Thursday 03 December 2009 12:47:36 Brian Paul wrote: > [snip] >> I've been meaning to go over imports.[ch] and make a bunch of the >> wrapper functions inlines. >> >> A lot of the wrappers aren't needed any more. Back before valgrind I >> used the memory-related wrapper

[Mesa3d-dev] [Bug 25016] missing/corrupted textures since texformat-rework branch merge

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 --- Comment #6 from Brian Paul 2009-12-04 06:42:34 PST --- I'm taking a quick look at the diffs between 0ea575d721821262a862ceef010db9b1a8b4a6d9 and 1f196b786d6bd0c6a5dbdc638574ff716cc3d4de One thing that looks suspicious is the VALID_FORMA

[Mesa3d-dev] [Bug 25016] missing/corrupted textures since texformat-rework branch merge

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 Fabio changed: What|Removed |Added Summary|corruption regression |missing/corrupted textures |pr

[Mesa3d-dev] [Bug 25016] corruption regression probably after texformat-rework branch

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 --- Comment #4 from Fabio 2009-12-04 04:21:16 PST --- Created an attachment (id=31734) --> (http://bugs.freedesktop.org/attachment.cgi?id=31734) full console output with mesa *7.7* compiled with --enable-debug and with KMS -> textures are mi

[Mesa3d-dev] [Bug 25016] corruption regression probably after texformat-rework branch

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 --- Comment #3 from Fabio 2009-12-04 04:20:26 PST --- Created an attachment (id=31733) --> (http://bugs.freedesktop.org/attachment.cgi?id=31733) full console output with mesa *7.6* compiled with --enable-debug and with KMS -> it works fine

[Mesa3d-dev] [Bug 25016] corruption regression probably after texformat-rework branch

2009-12-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25016 --- Comment #2 from Maciej Cencora 2009-12-04 03:46:33 PST --- Please compile mesa with --enable-debug option, and attach full app output. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving