Re: [Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-04 Thread Chia-I Wu
On Mon, Jan 4, 2010 at 4:24 AM, José Fonseca jfons...@vmware.com wrote: Brian is right. GLAPI controls symbol visibility, both on unices (i.e., _attribute__((visibility(default and windows (i.e., _declspec(dllexport). GLAPIENTRY controls the calling convention (i.e., __stdcall presence or

Re: [Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-04 Thread tom fogal
writes: On Sun, 2010-01-03 at 12:55 -0800, Kristian Høgsberg wrote: On Sun, Jan 3, 2010 at 3:24 PM, José Fonseca jfons...@vmware.com wrote: On Sun, 2010-01-03 at 08:45 -0800, Brian Paul wrote: 2010/1/2 Chia-I Wu olva...@gmail.com: On Sat, Jan 02, 2010 at 07:01:02PM -0500, Kristian

Re: [Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-03 Thread Brian Paul
2010/1/2 Chia-I Wu olva...@gmail.com: On Sat, Jan 02, 2010 at 07:01:02PM -0500, Kristian Høgsberg wrote: We have all functions that need to be visible marked with PUBLIC and this is trimming around 4% off the DRI driver .so size. I love this change! It might require another patch, but would

Re: [Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-03 Thread Kristian Høgsberg
On Sun, Jan 3, 2010 at 3:24 PM, José Fonseca jfons...@vmware.com wrote: On Sun, 2010-01-03 at 08:45 -0800, Brian Paul wrote: 2010/1/2 Chia-I Wu olva...@gmail.com: On Sat, Jan 02, 2010 at 07:01:02PM -0500, Kristian Høgsberg wrote: We have all functions that need to be visible marked with

Re: [Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-03 Thread José Fonseca
On Sun, 2010-01-03 at 12:55 -0800, Kristian Høgsberg wrote: On Sun, Jan 3, 2010 at 3:24 PM, José Fonseca jfons...@vmware.com wrote: On Sun, 2010-01-03 at 08:45 -0800, Brian Paul wrote: 2010/1/2 Chia-I Wu olva...@gmail.com: On Sat, Jan 02, 2010 at 07:01:02PM -0500, Kristian Høgsberg wrote:

[Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-02 Thread Kristian Høgsberg
We have all functions that need to be visible marked with PUBLIC and this is trimming around 4% off the DRI driver .so size. --- Is there a reason this isn't on by default? cheers, Kristian configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac

Re: [Mesa3d-dev] [PATCH] Compile with -fvisibility-hidden by default

2010-01-02 Thread Chia-I Wu
On Sat, Jan 02, 2010 at 07:01:02PM -0500, Kristian Høgsberg wrote: We have all functions that need to be visible marked with PUBLIC and this is trimming around 4% off the DRI driver .so size. I love this change! It might require another patch, but would it be possible to stop marking functions