Re: [Mesa3d-dev] [PATCH] Revert st/dri: no need to request fake front buffer, only handle it being returned

2009-12-31 Thread Michel Dänzer
On Wed, 2009-12-30 at 20:37 +0100, Thomas Hellstrom wrote: 
 This reverts commit 1336989ec60fff7bd590fefd28945a0e5dc536e3.
 
 The commit breaks
 a) Front buffer rendering on X servers  1.7.
 b) The possibility to add conditional front buffer requests on older
 X servers.
 
 Since the commit uses a new feature of the DRI protocol, the code must
 be conditioned on a version bump on the server side. (For example a server
 side protocol bump to 1.2, and a corresponding client check).

Unfortunately, that didn't happen though... So I don't think this can go
in as is.


-- 
Earthling Michel Dänzer   |http://www.vmware.com
Libre software enthusiast |  Debian, X and DRI developer

--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev


Re: [Mesa3d-dev] [PATCH] Revert st/dri: no need to request fake front buffer, only handle it being returned

2009-12-31 Thread Thomas Hellstrom
Michel Dänzer wrote:
 On Wed, 2009-12-30 at 20:37 +0100, Thomas Hellstrom wrote: 
   
 This reverts commit 1336989ec60fff7bd590fefd28945a0e5dc536e3.

 The commit breaks
 a) Front buffer rendering on X servers  1.7.
 b) The possibility to add conditional front buffer requests on older
 X servers.

 Since the commit uses a new feature of the DRI protocol, the code must
 be conditioned on a version bump on the server side. (For example a server
 side protocol bump to 1.2, and a corresponding client check).
 

 Unfortunately, that didn't happen though... So I don't think this can go
 in as is.

   

I strongly think we should revert now, and condition this code on a 
version bump. If it hasn't happened yet, we should bump now and accept 
any breakage that happens in-between. We can't just start using new 
features on other software packages without proper version checking, 
breaking anything that doesn't have that feature.

/Thomas



--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev