Re: t/cindex.t "associate w/o search" test hangs for me

2023-11-15 Thread Eric Wong
Konstantin Ryabitsev wrote: > I'm quite happy to not require libgit2 -- I've always found it easier to just > use git plumbing commands even if this requires exec'ing an external > executable. Yeah, I don't have libgit2 installed on most of my systems, either. Hoping git itself eventually makes

Re: [PATCH] cindex: fix test when missing time(1) executable

2023-11-15 Thread Konstantin Ryabitsev
On Wed, Nov 15, 2023 at 05:55:49AM +, Eric Wong wrote: > Eric Wong wrote: > > +++ b/t/cindex.t > > @@ -210,7 +210,7 @@ EOM > > my $cmd = [ qw(-cindex -u --all --associate -d), "$tmp/ext", > > '-I', $basic->{inboxdir} ]; > > $cidx_out = $cidx_err = ''; > > -

Re: t/cindex.t "associate w/o search" test hangs for me

2023-11-15 Thread Konstantin Ryabitsev
On Wed, Nov 15, 2023 at 03:09:28AM +, Eric Wong wrote: > > t/imapd.t 2/? Bailout called. Further testing > > stopped: FETCH socket closed while reading data from server > > FAILED--Further testing stopped: FETCH socket closed while reading data > > from server > >

RE: [Question] review links are disappearing from the qemu-devel mailing-list

2023-11-15 Thread Salil Mehta
Hi Konstantin, > From: Salil Mehta > Sent: Tuesday, November 14, 2023 5:25 PM > To: 'Konstantin Ryabitsev' ; Eric Wong > > > Hi Konstantin, > > > From: Konstantin Ryabitsev > > Sent: Tuesday, November 14, 2023 4:59 PM > > To: Eric Wong > > > > On Tue, Nov 14, 2023 at 04:36:29PM +, Eric

[PATCH 4/4] lei q|up|convert: common finish_output to detect errors

2023-11-15 Thread Eric Wong
We need to consistently check the exit code of pigz|gzip|xz|bzip2 when writing to compressed mboxes (or bad storage). --- lib/PublicInbox/LeiConvert.pm | 4 ++-- lib/PublicInbox/LeiToMail.pm | 11 +++ lib/PublicInbox/LeiXSearch.pm | 9 + 3 files changed, 14 insertions(+), 10

[PATCH 3/4] lei: avoid extra fork for v2 outputs

2023-11-15 Thread Eric Wong
We've always forced LeiToMail to only have one process for v2 outputs anyways since v2 has its own sharding and IPC. Thus we can use the single LeiToMail process directly to avoid extra IPC overhead. --- lib/PublicInbox/LeiConvert.pm | 7 ++- lib/PublicInbox/LeiToMail.pm | 19

[PATCH 0/4] lei convert: support idempotent v2 outputs

2023-11-15 Thread Eric Wong
This may make it easier for public-inbox admins to forcibly inject missing messages from existing mbox*/maildir/IMAP/NNTP archives. 1/4 was only needed to get 2/4 working, but 3/4 makes it unnecessary with our current codebase (though we may still need 1/4 in the future). 4/4 was noticed while

[PATCH 1/4] lei: fix idempotent STDERR redirect in workers

2023-11-15 Thread Eric Wong
This is needed to support forking from already-forked lei workers and $lei->{2} is already STDERR. Fixes: e015c3742f91 (lei: use autodie where appropriate, 2023-10-17) --- lib/PublicInbox/LEI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/LEI.pm

[PATCH 2/4] lei convert: fix repeat and idempotent v2 output

2023-11-15 Thread Eric Wong
We should be able to treat v2 outputs just like any other mail format, with the exception that content dedupe is always enforced by the v2 format. This allows users hosting v2 public-inboxes to catch up broken synchronization from alternate archives such as the mbox archives hosted by

[PATCH 4/3] xap_helper_cxx: accept leading spaces from pkg-config

2023-11-15 Thread Eric Wong
Eric Wong wrote: > Avoid mixing autodie use in different scopes since it's likely > to cause problems like it did in Gcf2. While none of these > fix known problems with test cases, it's likely worthwhile to > avoid it anyways to avoid future surprises. > lib/PublicInbox/XapHelperCxx.pm | 18