Unlike modern Perls, Perl 5.16.3 on CentOS doesn't accept negative string signals like "-TERM" .
This only became a problem since commit b231d91f42d7 (treewide: enable warnings in all exec-ed processes) made our code stricter by enabling more warnings. In both cases, the kill is probably unnecessary and safe to remove since we can rely on closing sockets to drop processes. --- lib/PublicInbox/LEI.pm | 2 +- lib/PublicInbox/LeiXSearch.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 77acb5a1..69065ce7 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -474,7 +474,7 @@ my @WQ_KEYS = qw(lxs l2m ikw pmd wq1 lne v2w); # internal workers sub _drop_wq { my ($self) = @_; for my $wq (grep(defined, delete(@$self{@WQ_KEYS}))) { - $wq->wq_kill('-TERM'); + $wq->wq_kill(-POSIX::SIGTERM()); $wq->DESTROY; } } diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm index b09c2462..e85fd3c4 100644 --- a/lib/PublicInbox/LeiXSearch.pm +++ b/lib/PublicInbox/LeiXSearch.pm @@ -437,7 +437,7 @@ sub do_post_augment { my $err = $@; if ($err) { if (my $lxs = delete $lei->{lxs}) { - $lxs->wq_kill('-TERM'); + $lxs->wq_kill(-POSIX::SIGTERM()); $lxs->wq_close; } $lei->fail("$err");