Re: [PATCH 1/2] viewvcs: parallelize commit display

2024-02-12 Thread Eric Wong
Eric Wong wrote: > times down to ~6s (still slow). Avoiding patch generation for > root commits (like cgit also does) brings it down to a few > hundred milliseconds on a public-facing server. Actually, the "(like cgit also does)" bit is wrong: cgit generates a full patch, 355MB worth of HTML!

[PATCH 1/2] xap_helper_cxx: -O2 optimize read-only files by default

2024-02-12 Thread Eric Wong
While fast build times from -O0 is critical to my sanity when actively working on C++, the files installed via package managers or `make install' aren't likely to change frequently. In that case, expensive -O2 optimizations make sense since the 10-20s saved from a single large --join more than

[PATCH 0/2] xap_helper C++ fixes

2024-02-12 Thread Eric Wong
I suppose -O2 build times isn't the worst thing for release users even though I can't stand it while hacking... Eric Wong (2): xap_helper_cxx: -O2 optimize read-only files by default codesearch: generate_cxx: drop unused variables lib/PublicInbox/CodeSearch.pm | 1 -

[PATCH 2/2] codesearch: generate_cxx: drop unused variables

2024-02-12 Thread Eric Wong
We are just using the odd ref+deref (`${\...}') syntax and don't need to calculate line numbers ourselves, nowadays. --- lib/PublicInbox/CodeSearch.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/CodeSearch.pm b/lib/PublicInbox/CodeSearch.pm index 48697cdc..1f95a726 100644

Re: lei up can't fetch new thread messages when searching by mid

2024-02-12 Thread Pratyush Yadav
Hi, On Fri, Feb 09 2024, Eric Wong wrote: > Pratyush Yadav wrote: > > yeah, known problem, whole thread from last year... > > https://public-inbox.org/meta/20230330112951.M493025@dcvr/T/ > >> Is there a way to properly subscribe to an email thread? I suppose I can >> do query the subject

[PATCH 1/2] viewvcs: parallelize commit display

2024-02-12 Thread Eric Wong
Similar to commit cbe2548c91859dfb923548ea85d8531b90d53dc3 (www_coderepo: use OnDestroy to render summary view, 2023-04-09), we can rely on OnDestroy and Qspawn to run dependencies in a structured way and with some extra parallelism for SMP users. Perl (as opposed to POSIX sh) allows us to easily

[PATCH 0/2] viewvcs improvements

2024-02-12 Thread Eric Wong
Major speedups for root commits, and a smaller speedup for giant non-root commits too large to show. 2/2 fixes some long-standing HTML generation bugs :x Eric Wong (2): viewvcs: parallelize commit display viewvcs: HTML fixes for commits lib/PublicInbox/ViewVCS.pm | 104

[PATCH 2/2] viewvcs: HTML fixes for commits

2024-02-12 Thread Eric Wong
The "patch is too large to show" text is now broken by an to prevent it from being confused as part of a commit message (or having somebody intentionally insert that text in a commit message to confuse readers). A missing is also necessary before the tag for the related commit search form. ---