Re: [meta-arago] [oe-layersetup PATCH v2] processor-sdk: Add 07.03.00.005 release config
On 8/9/2021 1:24 PM, Denys Dmytriyenko wrote: On Mon, Aug 09, 2021 at 11:47:31PM +0530, Nikhil Devshatwar wrote: On 11:50-20210806, Bajjuri, Praneeth wrote: +#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers= +meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,b4d24d70aca75791902df5cd59a4f4a54aa4a125,layers= +meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,89abc62b47f6f20db9d00a8ec9b2c1b6b60ac3f9,layers= +meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,389757a7494221fea1d8437e9a01c6e4fb4700af,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems +meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,07.03.00.005,layers= +meta-linaro,https://git.linaro.org/openembedded/meta-linaro.git,dunfell,HEAD,layers=meta-optee Please close the open item with HEAD being used instead of commit ID for this patch to be accepted. By the way, why do you even need meta-linaro layer for psdkl builds? Looks like it is added for meta-optee, but it has since Dunfell been moved to meta-arm... +meta-arm,git://git.yoctoproject.org/meta-arm,dunfell,c4f04f3fb66f8f4365b08b553af8206372e90a63,layers=meta-arm:meta-arm-toolchain +oe-core,git://git.openembedded.org/openembedded-core,dunfell,707036d4ec12ef1a260adcef78627b26e32e6540,layers=meta +OECORELAYERCONF=./sample-files/bblayers.conf.sample +OECORELOCALCONF=./sample-files/local-processor-sdk-64.conf.sample ___ meta-arago mailing list meta-arago@arago-project.org http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Re: [meta-arago] [oe-layersetup PATCH v2] processor-sdk: Add 07.03.00.005 release config
On 11:50-20210806, Bajjuri, Praneeth wrote: > > > On 8/6/2021 6:48 AM, Priya N S wrote: > > Signed-off-by: Priya N S > > --- > > > > Hi All, > > Kindly ignore the changes made in the V1 patch and consider the > > V2 patch. > > > > Changes made in the V2 patch: > > * Added the processor-sdk-07.03.00.005-config for the 07.03 > >release. > > Why are we doing this at the time of 8.0 release ? will there be a 8.0 based > config too as a separate patch later? We are making 8.0 release for the AM64 today. I will submit config file for that soon. > > Anyhow, this patch is a NACK. See review comments below. > > > > * This corresponds to the 07.03 release for the am335x-evm > >and am437x-evm platforms. > > > > .../processor-sdk-07.03.00.005-config.txt | 17 + > > 1 file changed, 17 insertions(+) > > create mode 100644 > > configs/processor-sdk/processor-sdk-07.03.00.005-config.txt > > > > diff --git a/configs/processor-sdk/processor-sdk-07.03.00.005-config.txt > > b/configs/processor-sdk/processor-sdk-07.03.00.005-config.txt > > new file mode 100644 > > index 000..09bde9e > > --- /dev/null > > +++ b/configs/processor-sdk/processor-sdk-07.03.00.005-config.txt > > Did the convention followed for processor-sdk change? > Ex: I see 106* used for the last part of the release name (may be pointing > to a build number) > Ref: > http://arago-project.org/git/projects/oe-layersetup.git?p=projects/oe-layersetup.git;a=commit;h=30111f3c58442c088969a548dcd6c9140c422da8 > > > > @@ -0,0 +1,17 @@ > > +# This file takes repo entries in the format > > +# repo name,repo uri,repo branch,repo > > commit[,layers=layer1:layer2...:layern] > > + > > +bitbake,git://git.openembedded.org/bitbake,1.46,017a39ed05d065bf28fd38f91bcde8a098300551 > > +meta-processor-sdk,git://git.ti.com/processor-sdk/meta-processor-sdk.git,dunfell,c467012684e57c914c4070238987e931f329da15,layers= > > > > Why commitsha and not a 07.03* tag ? > > Nikhil, does this look correct? This is correct. You won't find any tags in meta-processor-sdk All the config files have a commit SHA only. > > > +meta-arago,git://arago-project.org/git/meta-arago.git,dunfell,07.03.00.005,layers=meta-arago-distro:meta-arago-extras > > +meta-aws,https://github.com/aws/meta-aws.git,dunfell,HEAD,layers= > > HEAD >> This doesnt look right for the config snapshot. You need to pick the > exact commitsha used for your release tagged images ( you should see that in > build-config file) > I agree with Praneeth here. We have to make sure that the release config file can reproduce the build. Using HEAD defeats the purpose. Please replace with commit SHA or tag everywhere in release file. Regards, Nikhil D > > +#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers= > > +meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,b4d24d70aca75791902df5cd59a4f4a54aa4a125,layers= > > +meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,89abc62b47f6f20db9d00a8ec9b2c1b6b60ac3f9,layers= > > +meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,389757a7494221fea1d8437e9a01c6e4fb4700af,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems > > +meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,07.03.00.005,layers= > > +meta-linaro,https://git.linaro.org/openembedded/meta-linaro.git,dunfell,HEAD,layers=meta-optee > > Similar comment as above of meta-aws. HEAD is not correct for release > snapshot. > By the way, why do you even need meta-linaro layer for psdkl builds? > > > > +meta-arm,git://git.yoctoproject.org/meta-arm,dunfell,c4f04f3fb66f8f4365b08b553af8206372e90a63,layers=meta-arm:meta-arm-toolchain > > +oe-core,git://git.openembedded.org/openembedded-core,dunfell,707036d4ec12ef1a260adcef78627b26e32e6540,layers=meta > > +OECORELAYERCONF=./sample-files/bblayers.conf.sample > > +OECORELOCALCONF=./sample-files/local-processor-sdk-64.conf.sample > > ___ meta-arago mailing list meta-arago@arago-project.org http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Re: [meta-arago] [oe-layersetup PATCH v2] processor-sdk: Add 07.03.00.005 release config
On Mon, Aug 09, 2021 at 11:47:31PM +0530, Nikhil Devshatwar wrote: > On 11:50-20210806, Bajjuri, Praneeth wrote: > > > +#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers= > > > +meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,b4d24d70aca75791902df5cd59a4f4a54aa4a125,layers= > > > +meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,89abc62b47f6f20db9d00a8ec9b2c1b6b60ac3f9,layers= > > > +meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,389757a7494221fea1d8437e9a01c6e4fb4700af,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems > > > +meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,07.03.00.005,layers= > > > +meta-linaro,https://git.linaro.org/openembedded/meta-linaro.git,dunfell,HEAD,layers=meta-optee > > > > By the way, why do you even need meta-linaro layer for psdkl builds? Looks like it is added for meta-optee, but it has since Dunfell been moved to meta-arm... > > > +meta-arm,git://git.yoctoproject.org/meta-arm,dunfell,c4f04f3fb66f8f4365b08b553af8206372e90a63,layers=meta-arm:meta-arm-toolchain > > > +oe-core,git://git.openembedded.org/openembedded-core,dunfell,707036d4ec12ef1a260adcef78627b26e32e6540,layers=meta > > > +OECORELAYERCONF=./sample-files/bblayers.conf.sample > > > +OECORELOCALCONF=./sample-files/local-processor-sdk-64.conf.sample > > > > -- Regards, Denys Dmytriyenko PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964 Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964 ___ meta-arago mailing list meta-arago@arago-project.org http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Re: [meta-arago] [oe-layersetup PATCH v2] processor-sdk: Add 07.03.00.005 release config
On 8/6/2021 6:48 AM, Priya N S wrote: Signed-off-by: Priya N S --- Hi All, Kindly ignore the changes made in the V1 patch and consider the V2 patch. Changes made in the V2 patch: * Added the processor-sdk-07.03.00.005-config for the 07.03 release. Why are we doing this at the time of 8.0 release ? will there be a 8.0 based config too as a separate patch later? Anyhow, this patch is a NACK. See review comments below. * This corresponds to the 07.03 release for the am335x-evm and am437x-evm platforms. .../processor-sdk-07.03.00.005-config.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 configs/processor-sdk/processor-sdk-07.03.00.005-config.txt diff --git a/configs/processor-sdk/processor-sdk-07.03.00.005-config.txt b/configs/processor-sdk/processor-sdk-07.03.00.005-config.txt new file mode 100644 index 000..09bde9e --- /dev/null +++ b/configs/processor-sdk/processor-sdk-07.03.00.005-config.txt Did the convention followed for processor-sdk change? Ex: I see 106* used for the last part of the release name (may be pointing to a build number) Ref: http://arago-project.org/git/projects/oe-layersetup.git?p=projects/oe-layersetup.git;a=commit;h=30111f3c58442c088969a548dcd6c9140c422da8 @@ -0,0 +1,17 @@ +# This file takes repo entries in the format +# repo name,repo uri,repo branch,repo commit[,layers=layer1:layer2...:layern] + +bitbake,git://git.openembedded.org/bitbake,1.46,017a39ed05d065bf28fd38f91bcde8a098300551 +meta-processor-sdk,git://git.ti.com/processor-sdk/meta-processor-sdk.git,dunfell,c467012684e57c914c4070238987e931f329da15,layers= Why commitsha and not a 07.03* tag ? Nikhil, does this look correct? +meta-arago,git://arago-project.org/git/meta-arago.git,dunfell,07.03.00.005,layers=meta-arago-distro:meta-arago-extras +meta-aws,https://github.com/aws/meta-aws.git,dunfell,HEAD,layers= HEAD >> This doesnt look right for the config snapshot. You need to pick the exact commitsha used for your release tagged images ( you should see that in build-config file) +#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers= +meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,b4d24d70aca75791902df5cd59a4f4a54aa4a125,layers= +meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,89abc62b47f6f20db9d00a8ec9b2c1b6b60ac3f9,layers= +meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,389757a7494221fea1d8437e9a01c6e4fb4700af,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems +meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,07.03.00.005,layers= +meta-linaro,https://git.linaro.org/openembedded/meta-linaro.git,dunfell,HEAD,layers=meta-optee Similar comment as above of meta-aws. HEAD is not correct for release snapshot. By the way, why do you even need meta-linaro layer for psdkl builds? +meta-arm,git://git.yoctoproject.org/meta-arm,dunfell,c4f04f3fb66f8f4365b08b553af8206372e90a63,layers=meta-arm:meta-arm-toolchain +oe-core,git://git.openembedded.org/openembedded-core,dunfell,707036d4ec12ef1a260adcef78627b26e32e6540,layers=meta +OECORELAYERCONF=./sample-files/bblayers.conf.sample +OECORELOCALCONF=./sample-files/local-processor-sdk-64.conf.sample ___ meta-arago mailing list meta-arago@arago-project.org http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
