Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

. BR, Awais From: Cal Sullivan <california.l.sulli...@intel.com> Sent: Saturday, March 31, 2018 2:26 AM To: Belal, Awais; Kevin Hao Cc: meta-intel@yoctoproject.org Subject: Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include Hi Awais, Kevin, In testing I ran int

Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

Hi Awais, Kevin, In testing I ran into some compilation problems: https://pastebin.com/n8dhUmZT I was able to fix it by disabling some options, but I don't know the ramifications of these changes. In working on this I noticed most of the sed commands in that do_configure block could use a

Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include On Wed, Mar 28, 2018 at 11:34:42AM -0700, Cal Sullivan wrote: > Is patch 1/2 good to merge? Yes. > > It looks like in order for 18.02 and 17.11 to use the same .inc file we will > need to move the LIC_FILES_CHK

Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

On Wed, Mar 28, 2018 at 11:34:42AM -0700, Cal Sullivan wrote: > Is patch 1/2 good to merge? Yes. > > It looks like in order for 18.02 and 17.11 to use the same .inc file we will > need to move the LIC_FILES_CHKSUM out of it, but that can be done later. 17.11 > seems to have upstreamed the same

Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

Is patch 1/2 good to merge? It looks like in order for 18.02 and 17.11 to use the same .inc file we will need to move the LIC_FILES_CHKSUM out of it, but that can be done later. 17.11 seems to have upstreamed the same patch that was dropped in this upgrade, so we're good on that front as

Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

On Wed, Mar 28, 2018 at 12:27:48PM +0500, Awais Belal wrote: > Since we only have a single version supported at the > moment, which is the latest and the greatest. It is > best that the include and base recipe files are merged > to allow better maintainability and readability. Please don't do

[meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

Since we only have a single version supported at the moment, which is the latest and the greatest. It is best that the include and base recipe files are merged to allow better maintainability and readability. Signed-off-by: Awais Belal --- recipes-extended/dpdk/dpdk.inc