Re: [meta-intel] [PATCH] IGT: update 1.14 -> 1.15

2016-09-22 Thread Saul Wold 
On Mon, 2016-09-12 at 08:17 +1200, Paul Eggleton wrote:
> Hi Jianxin,
> 
> On Fri, 09 Sep 2016 10:50:50 Jianxun Zhang wrote:
> > 
> > > 
> > > On Sep 9, 2016, at 7:34 AM, Saul Wold 
> > > wrote:
> > > On Thu, 2016-09-08 at 17:02 -0700, Jianxun Zhang wrote:
> > > > 
> > > > This change update intel-gpu-tools to 1.15 as a sync-up with
> > > > Intel graphic stack 2016 Q2 release.
> > > > 
> > > > This change explicitly sets ${PV} in recipe and renames it
> > > > after package name only. By doing so we don't need to enforce
> > > > a policy to rename recipe every time we do update. Patch
> > > > speaks itself.
> > > 
> > > This is wrong!
> > > 
> > > The whole point of naming the recipe as ${PN}_${PV} is to remove
> > > the
> > > need to update PV in the recipe.
> > > 
> > > Yes checksums need to be updated on a regular basis, there are
> > > tools
> > > like devtool that can assist with this.
> > > 
> > > The OpenEmbedded standard is for $PN_$PV.bb filename this also
> > > assists
> > > in understand quickly what version a particular recipe is.  There
> > > are
> > > also limited cases where 2 different $PVs are needed for some
> > > reasons.
> > > 
> > > Please resubmit this as a normal update with $PV contained in the
> > > file
> > > name.
> > > 
> > > Please see: https://wiki.yoctoproject.org/wiki/Best_Known_Methods
> > > _(BKMs
> > > )_for_Package_Updating
> > 
> > Saul,
> > I think the drawback of current procedure is it causes git “resets"
> > history
> > on recipe since new recipe when a renamed or git mv-ed recipe also
> > have too
> > much modifications. I don’t think git really tracks moving or
> > renaming:
> 
> It doesn't reset history. You're right that it doesn't track renames
> - that's 
> because rename detection is done whenever git looks at a change, not
> when the 
> change is applied. If you want to see the full history including
> renames, use 
> the --follow option.
> 
> Saul is correct, use of PV in the recipe filename is standard OE
> practice and 
> we don't want to be deviating from that - besides which I'm not sure
> we have 
> much to gain by doing so.
> 
Just to continue to clarify further:
1) The version adds uniqueness when there are multiple version
2) It's human readable for parsing by the eyes
3) There are some performance benefits to scripts and tools since they
do not have to open the file to parse out the PV 

Sau!

> Cheers,
> Paul
> 
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH 1/2] linux-yocto/4.4: Bump SRCREVs from v4.4.18 to v4.4.20

2016-09-22 Thread Cal Sullivan 
Yep, sorry about that. I had a patch in my queue to fix this, but hadn't 
gotten around to it yet. Sent it off just now.


Thanks,
Cal

On 09/22/2016 11:31 AM, Trevor Woerner wrote:

On Mon 2016-09-12 @ 02:38:04 PM, California Sullivan wrote:

 From linux-yocto-4.4:

---
  common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend   | 4 ++--
  common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend | 4 ++--
  common/recipes-kernel/linux/linux-yocto_4.4.bbappend  | 4 ++--
  3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend 
b/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
index f0dd1e0..b228941 100644
--- a/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
@@ -1,8 +1,8 @@
  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
  
  LINUX_VERSION_INTEL_COMMON = "4.4.18"

The above, and subsequent, need to be:
LINUX_VERSION_INTEL_COMMON = "4.4.20"

otherwise:

ERROR: linux-yocto-rt-4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0 
do_kernel_version_sanity_check: Package Version 
(4.4.18+gitAUTOINC+59290c5f61_b5e21aa988) does not match of kernel being built 
(4.4.20). Please update the PV variable to match the kernel source.
ERROR: linux-yocto-rt-4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0 
do_kernel_version_sanity_check: Function failed: do_kernel_version_sanity_check 
(log file is located at 
/z/layerindex-master/minnowmax/tmp/work/corei7-64-intel-common-fortress-linux/linux-yocto-rt/4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0/temp/log.do_kernel_version_sanity_check.20430)
ERROR: Logfile of failure stored in: 
/z/layerindex-master/minnowmax/tmp/work/corei7-64-intel-common-fortress-linux/linux-yocto-rt/4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0/temp/log.do_kernel_version_sanity_check.20430
ERROR: Task 
(/z/layerindex-master/layers/openembedded-core/meta/recipes-kernel/linux/linux-yocto-rt_4.4.bb:do_kernel_version_sanity_check)
 failed with exit code '1'


--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

[meta-intel] [PATCH 1/1] linux-yocto*: Fix LINUX_VERSION variables

2016-09-22 Thread California Sullivan 
I was checking the kver file to update the LINUX_VERSION variable. At
the time of the last SRCREV update the kver files were incorrect. With
the kernel_version_sanity_check function added to oe-core, the
incorrect PV becomes a build error.

Fix this by updating the LINUX_VERSION variables in each linux-yocto
recipe to their correct value.

Signed-off-by: California Sullivan 
---
 common/recipes-kernel/linux/linux-yocto-rt_4.1.bbappend   | 2 +-
 common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend   | 2 +-
 common/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend | 2 +-
 common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend | 2 +-
 common/recipes-kernel/linux/linux-yocto_4.1.bbappend  | 2 +-
 common/recipes-kernel/linux/linux-yocto_4.4.bbappend  | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common/recipes-kernel/linux/linux-yocto-rt_4.1.bbappend 
b/common/recipes-kernel/linux/linux-yocto-rt_4.1.bbappend
index 7a25ca8..17e514f 100644
--- a/common/recipes-kernel/linux/linux-yocto-rt_4.1.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto-rt_4.1.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-LINUX_VERSION_INTEL_COMMON = "4.1.30"
+LINUX_VERSION_INTEL_COMMON = "4.1.31"
 SRCREV_META_INTEL_COMMON ?= "cf6d9876629270e8ed99541db252840291d03f5a"
 SRCREV_MACHINE_INTEL_COMMON ?= "7370721cafa5a420bef873f3b0547f1135aba0db"
 
diff --git a/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend 
b/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
index b228941..8ec80fb 100644
--- a/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-LINUX_VERSION_INTEL_COMMON = "4.4.18"
+LINUX_VERSION_INTEL_COMMON = "4.4.20"
 SRCREV_META_INTEL_COMMON ?= "59290c5f6192da2eccf478d37a8f9f88134822b3"
 SRCREV_MACHINE_INTEL_COMMON ?= "b5e21aa9882c815fe522810cce2e3c86e20ffee2"
 
diff --git a/common/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend 
b/common/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend
index 56af19f..a488e87 100644
--- a/common/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-#LINUX_VERSION_i586-nlp-32-intel-common = "4.1.30"
+LINUX_VERSION_i586-nlp-32-intel-common = "4.1.31"
 SRCREV_meta_i586-nlp-32-intel-common = 
"cf6d9876629270e8ed99541db252840291d03f5a"
 SRCREV_machine_i586-nlp-32-intel-common = 
"488286187ea5bda2e35730e5593f040c9f0f34d1"
 
diff --git a/common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend 
b/common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend
index 31dbb1c..31402ea 100644
--- a/common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-#LINUX_VERSION_i586-nlp-32-intel-common = "4.4.18"
+LINUX_VERSION_i586-nlp-32-intel-common = "4.4.20"
 SRCREV_meta_i586-nlp-32-intel-common = 
"59290c5f6192da2eccf478d37a8f9f88134822b3"
 SRCREV_machine_i586-nlp-32-intel-common = 
"2cbbf10c66383c0c052708686ab005a9f9dc442c"
 
diff --git a/common/recipes-kernel/linux/linux-yocto_4.1.bbappend 
b/common/recipes-kernel/linux/linux-yocto_4.1.bbappend
index 5b38d93..c093ebd 100644
--- a/common/recipes-kernel/linux/linux-yocto_4.1.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto_4.1.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-LINUX_VERSION_INTEL_COMMON = "4.1.30"
+LINUX_VERSION_INTEL_COMMON = "4.1.31"
 SRCREV_META_INTEL_COMMON = "cf6d9876629270e8ed99541db252840291d03f5a"
 SRCREV_MACHINE_INTEL_COMMON = "518132aeea9ac874fd4c51cd02b137704e00c3ae"
 
diff --git a/common/recipes-kernel/linux/linux-yocto_4.4.bbappend 
b/common/recipes-kernel/linux/linux-yocto_4.4.bbappend
index 10abfb5..f7f3c5a 100644
--- a/common/recipes-kernel/linux/linux-yocto_4.4.bbappend
+++ b/common/recipes-kernel/linux/linux-yocto_4.4.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-LINUX_VERSION_INTEL_COMMON = "4.4.18"
+LINUX_VERSION_INTEL_COMMON = "4.4.20"
 SRCREV_META_INTEL_COMMON = "59290c5f6192da2eccf478d37a8f9f88134822b3"
 SRCREV_MACHINE_INTEL_COMMON = "94e5bb30eaf8a880a6c82b64a497d8b4a855d138"
 
-- 
2.5.5

-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH 1/2] linux-yocto/4.4: Bump SRCREVs from v4.4.18 to v4.4.20

2016-09-22 Thread Trevor Woerner 
On Mon 2016-09-12 @ 02:38:04 PM, California Sullivan wrote:
> From linux-yocto-4.4:
> 
> ---
>  common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend   | 4 ++--
>  common/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend | 4 ++--
>  common/recipes-kernel/linux/linux-yocto_4.4.bbappend  | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend 
> b/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
> index f0dd1e0..b228941 100644
> --- a/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
> +++ b/common/recipes-kernel/linux/linux-yocto-rt_4.4.bbappend
> @@ -1,8 +1,8 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>  
>  LINUX_VERSION_INTEL_COMMON = "4.4.18"

The above, and subsequent, need to be:
LINUX_VERSION_INTEL_COMMON = "4.4.20"

otherwise:

ERROR: linux-yocto-rt-4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0 
do_kernel_version_sanity_check: Package Version 
(4.4.18+gitAUTOINC+59290c5f61_b5e21aa988) does not match of kernel being built 
(4.4.20). Please update the PV variable to match the kernel source.
ERROR: linux-yocto-rt-4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0 
do_kernel_version_sanity_check: Function failed: do_kernel_version_sanity_check 
(log file is located at 
/z/layerindex-master/minnowmax/tmp/work/corei7-64-intel-common-fortress-linux/linux-yocto-rt/4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0/temp/log.do_kernel_version_sanity_check.20430)
ERROR: Logfile of failure stored in: 
/z/layerindex-master/minnowmax/tmp/work/corei7-64-intel-common-fortress-linux/linux-yocto-rt/4.4.18+gitAUTOINC+59290c5f61_b5e21aa988-r0/temp/log.do_kernel_version_sanity_check.20430
ERROR: Task 
(/z/layerindex-master/layers/openembedded-core/meta/recipes-kernel/linux/linux-yocto-rt_4.4.bb:do_kernel_version_sanity_check)
 failed with exit code '1'
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel