Re: [meta-ti] [PATCH v4 0/3] Enable SGX on k3 (AM654x)

2018-07-13 Thread Denys Dmytriyenko
Thanks! Looks good now, I'll merge it. On Fri, Jul 13, 2018 at 04:54:06PM -0400, Eric Ruei wrote: > Enable SGX on k3 (AM654x) > > Eric Ruei (3): > conf: machine: k3: enable sgx > ti-sgx-ddk-um: add k3 (AM654x) support > ti-sgx-ddk-km: add k3 (AM654x) support > >

[meta-ti] [PATCH v4 1/3] conf: machine: k3: enable sgx

2018-07-13 Thread Eric Ruei
Signed-off-by: Eric Ruei --- conf/machine/include/k3.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/machine/include/k3.inc b/conf/machine/include/k3.inc index 96699db..1c540f3 100644 --- a/conf/machine/include/k3.inc +++ b/conf/machine/include/k3.inc @@ -28,5

[meta-ti] [PATCH v4 2/3] ti-sgx-ddk-um: add k3 (AM654x) support

2018-07-13 Thread Eric Ruei
- add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x) - add k3 support based on SGX DDK 1.17 Signed-off-by: Eric Ruei --- .../libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 + ...14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 22 +- 2 files changed, 6

[meta-ti] [PATCH v4 3/3] ti-sgx-ddk-km: add k3 (AM654x) support

2018-07-13 Thread Eric Ruei
- add K3 (AM654x) support based on SGX DDK 1.17 Signed-off-by: Eric Ruei --- ...-ddk-km_1.14.3699939.bb => ti-sgx-ddk-km_1.17.4948957.bb} | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) copy recipes-bsp/powervr-drivers/{ti-sgx-ddk-km_1.14.3699939.bb =>

[meta-ti] [PATCH v4 0/3] Enable SGX on k3 (AM654x)

2018-07-13 Thread Eric Ruei
Enable SGX on k3 (AM654x) Eric Ruei (3): conf: machine: k3: enable sgx ti-sgx-ddk-um: add k3 (AM654x) support ti-sgx-ddk-km: add k3 (AM654x) support conf/machine/include/k3.inc| 4 ++-- ...14.3699939.bb => ti-sgx-ddk-km_1.17.4948957.bb} | 12 +---

Re: [meta-ti] [PATCH v2 0/3] Enable SGX on k3 (AM654x)

2018-07-13 Thread Ruei, Eric
I do not see any comments on this one. Eric -Original Message- From: Dmytriyenko, Denys Sent: Friday, July 13, 2018 1:30 PM To: Ruei, Eric Cc: meta-ti@yoctoproject.org Subject: Re: [meta-ti] [PATCH v2 0/3] Enable SGX on k3 (AM654x) Eric, Thanks for addressing most of my comments!

Re: [meta-ti] [PATCH v3 3/3] ti-sgx-ddk-km: add k3 (AM654x) support

2018-07-13 Thread Ruei, Eric
The kernel module is the same for all window system. The DDK 1.17 provides three window systems (nulldrmws, wayland and org (default)). I can create the one for nulldrmws by export the environment variable WINDOW_SYSTEM=nulldrmws Is there a way that I can do that at the recipe? Best regards,

Re: [meta-ti] [PATCH v3 3/3] ti-sgx-ddk-km: add k3 (AM654x) support

2018-07-13 Thread Denys Dmytriyenko
Fair point about kernel module. I was more concerned about UM binaries. I wonder if we should keep the kernel module and its path synced up with UM part, or otherwise it may be confusing... -- Denys On Fri, Jul 13, 2018 at 03:21:46PM -0400, Ruei, Eric wrote: > The kernel module is the same

Re: [meta-ti] [PATCH v2 2/3] ti-sgx-ddk-um: add k3 (AM654x) support

2018-07-13 Thread Denys Dmytriyenko
On Wed, Jul 11, 2018 at 11:45:30AM -0400, Eric Ruei wrote: > - add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x) > - add k3 support based on SGX DDK 1.17 > > Signed-off-by: Eric Ruei > --- > recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 + >

Re: [meta-ti] [PATCH v3 3/3] ti-sgx-ddk-km: add k3 (AM654x) support

2018-07-13 Thread Denys Dmytriyenko
On Fri, Jul 13, 2018 at 03:10:16PM -0400, Eric Ruei wrote: > - add K3 (AM654x) support based on SGX DDK 1.17 > > Signed-off-by: Eric Ruei > --- > ...gx-ddk-km_1.14.3699939.bb => ti-sgx-ddk-km_1.17.4948957.bb} | 10 > -- > 1 file changed, 4 insertions(+), 6 deletions(-) > copy

Re: [meta-ti] [PATCH v2 0/3] Enable SGX on k3 (AM654x)

2018-07-13 Thread Denys Dmytriyenko
On Fri, Jul 13, 2018 at 02:11:18PM -0400, Ruei, Eric wrote: > I do not see any comments on this one. Sorry for the confusion - I meant inside the patches themselves, not the cover letter. > -Original Message- > From: Dmytriyenko, Denys > Sent: Friday, July 13, 2018 1:30 PM > To: Ruei,

Re: [meta-ti] [PATCH v3 2/3] ti-sgx-ddk-um: add k3 (AM654x) support

2018-07-13 Thread Ruei, Eric
Got it finally. V4 is coming. Eric -Original Message- From: Dmytriyenko, Denys Sent: Friday, July 13, 2018 3:12 PM To: Ruei, Eric Cc: meta-ti@yoctoproject.org Subject: Re: [meta-ti] [PATCH v3 2/3] ti-sgx-ddk-um: add k3 (AM654x) support On Fri, Jul 13, 2018 at 03:10:15PM -0400, Eric

Re: [meta-ti] [PATCH v2 0/3] Enable SGX on k3 (AM654x)

2018-07-13 Thread Denys Dmytriyenko
Eric, Thanks for addressing most of my comments! This looks much better, but there are still couple issues - please see inside. On Wed, Jul 11, 2018 at 11:45:28AM -0400, Eric Ruei wrote: > Enable SGX on k3 (AM654x) > > Eric Ruei (3): > conf: machine: k3: enable sgx > ti-sgx-ddk-um: add k3

Re: [meta-ti] [PATCH v3 2/3] ti-sgx-ddk-um: add k3 (AM654x) support

2018-07-13 Thread Denys Dmytriyenko
On Fri, Jul 13, 2018 at 03:10:15PM -0400, Eric Ruei wrote: > - add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x) > - add k3 support based on SGX DDK 1.17 > > Signed-off-by: Eric Ruei > --- > recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 + >

Re: [meta-ti] [PATCH v2 3/3] ti-sgx-ddk-km: add k3 (AM654x) support

2018-07-13 Thread Denys Dmytriyenko
On Wed, Jul 11, 2018 at 11:45:31AM -0400, Eric Ruei wrote: > - add K3 (AM654x) support based on SGX DDK 1.17 > > Signed-off-by: Eric Ruei > --- > .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb | 41 > ++ This is still sent as a new recipe, while being very similar to

[meta-ti] [PATCH v3 0/3] Enable SGX on k3 (AM654x)

2018-07-13 Thread Eric Ruei
Enable SGX on k3 (AM654x) Eric Ruei (3): conf: machine: k3: enable sgx ti-sgx-ddk-um: add k3 (AM654x) support ti-sgx-ddk-km: add k3 (AM654x) support conf/machine/include/k3.inc | 4 ++-- ...ddk-km_1.14.3699939.bb => ti-sgx-ddk-km_1.17.4948957.bb} | 10

[meta-ti] [PATCH v3 3/3] ti-sgx-ddk-km: add k3 (AM654x) support

2018-07-13 Thread Eric Ruei
- add K3 (AM654x) support based on SGX DDK 1.17 Signed-off-by: Eric Ruei --- ...gx-ddk-km_1.14.3699939.bb => ti-sgx-ddk-km_1.17.4948957.bb} | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) copy recipes-bsp/powervr-drivers/{ti-sgx-ddk-km_1.14.3699939.bb =>

[meta-ti] [PATCH v3 2/3] ti-sgx-ddk-um: add k3 (AM654x) support

2018-07-13 Thread Eric Ruei
- add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x) - add k3 support based on SGX DDK 1.17 Signed-off-by: Eric Ruei --- recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 1 + ...ddk-um_1.14.3699939.bb => ti-sgx-ddk-um_1.17.4948957.bb} | 13 + 2 files

[meta-ti] [PATCH v3 1/3] conf: machine: k3: enable sgx

2018-07-13 Thread Eric Ruei
Signed-off-by: Eric Ruei --- conf/machine/include/k3.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/machine/include/k3.inc b/conf/machine/include/k3.inc index 96699db..1c540f3 100644 --- a/conf/machine/include/k3.inc +++ b/conf/machine/include/k3.inc @@ -28,5