Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Bruce Ashfield
On Mon, Apr 11, 2022 at 9:45 AM Chen, Qi wrote: > The only package I found which uses /usr/lib/sysctl.d is systemd. > > It packages ${exec_prefix}/lib/sysctl.d. > > And it has its reason. It treats /usr/lib as an arch-independent vendor > dir, and $libdir is treated as the dir to hold libs. > > f

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Chen Qi
The only package I found which uses /usr/lib/sysctl.d is systemd. It packages ${exec_prefix}/lib/sysctl.d. And it has its reason. It treats /usr/lib as an arch-independent vendor dir, and $libdir is treated as the dir to hold libs. file-hierarchy (www.freedesktop.org)

Re: [meta-virtualization][PATCH] k3s: do not use a go file as patch

2022-04-11 Thread Bruce Ashfield
On Fri, Apr 8, 2022 at 1:42 PM Bruce Ashfield via lists.yoctoproject.org wrote: > > > On Fri, Apr 8, 2022 at 1:31 PM Adrian Freihofer < > adrian.freiho...@gmail.com> wrote: > >> Hi Bruce >> >> Build with empty download folder works: >> bitbake k3s -c cleanall >> (cd downloads; find -name \*an

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Bruce Ashfield
On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi wrote: > Hi Bruce, > > > > Looking at the issue a little further, I found we need to use the > hardcoded ‘/usr/lib’. > > This is because sysctl is hardcoding that. > That's a larger issue, and it breaks other parts of the system. We shouldn't have anythin

Re: [meta-virtualization][PATCH] libvirt: package all sysctl conf files for libvirtd

2022-04-11 Thread Bruce Ashfield
On Mon, Apr 11, 2022 at 9:29 AM Chen Qi wrote: > The libvirtd package has already packaged ${sysconfdir}/sysctl.d, > and also the /usr/lib/sysctl.d/60-libvirtd.conf, it would be > reasonable for it to package other sysctl conf files, otherwise > we will meet the following error in case of multili

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Chen Qi
Hi Bruce, Looking at the issue a little further, I found we need to use the hardcoded ‘/usr/lib’. This is because sysctl is hardcoding that. Some codes in sysctl.c from procps: static int PreloadSystem(void) { unsigned di, i; const char *dirs[] = { "/etc/sysctl.d"

[meta-virtualization][PATCH] libvirt: package all sysctl conf files for libvirtd

2022-04-11 Thread Chen Qi
The libvirtd package has already packaged ${sysconfdir}/sysctl.d, and also the /usr/lib/sysctl.d/60-libvirtd.conf, it would be reasonable for it to package other sysctl conf files, otherwise we will meet the following error in case of multilib. QA Issue: libvirt: Files/directories were installed

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Bruce Ashfield
On Mon, Apr 11, 2022 at 9:05 AM Bruce Ashfield via lists.yoctoproject.org wrote: > > > On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi wrote: > >> Hi Bruce & Preeti, >> >> >> >> I was trying to fix the same issue when I found this thread. >> >> This issue appears when multilib is enabled. >> >> >> >> W

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Bruce Ashfield
On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi wrote: > Hi Bruce & Preeti, > > > > I was trying to fix the same issue when I found this thread. > > This issue appears when multilib is enabled. > > > > When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file > into libvirt-python. > > W

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Chen Qi
Hi Bruce & Preeti, I was trying to fix the same issue when I found this thread. This issue appears when multilib is enabled. When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file into libvirt-python. When multilib is enabled, ${libdir} is /usr/lib64, and the file is not packa

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread preeti . sachan
No libvirt bbappend file in build and multiconfig is created to build with particular kernel version. In recipe https://git.yoctoproject.org/meta-virtualization/tree/recipes-extended/libvirt/libvirt_8.1.0.bb , FILES : ${ PN } - libvirtd is not including "/usr/lib/sysctl.d/60-qemu-postcopy-migra

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

2022-04-11 Thread Bruce Ashfield
There's definitely something different in your configuration, so that needs to be understood first. That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures. You have a multiconfig in play. Anything else ? What is your init

Re: [meta-virtualization][PATCH] cni: Add ;protocol=https for flannel_plugin SRC_URI

2022-04-11 Thread Bruce Ashfield
On Mon, Apr 11, 2022 at 6:45 AM Diego Sueiro wrote: > Also, fix the indentation for the SRC_URI variable assignment. > > It had a protocol specification already, I just managed to miss an 'o'. I've fixed that, and pushed the change. Annoying that github didn't break/stop my build immediately wit

[meta-virtualization][PATCH] cni: Add ;protocol=https for flannel_plugin SRC_URI

2022-04-11 Thread Diego Sueiro
Also, fix the indentation for the SRC_URI variable assignment. Signed-off-by: Diego Sueiro --- recipes-networking/cni/cni_git.bb | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/cni_git.bb index 42eed1b..9248

Re: [meta-virtualization] [PATCH 0/3] xen: Update recipes for xen and xen-tools

2022-04-11 Thread Bertrand Marquis
Hi Michal, > On 8 Apr 2022, at 09:44, Michal Orzel via lists.yoctoproject.org > wrote: > > Before the next Yocto release, Xen recipes need to be updated. > This patch series: > - updates 4.15 recipes > - introduces 4.16 recipes > - removes 4.14 recipes Thanks a lot for this. For the whole ser