Re: [uf-discuss] How's my hReview?

2006-09-01 Thread Andy Mabbett
In message [EMAIL PROTECTED], brian suda
[EMAIL PROTECTED] writes

  [of http://www.westmidlandbirdclub.com/reviews/WarksBirding2005.htm]


For the dtreviewed you have:
span class=dtreviewed title=200603March 2006/span

You probably need to switch that to an 'abbr' element so that the data
is being extracted from the title.

abbr class=dtreviewed title=200603March 2006/abbr

Done, thanks. I'm still not happy with using abbr in this way!
-- 
Andy Mabbett
Say NO! to compulsory ID Cards:  http://www.no2id.net/

Free Our Data:  http://www.freeourdata.org.uk
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss


Re: [uf-discuss] How's my hReview?

2006-08-30 Thread Andy Mabbett
In message
[EMAIL PROTECTED], Brian
Suda [EMAIL PROTECTED] writes

It is not a valid review yet, you are missing a few things.

[...]

B) create an outer div container. You have a class=photo which is
another hReview property - assuming you are actually intending that to
be part of the hReview, that needs to be nested inside the
class=item as well.

div class=hreview
 div class=item

I suppose

div class=hreview item

isn't allowed?

There is no RATING, which is OK that is optional, but IMHO that is
kinda the point of a review.

That's debatable. Have a look at a decent newspaper's book or theatre
reviews.

finnaly, the reviewer hCard is also incorrect:
p id=creditspan class=reviewer vcard fnAndy Mabbett/spanbr
span class=dtreviewed title=200603March 2006/span/p

you need to nest the class=fn inside the class=vcard
p id=credit class=reviewer vcardspan class=fnAndy Mabbett/spanbr
span class=dtreviewed title=200603March 2006/span/p

Yuk. How is the latter semantically better than the former? It's just
bloat.

i hope this helps.

Indeed, thank you.

 If you make those changes let us know and we can
take another pass at it and see if there are any other errors.

Done, see:

http://www.westmidlandbirdclub.com/reviews/WarksBirding2005.htm

Mind you, it occurs to me that, while our visitors might make use of
hCard and hCalendar items, to add contacts and events to their address
book or diary programmes, hReview is of less use, to them.
-- 
Andy Mabbett
Say NO! to compulsory ID Cards:  http://www.no2id.net/

Free Our Data:  http://www.freeourdata.org.uk
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss


Re: [uf-discuss] How's my hReview?

2006-08-30 Thread David Osolkowski

On 8/30/06, Andy Mabbett [EMAIL PROTECTED] wrote:

finnaly, the reviewer hCard is also incorrect:
p id=creditspan class=reviewer vcard fnAndy Mabbett/spanbr
span class=dtreviewed title=200603March 2006/span/p

you need to nest the class=fn inside the class=vcard
p id=credit class=reviewer vcardspan class=fnAndy Mabbett/spanbr
span class=dtreviewed title=200603March 2006/span/p

Yuk. How is the latter semantically better than the former? It's just
bloat.


Is your name really Andy Mabbett March 2006?

- David
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss


Re: [uf-discuss] How's my hReview?

2006-08-30 Thread Ryan King

On Aug 30, 2006, at 12:36 AM, Andy Mabbett wrote:

I suppose

div class=hreview item

isn't allowed?


http://microformats.org/wiki/hcard-faq#nesting-properties

-ryan
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss


[uf-discuss] How's my hReview?

2006-08-29 Thread Andy Mabbett

Here's my first stab at marking up one of my reviews with hReview:

http://www.westmidlandbirdclub.com/reviews/WarksBirding2005.htm

how does it look?

-- 
Andy Mabbett
Say NO! to compulsory ID Cards:  http://www.no2id.net/

Free Our Data:  http://www.freeourdata.org.uk
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss


Re: [uf-discuss] How's my hReview?

2006-08-29 Thread Brian Suda

It is not a valid review yet, you are missing a few things. The
following is a snippit of the site.

div class=hreview
h1West Midland Bird Club/h1
h2 id=content class=item'Warwickshire Birding 2005', by Steve Seal/h2
p class=centerDVDbrpound;5.99/p

div class=pic-rightimg class=photo
src=../images/biblio/WarksBirding2005.jpg width=250 height=455
alt= title=cover of Warwickshire Birding 2005/div

div class=description.../div
/div

You correctly have the class=hreview, nested inside that there is a
class=item (you'd be suprised how many reviews don't actualy have an
item being reviewed!)

The problem is that there is no class=fn nested in the class=item.
There are a few ways to fix this.
A) just add an FN inside the H2.
h2 id=content class=itemspan class=fn'Warwickshire Birding
2005', by Steve Seal/span/h2

B) create an outer div container. You have a class=photo which is
another hReview property - assuming you are actually intending that to
be part of the hReview, that needs to be nested inside the
class=item as well.

div class=hreview
 div class=item
   h1West Midland Bird Club/h1
   h2 id=content class=fn'Warwickshire Birding 2005', by Steve Seal/h2
   p class=centerDVDbrpound;5.99/p
   div class=pic-rightimg class=photo
src=../images/biblio/WarksBirding2005.jpg width=250 height=455
alt= title=cover of Warwickshire Birding 2005/div
 /div !-- ends item --
div class=description.../div
/div

There is no RATING, which is OK that is optional, but IMHO that is
kinda the point of a review.

finnaly, the reviewer hCard is also incorrect:
p id=creditspan class=reviewer vcard fnAndy Mabbett/spanbr
span class=dtreviewed title=200603March 2006/span/p

you need to nest the class=fn inside the class=vcard
p id=credit class=reviewer vcardspan class=fnAndy Mabbett/spanbr
span class=dtreviewed title=200603March 2006/span/p

i hope this helps. If you make those changes let us know and we can
take another pass at it and see if there are any other errors.

-brian

On 8/29/06, Andy Mabbett [EMAIL PROTECTED] wrote:


Here's my first stab at marking up one of my reviews with hReview:

http://www.westmidlandbirdclub.com/reviews/WarksBirding2005.htm

how does it look?

--
Andy Mabbett
Say NO! to compulsory ID Cards:  http://www.no2id.net/

Free Our Data:  http://www.freeourdata.org.uk
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss




--
brian suda
http://suda.co.uk
___
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss