On Thu, 3 May 2018 22:51:40 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> This way they are easier to find using standard rules. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > include/hw/s390x/ccw-device.h | 1 + > include/hw/s390x/ipl.h | 1 + > include/hw/s390x/s390-pci-bus.h | 1 + > include/hw/s390x/s390-pci-inst.h | 1 + > include/hw/s390x/s390-virtio-hcall.h | 1 + > include/hw/s390x/virtio-ccw.h | 1 + > 6 files changed, 6 insertions(+) > create mode 100644 include/hw/s390x/ccw-device.h > create mode 100644 include/hw/s390x/ipl.h > create mode 100644 include/hw/s390x/s390-pci-bus.h > create mode 100644 include/hw/s390x/s390-pci-inst.h > create mode 100644 include/hw/s390x/s390-virtio-hcall.h > create mode 100644 include/hw/s390x/virtio-ccw.h > > diff --git a/include/hw/s390x/ccw-device.h b/include/hw/s390x/ccw-device.h > new file mode 100644 > index 0000000..ab761b3 > --- /dev/null > +++ b/include/hw/s390x/ccw-device.h > @@ -0,0 +1 @@ > +#include_next "../hw/s390x/ccw-device.h" Eww. I find this very ugly. [Goes to find cover letter to figure out what this is all about. *Please*, cc: people on the cover letter so they can see immediately what this is trying to do!] After reading the cover letter, I still don't like this. If you want to move headers under include/ (which I don't have a problem with), please move them and do not introduce these weird constructs. [Also, that might need a MAINTAINERS update :)]