On Wed, Mar 23, 2022 at 01:44:29PM +0100, Maxime Devos wrote: > zimoun schreef op wo 23-03-2022 om 11:45 [+0100]: > > > On Wed, 12 Jan 2022 at 20:07, Efraim Flashner > > > <efr...@flashner.co.il> wrote: > > > > > > > > …the package redis is not a dependency of gitolite. Therefore, > > > > > the > > > > > question is: is our Gitolite package working with Redis? Even > > > > > using the > > > > > /usr/bin one? Idem for SVN. > > > > > > > > > > Otherwise, I am favor to remove the 2 “problematic” > > > > > references. WDYT? > > > > > > > > Or change it to search the $PATH for the binary, so it would just > > > > be > > > > 'redis-server' or 'svnserve' > > > > > > Is our Gitolite package working with Redis? If not, why try to > > > fix. ;-) > > > > What is the status of this old bug [1]? Is it actionable? If yes, > > what > > is the action? If no, let close it. :-) WDYT? > > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > into a '/gnu/store/...' (untested), so seems actionable to me. > Alternatively, as Efraim wrote, let it search the $PATH (that might be > useful if adding svnserve would increase the closure too much and it is > an optional dependency in practice?).
I spent some time looking at gitolite and the service. As I understand it, with the exception of svnserve, it searches $PATH for a number of different binaries, including git-annex. I believe that this would only work if git-annex (and potentially other packages) are installed globally. In addition, git (not git-minimal) and openssh are propagated inputs AND wrapped. I haven't tested to see if wrapping only is enough. I think the best choice is to: A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, like it does with the other helpers. B: Adjust the service so that it automatically creates a variant (or just a wrapped version) of the package which is wrapped with a list of additional packages so that they can be in gitolite's path. If I were deploying this to an arm device I wouldn't want it wrapped with git-annex since it doesn't build, but would definitely want it for an x86_64 machine. I suppose we should try to find someone who is using the gitolite service and see if they can be our test subject for wrapping the package with optional addons. -- Efraim Flashner <efr...@flashner.co.il> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
