Re: [Mingw-w64-public] [PATCH] Add some long double functions for ARM

Patch is ok. Thanks, Kai 2014-08-18 23:35 GMT+02:00 André Hentschel n...@dawncrow.de: Please review, i'll commit it, just need an OK. (these are the rather easy ones, it mostly looks like the RFC i sent some days ago)

[Mingw-w64-public] [PATCH 6/6] dwrite_1.h: Added new header file.

--- mingw-w64-headers/include/dwrite_1.h | 148 +++ 1 file changed, 148 insertions(+) create mode 100644 mingw-w64-headers/include/dwrite_1.h diff --git a/mingw-w64-headers/include/dwrite_1.h b/mingw-w64-headers/include/dwrite_1.h new file mode 100644 index

[Mingw-w64-public] [PATCH 3/6] sddl.h: Added some missing defines.

--- mingw-w64-headers/include/sddl.h | 8 1 file changed, 8 insertions(+) diff --git a/mingw-w64-headers/include/sddl.h b/mingw-w64-headers/include/sddl.h index 0bf19ba..c4ae5aa 100644 --- a/mingw-w64-headers/include/sddl.h +++ b/mingw-w64-headers/include/sddl.h @@ -23,6 +23,7 @@

[Mingw-w64-public] [PATCH 2/6] dwrite.h: Don't duplicate parent interface methods for C++ because it breaks templated QueryInterface implementation and fixed IDWriteFontFileEnumerator declaration.

It came out that we need to not duplicate QueryInterface in child interface declarations, because they shadow its templated inline variant. --- mingw-w64-headers/include/dwrite.h | 59 -- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git

[Mingw-w64-public] [PATCH 5/6] wlanapi.h: Added some missing defines.

--- mingw-w64-headers/include/wlanapi.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/mingw-w64-headers/include/wlanapi.h b/mingw-w64-headers/include/wlanapi.h index fa0e506..1f7dc49 100644 --- a/mingw-w64-headers/include/wlanapi.h +++ b/mingw-w64-headers/include/wlanapi.h @@

[Mingw-w64-public] [PATCH 4/6] l2cmn.h: Added new header file.

--- mingw-w64-headers/include/l2cmn.h | 20 1 file changed, 20 insertions(+) create mode 100644 mingw-w64-headers/include/l2cmn.h diff --git a/mingw-w64-headers/include/l2cmn.h b/mingw-w64-headers/include/l2cmn.h new file mode 100644 index 000..8157df9 --- /dev/null

[Mingw-w64-public] [PATCH 1/6] string_s.h/wchar_s.h: Added wcsnlen_s implementation.

--- mingw-w64-headers/crt/sec_api/string_s.h | 3 +++ mingw-w64-headers/crt/sec_api/wchar_s.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/mingw-w64-headers/crt/sec_api/string_s.h b/mingw-w64-headers/crt/sec_api/string_s.h index 34d1c99..4b10820 100644 ---

[Mingw-w64-public] [PATCH] tsattrs.h: Added new header file.

--- mingw-w64-headers/include/tsattrs.h | 100 1 file changed, 100 insertions(+) create mode 100644 mingw-w64-headers/include/tsattrs.h diff --git a/mingw-w64-headers/include/tsattrs.h b/mingw-w64-headers/include/tsattrs.h new file mode 100644 index

Re: [Mingw-w64-public] [PATCH 3/6] sddl.h: Added some missing defines.

Patch is ok. Thanks, Kai 2014-08-19 14:04 GMT+02:00 Jacek Caban ja...@codeweavers.com: --- mingw-w64-headers/include/sddl.h | 8 1 file changed, 8 insertions(+) --

Re: [Mingw-w64-public] [PATCH 4/6] l2cmn.h: Added new header file.

Patch is ok. Thanks, Kai 2014-08-19 14:04 GMT+02:00 Jacek Caban ja...@codeweavers.com: --- mingw-w64-headers/include/l2cmn.h | 20 1 file changed, 20 insertions(+) create mode 100644 mingw-w64-headers/include/l2cmn.h

Re: [Mingw-w64-public] [PATCH 1/6] string_s.h/wchar_s.h: Added wcsnlen_s implementation.

Hmm, this patch looks to me not 100% ok. Making functions static inline seems to be not the proper thing to do here AFAICS. This will lead to warning for cases those functions aren't used. So I would think that attribute unused is missing here. Additionally the 'inline' looks to me bogus.

Re: [Mingw-w64-public] [PATCH 5/6] wlanapi.h: Added some missing defines.

Thanks, please apply. Kai 2014-08-19 14:04 GMT+02:00 Jacek Caban ja...@codeweavers.com: --- mingw-w64-headers/include/wlanapi.h | 11 +++ 1 file changed, 11 insertions(+) --

Re: [Mingw-w64-public] [PATCH 6/6] dwrite_1.h: Added new header file.

Patch is ok. Please apply. Thanks, Kai 2014-08-19 14:05 GMT+02:00 Jacek Caban ja...@codeweavers.com: --- mingw-w64-headers/include/dwrite_1.h | 148 +++ 1 file changed, 148 insertions(+) create mode 100644 mingw-w64-headers/include/dwrite_1.h

Re: [Mingw-w64-public] [PATCH] tsattrs.h: Added new header file.

Thanks, please apply. Kai 2014-08-19 14:31 GMT+02:00 Jacek Caban ja...@codeweavers.com: --- mingw-w64-headers/include/tsattrs.h | 100 1 file changed, 100 insertions(+) create mode 100644 mingw-w64-headers/include/tsattrs.h

Re: [Mingw-w64-public] [PATCH 2/6] dwrite.h: Don't duplicate parent interface methods for C++ because it breaks templated QueryInterface implementation and fixed IDWriteFontFileEnumerator declaration.

Yes, wasn't at that file ... patch is ok. Please apply. Thanks, Kai 2014-08-19 14:04 GMT+02:00 Jacek Caban ja...@codeweavers.com: It came out that we need to not duplicate QueryInterface in child interface declarations, because they shadow its templated inline variant. ---

Re: [Mingw-w64-public] [PATCH 1/6] string_s.h/wchar_s.h: Added wcsnlen_s implementation.

OK, I pushed it with extern inline declaration. Thanks for reviews, Jacek On 08/19/14 15:38, Kai Tietz wrote: Hmm, this patch looks to me not 100% ok. Making functions static inline seems to be not the proper thing to do here AFAICS. This will lead to warning for cases those functions

Re: [Mingw-w64-public] Windows Phone

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 17.08.2014 um 16:10 schrieb Ruben De Smet: Hi mingw-w64 list and especially André Hentschel, (CC: a teammember of mine) I decided to mail this directly to mr Hentschel too, as I was told you were the one working on these kind of problems.

Re: [Mingw-w64-public] Slow pseudo-relocations

No, sorry, I don't have the setup to build mingw. Not likely that I will have time to do it any time soon either. I meant this as a bug report. I hope the problem has been investigated sufficiently for mingw devs to act on it. Vadim On Mon, Aug 18, 2014 at 9:34 PM, dw