Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-18 Thread dw
For the parts that are "working around a compiler bug": - Does it make sense to list the bug number in the comment? - If the bug has been fixed, what about using __GNUC__ and __GNUC_MINOR__ to limit the code? dw On 9/18/2014 3:23 PM, André Hentschel wrote: Please review, i'll commit it, just

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-18 Thread Kai Tietz
Looks ok. Please apply Thanks, Kai -- Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk ___ Mingw

[Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-18 Thread André Hentschel
Please review, i'll commit it, just need an OK. v2 adds llrint functions, removes hidden attribute diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 7245956..9731aa9 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -233,7 +233,7 @@ src_libmingwe

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM

2014-09-18 Thread Kai Tietz
Patch looks ok, but a the use of '__attribute__((visibility ("hidden")))'. Actually the visibility stuff isn't supported by pe-coff, so is it really necessary here? Kai -- Slashdot TV. Video for Nerds. Stuff that Matte

[Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM

2014-09-18 Thread André Hentschel
Please review, i'll commit it, just need an OK. diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 7245956..9731aa9 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -233,7 +233,7 @@ src_libmingwex=\ math/fabs.c math/fabsf.c mat