On 9/24/2016 7:23 PM, David Wohlferd wrote: > On 9/24/2016 4:55 AM, NightStrike wrote: >> On Sep 23, 2016 8:08 PM, "David Wohlferd" <d...@limegreensocks.com> wrote: >>> Ok. With that change in place, I have run >>> autoreconf -fiv >>> >>> in the root directory of mingw-w64. That regenerated a bunch of files. >>> >>> To test this, I have run configure, make and make install for each of >>> x86, x64 and arm. These all seem to build correctly. >>> >>> Nightstrike: Running "make distcheck" now runs a bit further than >>> before. However: >>> >>> - For x86, all the initial checks complete, but when it tries doing its >>> own VPATH build, it fails because of include path issues (it tries to >>> build mingw-w64-crt in isolation from mingw-w64-headers). But since the >>> normal build succeeds, I don't believe this is a problem. >>> - For x64, it fails because pseh is "missing." Obviously it is missing >>> because it's not supported on x64. I'm not sure why distcheck doesn't >>> skip it. >>> - For arm, it fails because libmangle is missing. Not sure how to get >>> it to skip this either. >> Use AM_DISTCHECK_CONFIGURE_FLAGS to set configure options specifically used >> for the distcheck target. For instance, maybe --disable-pseh (if that's a >> thing, I don't know) > Actually, "disabled" is the default. If you want it to build, you must > explicitly enable it (--with-libraries=pseh or --with-libraries=all). > It's not immediately clear to me why distcheck thinks it should check > parts that are disabled. > > Is this important enough to track down? Or can this patch be approved > without it?
I was getting ready to nudge this thread to get it approved for push, when I noticed something. While running "autoreconf -fiv" does walk down subdirectories, it doesn't walk ALL our subdirectories. So I tried again. This time I explicitly deleted all the build-aux directories, as well as all makefile.in, configure. and aclocal.m4 to force autoreconf to really regenerate them. After running "autoreconf -fiv", I looked to see which directories didn't get these files re-generated. I then changed to those directories and run "autoreconf -fiv" from there. THAT got everything. Looking at the new patch, I noticed something else. In some cases, the config.guess that is being generated is OLDER than the one that is checked in. After analysis, it appears that someone (sezero?) has checked in a beta version of this file in a few places. Was this done on purpose to resolve a problem? It seems like we should either stay with "released" versions, or use the same version everywhere. Opinions? I have started re-testing, but if someone wants to shed some light on this config.guess thing, I can make any needed changes before posting this (increasingly large) patch. dw ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
