Re: [Mingw-w64-public] [PATCH 2/2] ucrt: Move _snwprintf and fwprintf to separate translation units

2018-10-18 Thread Tom Ritter
On Thu, 18 Oct 2018 at 12:20, Jacek Caban wrote: > > Hi Martin, > > On 10/17/2018 10:08 PM, Martin Storsjö wrote: > > These are normally only referenced by objects in libmingwex. However, > > ntdll also contains the function _snwprintf. Depending on the order that > > object files and libraries

Re: [Mingw-w64-public] [PATCH] headers: Update the threadlocinfo struct for ucrt

2018-10-18 Thread Jacek Caban
On 10/18/2018 07:51 PM, Martin Storsjö wrote: > Signed-off-by: Martin Storsjö > --- > This fixes a testcase like this: > > #include > #include > #include > > int main(int argc, char const *argv[]) > { > _locale_t loc = _create_locale(LC_ALL, "C"); > int ret

[Mingw-w64-public] [mingw-w64-public][patch] fix redefinition of _InterlockedAdd64 from wdm.h

2018-10-18 Thread Olivier Hainque
Hello, (resending after subscribing) Using the a very recent mingw-w64 trunk together with a recent GCC toolchain configured for x86_64-pc-mingw32, compiling the following source: #include "wdm.h" int main(){} with gcc -c main.c -I$(dirname $(which gcc))/../x86_64-pc-mingw32/include/ddk

[Mingw-w64-public] [PATCH] headers: Update the threadlocinfo struct for ucrt

2018-10-18 Thread Martin Storsjö
Signed-off-by: Martin Storsjö --- This fixes a testcase like this: #include #include #include int main(int argc, char const *argv[]) { _locale_t loc = _create_locale(LC_ALL, "C"); int ret = _isdigit_l('3', loc); printf ("%d\n", ret); return

Re: [Mingw-w64-public] [PATCH] headers: Update the threadlocinfo struct for ucrt

2018-10-18 Thread Jacek Caban
Hi Martin, On 10/18/2018 09:58 AM, Martin Storsjö wrote: > This keeps the old names for the few struct fields that are left, > to avoid having to change code in ctype.h which references it. > > Alternatively, we could switch consistently to the new names in ctype.h, > and add "#define

Re: [Mingw-w64-public] [PATCH 2/2] ucrt: Move _snwprintf and fwprintf to separate translation units

2018-10-18 Thread Jacek Caban
Hi Martin, On 10/17/2018 10:08 PM, Martin Storsjö wrote: > These are normally only referenced by objects in libmingwex. However, > ntdll also contains the function _snwprintf. Depending on the order that > object files and libraries are linked, this could lead to multiple > definition errors. By

Re: [Mingw-w64-public] [PATCH 1/2] ucrt: Remove a leftover comment

2018-10-18 Thread Jacek Caban
On 10/17/2018 10:08 PM, Martin Storsjö wrote: > We no longer use dummy FILE pointers in this wrapper. > > Signed-off-by: Martin Storsjö > --- > mingw-w64-crt/crt/ucrtbase_compat.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c >

[Mingw-w64-public] [PATCH] headers: Update the threadlocinfo struct for ucrt

2018-10-18 Thread Martin Storsjö
This keeps the old names for the few struct fields that are left, to avoid having to change code in ctype.h which references it. Alternatively, we could switch consistently to the new names in ctype.h, and add "#define _locale_mb_cur_max mb_cur_max" for the non-ucrt case? That's a much larger and