Re: [Mingw-w64-public] [PATCH] Always define __USE_MINGW_ANSI_STDIO as 0 or 1 in _mingw.h

2018-11-02 Thread JonY via Mingw-w64-public
On 11/02/2018 08:28 PM, Mateusz wrote: > W dniu 01.11.2018 o 14:16, JonY pisze: >> On 11/01/2018 01:52 AM, Mateusz wrote: >>> During discussion about inttypes I realized that we check (in header files) >>> if >>> __USE_MINGW_ANSI_STDIO is active in non consistent way: >>> #if

Re: [Mingw-w64-public] [PATCH] headers: Update the threadlocinfo struct for ucrt

2018-11-02 Thread Martin Storsjö
On Fri, 2 Nov 2018, Mateusz wrote: W dniu 18.10.2018 o 19:51, Martin Storsjö pisze: Signed-off-by: Martin Storsjö --- This fixes a testcase like this: #include #include #include int main(int argc, char const *argv[]) { _locale_t loc = _create_locale(LC_ALL,

Re: [Mingw-w64-public] [PATCH] headers: Update the threadlocinfo struct for ucrt

2018-11-02 Thread Mateusz
W dniu 18.10.2018 o 19:51, Martin Storsjö pisze: > Signed-off-by: Martin Storsjö > --- > This fixes a testcase like this: > > #include > #include > #include > > int main(int argc, char const *argv[]) > { > _locale_t loc = _create_locale(LC_ALL, "C"); > int

Re: [Mingw-w64-public] [PATCH] Always define __USE_MINGW_ANSI_STDIO as 0 or 1 in _mingw.h

2018-11-02 Thread Mateusz
W dniu 01.11.2018 o 14:16, JonY pisze: > On 11/01/2018 01:52 AM, Mateusz wrote: >> During discussion about inttypes I realized that we check (in header files) >> if >> __USE_MINGW_ANSI_STDIO is active in non consistent way: >> #if defined(__USE_MINGW_ANSI_STDIO) && ((__USE_MINGW_ANSI_STDIO + 0)

Re: [Mingw-w64-public] [PATCH] Always define __USE_MINGW_ANSI_STDIO as 0 or 1 in _mingw.h

2018-11-02 Thread Earnie via Mingw-w64-public
On 11/2/2018 11:10 AM, Liu Hao wrote: > 在 2018/11/2 22:41, Earnie via Mingw-w64-public 写道: >> Maybe add after the "before including any system headers." something >> like "A value other than 1 causes undefined behavior." >> > > This is overpedantic. There is no legitimate reason for introduction

Re: [Mingw-w64-public] [PATCH] Always define __USE_MINGW_ANSI_STDIO as 0 or 1 in _mingw.h

2018-11-02 Thread Liu Hao
在 2018/11/2 22:41, Earnie via Mingw-w64-public 写道: > Maybe add after the "before including any system headers." something > like "A value other than 1 causes undefined behavior." > This is overpedantic. There is no legitimate reason for introduction of further undefined behavior due to possible

Re: [Mingw-w64-public] [PATCH] Always define __USE_MINGW_ANSI_STDIO as 0 or 1 in _mingw.h

2018-11-02 Thread Earnie via Mingw-w64-public
On 11/2/2018 1:38 AM, Liu Hao wrote: > 在 2018/11/1 22:53, Ozkan Sezer 写道: >>> Are there any existent projects where `__USE_MINGW_ANSI_STDIO` is >>> defined as something other than `0` or `1`, if it is defined at all, >>> including empty? >> >> That would be a bug, and I'd recommend applying this