Re: [Mingw-w64-public] [PATCH] msvcr80: Provide _set_invalid_parameter_handler compat implementation in libmsvcr80.a.

2018-11-27 Thread Liu Hao
在 2018/11/28 0:57, Jacek Caban 写道: > Signed-off-by: Jacek Caban > --- >  mingw-w64-crt/Makefile.am | 8 ++-- >  1 file changed, 6 insertions(+), 2 deletions(-) > > What is the rationale for this? I can see `_set_invalid_parameter_handler` exported from both x86 and x64 MSVCR80.DLL. --

Re: [Mingw-w64-public] [PATCH] msvcr80: Provide _set_invalid_parameter_handler compat implementation in libmsvcr80.a.

2018-11-27 Thread Jacek Caban
Hi Mateusz, On 27/11/2018 22:32, Mateusz wrote: W dniu 27.11.2018 o 20:28, Mateusz pisze: W dniu 27.11.2018 o 17:57, Jacek Caban pisze: Signed-off-by: Jacek Caban ---  mingw-w64-crt/Makefile.am | 8 ++--  1 file changed, 6 insertions(+), 2 deletions(-) Thanks! I've added

Re: [Mingw-w64-public] [PATCH] msvcr80: Provide _set_invalid_parameter_handler compat implementation in libmsvcr80.a.

2018-11-27 Thread Martin Storsjö
On Tue, 27 Nov 2018, Mateusz wrote: W dniu 27.11.2018 o 20:28, Mateusz pisze: W dniu 27.11.2018 o 17:57, Jacek Caban pisze: Signed-off-by: Jacek Caban ---  mingw-w64-crt/Makefile.am | 8 ++--  1 file changed, 6 insertions(+), 2 deletions(-) Thanks! I've added stdio/fseeki64.c and

Re: [Mingw-w64-public] [PATCH] msvcr80: Provide _set_invalid_parameter_handler compat implementation in libmsvcr80.a.

2018-11-27 Thread Mateusz
W dniu 27.11.2018 o 20:28, Mateusz pisze: > W dniu 27.11.2018 o 17:57, Jacek Caban pisze: >> Signed-off-by: Jacek Caban >> --- >>  mingw-w64-crt/Makefile.am | 8 ++-- >>  1 file changed, 6 insertions(+), 2 deletions(-) > > Thanks! I've added stdio/fseeki64.c and stdio/mingw_lock.c and was

Re: [Mingw-w64-public] [PATCH] msvcr80: Provide _set_invalid_parameter_handler compat implementation in libmsvcr80.a.

2018-11-27 Thread Mateusz
W dniu 27.11.2018 o 17:57, Jacek Caban pisze: > Signed-off-by: Jacek Caban > --- >  mingw-w64-crt/Makefile.am | 8 ++-- >  1 file changed, 6 insertions(+), 2 deletions(-) Thanks! I've added stdio/fseeki64.c and stdio/mingw_lock.c and was able to build x265. Bad news is that x265 is not

[Mingw-w64-public] [PATCH] msvcr80: Provide _set_invalid_parameter_handler compat implementation in libmsvcr80.a.

2018-11-27 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index f8b0623c..9ab59f66 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -253,8

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Jacek Caban
On 11/27/18 1:05 AM, Mateusz wrote: In all documentations about fseeko/fseek that I found it is clear stated that fseeko works exactly like fseek but it is better and preferable (because of _off_t instead of long). mingw implementation of fseeko64 looks too much simplified (it is possible

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Jacek Caban
On 11/27/18 2:41 PM, Martin Storsjö wrote: On Tue, 27 Nov 2018, Mateusz wrote: OK, I've attached minimal version -- inline helpers kept for ucrt, only _fseeki64 and _ftelli64 moved, I also removed 'DATA' guards for multiple definition in libmsvcr90 and 100. This version looks fine to me.

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Martin Storsjö
On Tue, 27 Nov 2018, Mateusz wrote: W dniu 26.11.2018 o 23:30, Jacek Caban pisze: On 11/26/18 10:31 PM, Martin Storsjö wrote: On Mon, 26 Nov 2018, Jacek Caban wrote: Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Mateusz
W dniu 26.11.2018 o 23:30, Jacek Caban pisze: > On 11/26/18 10:31 PM, Martin Storsjö wrote: >> On Mon, 26 Nov 2018, Jacek Caban wrote: >> >>> Hi Mateusz, >>> >>> >>> The patch looks mostly good to me. >>> >>> >>> On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++