Re: [Mingw-w64-public] [PATCH] Add __mingw_access() that works the same for all msvcr*/ucrt libs

2019-01-07 Thread Mateusz
W dniu 08.01.2019 o 04:33, Liu Hao pisze: > 在 2019/1/8 8:32, Mateusz 写道: >> W dniu 08.01.2019 o 00:49, JonY pisze: >>> On 1/7/19 5:50 PM, Mateusz wrote: Old versions of MSVCRT _access() just ignored X_OK, while the version shipped with Vista, returns an error code. _access() from

Re: [Mingw-w64-public] [PATCH] Add __mingw_access() that works the same for all msvcr*/ucrt libs

2019-01-07 Thread Liu Hao
在 2019/1/8 8:32, Mateusz 写道: > W dniu 08.01.2019 o 00:49, JonY pisze: >> On 1/7/19 5:50 PM, Mateusz wrote: >>> Old versions of MSVCRT _access() just ignored X_OK, while the >>> version shipped with Vista, returns an error code. >>> _access() from msvcr110/120 returns an error code for nul file.

Re: [Mingw-w64-public] [PATCH] Add __mingw_access() that works the same for all msvcr*/ucrt libs

2019-01-07 Thread Mateusz
W dniu 08.01.2019 o 00:49, JonY pisze: > On 1/7/19 5:50 PM, Mateusz wrote: >> Old versions of MSVCRT _access() just ignored X_OK, while the >> version shipped with Vista, returns an error code. >> _access() from msvcr110/120 returns an error code for nul file. >> >> Signed-off-by: Mateusz Brzostek

Re: [Mingw-w64-public] [PATCH] Add __mingw_access() that works the same for all msvcr*/ucrt libs

2019-01-07 Thread JonY via Mingw-w64-public
On 1/7/19 5:50 PM, Mateusz wrote: > Old versions of MSVCRT _access() just ignored X_OK, while the > version shipped with Vista, returns an error code. > _access() from msvcr110/120 returns an error code for nul file. > > Signed-off-by: Mateusz Brzostek Patch looks OK. signature.asc

[Mingw-w64-public] [PATCH] Add __mingw_access() that works the same for all msvcr*/ucrt libs

2019-01-07 Thread Mateusz
Old versions of MSVCRT _access() just ignored X_OK, while the version shipped with Vista, returns an error code. _access() from msvcr110/120 returns an error code for nul file. Signed-off-by: Mateusz Brzostek --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/misc/mingw-access.c | 53

Re: [Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-07 Thread Liu Hao
在 2019/1/7 5:06, Mateusz 写道: > W dniu 06.01.2019 o 16:17, Liu Hao pisze: >> 在 2019/1/6 9:19, Mateusz 写道: >>> W dniu 05.01.2019 o 20:59, Johannes Pfau pisze: >>> Maybe it would make sense to add this in crt/io.h? There's already a >>> __USE_MINGW_ACCESS guarded __mingw_access wrapper function