Re: [Mingw-w64-public] [PATCH 7/7] crt: Move find, stat and time aliases to def-include/msvcrt-common.def.in

2024-04-30 Thread Pali Rohár
On Tuesday 30 April 2024 12:01:53 Martin Storsjö wrote: > On Sat, 27 Apr 2024, Pali Rohár wrote: > > > Add 4 new macros FIXED_SIZE_SYMBOLS, NO_I64_FIXED_SIZE, > > NO_FIXED_SIZE_64_ALIAS and NO_TIME_ALIAS to distinguish > > between different crt versions. > > > > This change adds new symbol

Re: [Mingw-w64-public] [PATCH 3/7] crt: msvcr120 and UCRT: Fix X64 _(w)findfirst and _(w)findnext symbol aliases

2024-04-30 Thread Pali Rohár
On Tuesday 30 April 2024 11:57:02 Martin Storsjö wrote: > On Sat, 27 Apr 2024, Pali Rohár wrote: > > > These symbols on X64 should resolve to _findfirst64i32/_findnext64i32 > > functions, like in other CRT libraries and header files. > > It could be worth mentioning in the commit message, that

Re: [Mingw-w64-public] [PATCH 6/7] crt: UCRT: Change I386 time functions without suffix to use 32-bit time_t

2024-04-30 Thread Pali Rohár
On Tuesday 30 April 2024 11:54:48 Martin Storsjö wrote: > On Sat, 27 Apr 2024, Pali Rohár wrote: > > > CRT header files ensures that time symbols without 32/64 suffixes are not > > emitted. And linker always sees time symbols with explicit 32 or 64 suffix > > name. > > > > When CRT header files

Re: [Mingw-w64-public] [PATCH 7/7] crt: Move find, stat and time aliases to def-include/msvcrt-common.def.in

2024-04-30 Thread Martin Storsjö
On Sat, 27 Apr 2024, Pali Rohár wrote: Add 4 new macros FIXED_SIZE_SYMBOLS, NO_I64_FIXED_SIZE, NO_FIXED_SIZE_64_ALIAS and NO_TIME_ALIAS to distinguish between different crt versions. This change adds new symbol aliases which were missing. There is no symbol change or removal. For reference

Re: [Mingw-w64-public] [PATCH 3/7] crt: msvcr120 and UCRT: Fix X64 _(w)findfirst and _(w)findnext symbol aliases

2024-04-30 Thread Martin Storsjö
On Sat, 27 Apr 2024, Pali Rohár wrote: These symbols on X64 should resolve to _findfirst64i32/_findnext64i32 functions, like in other CRT libraries and header files. It could be worth mentioning in the commit message, that the 32 bit versions of these aliases or redirects, are intentionally

Re: [Mingw-w64-public] [PATCH 6/7] crt: UCRT: Change I386 time functions without suffix to use 32-bit time_t

2024-04-30 Thread Martin Storsjö
On Sat, 27 Apr 2024, Pali Rohár wrote: CRT header files ensures that time symbols without 32/64 suffixes are not emitted. And linker always sees time symbols with explicit 32 or 64 suffix name. When CRT header files are not included then 32-bit MSVC compiler + linker treats symbols without