Re: [Mingw-w64-public] [PATCH] Add more trigonometric long double functions for ARM

2014-08-27 Thread André Hentschel
Am 27.08.2014 um 22:40 schrieb Kai Tietz: > Hi Andre, > > I have just one comment to patch. > > +long double tanl(long double x) > +{ > +#if defined(__arm__) || defined(_ARM_) > +return sin(x) / cos(x); > > Shouldn't that be instead return sinl (x) / cosl (x); ? My build hasn't complained a

Re: [Mingw-w64-public] [PATCH] Add more trigonometric long double functions for ARM

2014-08-27 Thread Kai Tietz
Hi Andre, I have just one comment to patch. +long double tanl(long double x) +{ +#if defined(__arm__) || defined(_ARM_) +return sin(x) / cos(x); Shouldn't that be instead return sinl (x) / cosl (x); ? Otherwise patch is ok. Thanks, Kai -

[Mingw-w64-public] [PATCH] Add more trigonometric long double functions for ARM

2014-08-27 Thread André Hentschel
Please review, i'll commit it, just need an OK. diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 7a945e9..c4aec7d 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -226,10 +226,8 @@ src_libmingwex=\ math/internal_logl.S math/log10l.S \ ma