Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Martell Malone
Arg I changed the old patch with including errno.h Can someone delete the previous email from the thread Sorry On Wed, Nov 12, 2014 at 2:38 PM, Martell Malone martellmal...@gmail.com wrote: Caching stopped me from including errno.h On Wed, Nov 12, 2014 at 2:34 PM, Martell Malone

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Dongsheng Song
Pushed with delete mysterious U+200B characters. Unicode Character 'ZERO WIDTH SPACE' (U+200B) +tmp = localtime(_Time); +if (tmp != NULL) +memcpy(_Tm, tmp, sizeof(struct tm); +return tmp;200b200b +200b}200b + On Wed, Nov 12, 2014 at 11:59 PM, Kai Tietz

[Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Martell Malone
Comments Suggestions and changes Welcome. Kind Regards Martell 0001-Remove-the-Macros-of-the-time_r-functions-and-replac.patch Description: Binary data -- Comprehensive Server Monitoring with Site24x7. Monitor 10

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Ray Donnelly
On Tue, Nov 11, 2014 at 2:02 PM, Dongsheng Song dongsheng.s...@gmail.com wrote: I think you need add 1 line like this: TODO: real thread safe implementation. Why? msvcrt is thread safe already. On Tue, Nov 11, 2014 at 8:15 PM, Martell Malone martellmal...@gmail.com wrote: Comments

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Dongsheng Song
On Wed, Nov 12, 2014 at 12:24 AM, Ray Donnelly mingw.andr...@gmail.com wrote: On Tue, Nov 11, 2014 at 2:02 PM, Dongsheng Song dongsheng.s...@gmail.com wrote: I think you need add 1 line like this: TODO: real thread safe implementation. Why? msvcrt is thread safe already. MSDN not said