Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread JonY via Mingw-w64-public
On 5/16/21 10:52 AM, Liu Hao wrote: 在 2021-05-16 18:49, JonY via Mingw-w64-public 写道: Updated. Thanks. LGTM. Thanks for the review, pushed to master. OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread Liu Hao
在 2021-05-16 18:49, JonY via Mingw-w64-public 写道: Updated. Thanks. LGTM. -- Best regards, Liu Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread JonY via Mingw-w64-public
On 5/16/21 9:36 AM, Liu Hao wrote: 在 2021-05-16 17:21, JonY via Mingw-w64-public 写道: diff --git a/mingw-w64-headers/crt/math.h b/mingw-w64-headers/crt/math.h index 3754dc64..b9277bd0 100644 --- a/mingw-w64-headers/crt/math.h +++ b/mingw-w64-headers/crt/math.h @@ -143,8 +143,12 @@ extern "C" {  

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread Liu Hao
在 2021-05-16 17:21, JonY via Mingw-w64-public 写道: diff --git a/mingw-w64-headers/crt/math.h b/mingw-w64-headers/crt/math.h index 3754dc64..b9277bd0 100644 --- a/mingw-w64-headers/crt/math.h +++ b/mingw-w64-headers/crt/math.h @@ -143,8 +143,12 @@ extern "C" { #endif #ifndef _HUGE +#ifdef

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread JonY via Mingw-w64-public
On 5/16/21 8:25 AM, Liu Hao wrote: 在 2021-05-15 23:23, JonY via Mingw-w64-public 写道: The prototype declares it as a non-const, will it be a problem? In addition, it looks like UCRT doesn't declare it as an imported symbol any more. It's plain `extern double const _HUGE;` now. Patch

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread Liu Hao
在 2021-05-15 23:23, JonY via Mingw-w64-public 写道: The prototype declares it as a non-const, will it be a problem? Yes, I think it should be `const double` instead of plain `double`. -- Best regards, Liu Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-16 Thread Liu Hao
在 2021-05-15 23:23, JonY via Mingw-w64-public 写道: The prototype declares it as a non-const, will it be a problem? In addition, it looks like UCRT doesn't declare it as an imported symbol any more. It's plain `extern double const _HUGE;` now. -- Best regards, Liu Hao OpenPGP_signature

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-15 Thread JonY via Mingw-w64-public
On 5/15/21 2:03 PM, Liu Hao wrote: 在 2021-05-15 21:01, JonY via Mingw-w64-public 写道: On 5/15/21 12:58 PM, JonY wrote: Hi, Attached patch OK? Simplified patch. Is it possible to declare it as `const double`? It need not be mutable. The prototype declares it as a non-const, will it be

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-15 Thread Liu Hao
在 2021-05-15 21:01, JonY via Mingw-w64-public 写道: On 5/15/21 12:58 PM, JonY wrote: Hi, Attached patch OK? Simplified patch. Is it possible to declare it as `const double`? It need not be mutable. -- Best regards, Liu Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-15 Thread JonY via Mingw-w64-public
On 5/15/21 12:58 PM, JonY wrote: Hi, Attached patch OK? Simplified patch. >From ff422cf04d8f9e105c68ac2ffdd25da4add8f8fb Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Sat, 15 May 2021 12:56:51 + Subject: [PATCH] crt: _HUGE for UCRT Signed-off-by: Jonathan Yong

[Mingw-w64-public] [PATCH] _HUGE for ucrt

2021-05-15 Thread JonY via Mingw-w64-public
Hi, Attached patch OK? From c9bef0201c412ee20531fdd777978644e0eef76c Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Sat, 15 May 2021 12:56:51 + Subject: [PATCH] crt: _HUGE for UCRT Signed-off-by: Jonathan Yong <10wa...@gmail.com> --- mingw-w64-crt/Makefile.am | 1 +