Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

> On Aug 31, 2018, at 14:05, Mateusz wrote: > > W dniu 31.08.2018 o 12:17, Martin Storsjö pisze: >> On Aug 31, 2018, at 12:51, Mateusz wrote: >>> >>> W dniu 30.08.2018 o 09:53, Martin Storsjö pisze: > On Aug 29, 2018, at 18:44, Martell Malone wrote: > > LGTM. Pushed

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

W dniu 31.08.2018 o 12:17, Martin Storsjö pisze: > On Aug 31, 2018, at 12:51, Mateusz wrote: >> >> W dniu 30.08.2018 o 09:53, Martin Storsjö pisze: On Aug 29, 2018, at 18:44, Martell Malone wrote: LGTM. >>> >>> Pushed this version. >>> >>> // Martin >> >> It's not working for me

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

On Aug 31, 2018, at 12:51, Mateusz wrote: > > W dniu 30.08.2018 o 09:53, Martin Storsjö pisze: >>> On Aug 29, 2018, at 18:44, Martell Malone wrote: >>> >>> LGTM. >> >> Pushed this version. >> >> // Martin > > It's not working for me (when I build gcc on ubuntu). > Could we revert this

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

W dniu 30.08.2018 o 09:53, Martin Storsjö pisze: >> On Aug 29, 2018, at 18:44, Martell Malone wrote: >> >> LGTM. > > Pushed this version. > > // Martin It's not working for me (when I build gcc on ubuntu). Could we revert this patch? Mateusz

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

> On Aug 29, 2018, at 18:44, Martell Malone wrote: > > LGTM. Pushed this version. // Martin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org!

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

LGTM. Thanks for this. When I originally used ifdef __clang__ we knew it was a hack because we should be checking the linker and not the compiler but at the time clang didn’t work well as a drop in replacement for gcc so it was used to specify one toolchain combination or another. Glad to see

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

> On Aug 28, 2018, at 05:58, Liu Hao wrote: > > 在 2018/8/28 2:50, Martin Storsjö 写道: >> Using the __clang__ ifdef isn't right; one could be using clang for >> compiling the mingw-w64 crt for use with binutils ld, which requires >> a slightly different setup of __CTOR_LIST__. >> >> Also, to ease

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

在 2018/8/28 2:50, Martin Storsjö 写道: > Using the __clang__ ifdef isn't right; one could be using clang for > compiling the mingw-w64 crt for use with binutils ld, which requires > a slightly different setup of __CTOR_LIST__. > > Also, to ease interoperability between binutils ld and lld, lld

[Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

Using the __clang__ ifdef isn't right; one could be using clang for compiling the mingw-w64 crt for use with binutils ld, which requires a slightly different setup of __CTOR_LIST__. Also, to ease interoperability between binutils ld and lld, lld could potentially start providing the __CTOR_LIST__