On Fri, Oct 09, 2020 at 12:13:58AM +0800, Liu Hao wrote:
> 在 2020/10/8 3:05, Andrew Eikum 写道:
> > Signed-off-by: Andrew Eikum
> > ---
> >
>
> Next time, please do not commit 'Makefile.in' with other files. It's meant to
> be auto-generated and can't be reviewed.
>
> The other parts look good
在 2020/10/8 3:05, Andrew Eikum 写道:
> Signed-off-by: Andrew Eikum
> ---
>
Next time, please do not commit 'Makefile.in' with other files. It's meant to
be auto-generated and can't be reviewed.
The other parts look good to me. I stripped this patch and pushed it. Thanks
for the work.
--
Signed-off-by: Andrew Eikum
---
For a usage example, see OpenXR:
https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/release-1.0.12/src/common/filesystem_utils.cpp#L140
https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/release-1.0.12/src/loader/CMakeLists.txt#L186
Thank you,
