Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

On 07/01/2017 05:01 PM, Martell Malone wrote: > Can I apply this to master? > I have pigged this 3 times > I don't see any obvious issues with it, go ahead. signature.asc Description: OpenPGP digital signature --

Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

Can I apply this to master? I have pigged this 3 times On Sun, Jun 4, 2017 at 1:21 AM, Martell Malone wrote: > ping, don't let this one die on me please :) > > On Sun, May 21, 2017 at 7:05 PM, Martell Malone > wrote: > >> ping :) >> >> On Thu,

Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

ping, don't let this one die on me please :) On Sun, May 21, 2017 at 7:05 PM, Martell Malone wrote: > ping :) > > On Thu, May 11, 2017 at 2:10 PM, Martell Malone > wrote: > >> Thanks Kai, >> >> We probably don't need to push and pop because

Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

ping :) On Thu, May 11, 2017 at 2:10 PM, Martell Malone wrote: > Thanks Kai, > > We probably don't need to push and pop because this is not a header to be > installed > > Updated diff > > diff --git a/mingw-w64-crt/intrincs/rdtsc.c b/mingw-w64-crt/intrincs/ > rdtsc.c >

Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

Thanks Kai, We probably don't need to push and pop because this is not a header to be installed Updated diff diff --git a/mingw-w64-crt/intrincs/rdtsc.c b/mingw-w64-crt/intrincs/rdtsc.c index fd9cb75d..bf9c03b3 100644 --- a/mingw-w64-crt/intrincs/rdtsc.c +++ b/mingw-w64-crt/intrincs/rdtsc.c @@

Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

> > While it's not "good form" to have the prototype > in multiple places... Attached updated diff Please Review diff --git a/mingw-w64-crt/intrincs/rdtsc.c b/mingw-w64-crt/intrincs/rdtsc.c index fd9cb75d..7c5adeb0 100644 --- a/mingw-w64-crt/intrincs/rdtsc.c +++ b/mingw-w64-crt/intrincs/rdtsc.c

Re: [Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

On 4/14/2017 7:14 AM, Martell Malone wrote: > Updated clang no longer defines __IA32INTRIN_H so lets do this properly. It appears that the only use for in that file is the prototype for __rdtsc. While it's not "good form" to have the prototype in multiple places... > I assume intrin-impl.h

[Mingw-w64-public] [PATCH] intrincs: check for __rdtsc

Updated clang no longer defines __IA32INTRIN_H so lets do this properly. I assume intrin-impl.h is only ever included by intrin.h? If not I will have to find a way to deal with __has_builtin in both files Please Review Kind Regards Martell diff --git a/mingw-w64-crt/intrincs/rdtsc.c