Date: Tue, 19 Aug 2014 15:53:11 +0200
From: ja...@codeweavers.com
To: mingw-w64-public@lists.sourceforge.net
Subject: Re: [Mingw-w64-public] [PATCH 1/6] string_s.h/wchar_s.h: Added
wcsnlen_s implementation.
OK, I pushed it with extern inline
---
mingw-w64-headers/crt/sec_api/string_s.h | 3 +++
mingw-w64-headers/crt/sec_api/wchar_s.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/mingw-w64-headers/crt/sec_api/string_s.h b/mingw-w64-headers/crt/sec_api/string_s.h
index 34d1c99..4b10820 100644
---
Hmm, this patch looks to me not 100% ok.
Making functions static inline seems to be not the proper thing to do
here AFAICS. This will lead to warning for cases those functions
aren't used. So I would think that attribute unused is missing here.
Additionally the 'inline' looks to me bogus.
OK, I pushed it with extern inline declaration.
Thanks for reviews,
Jacek
On 08/19/14 15:38, Kai Tietz wrote:
Hmm, this patch looks to me not 100% ok.
Making functions static inline seems to be not the proper thing to do
here AFAICS. This will lead to warning for cases those functions
