Re: [Mingw-w64-public] [PATCH 2/2] localtime_r guard to _POSIX or _POSIX_THREAD_SAFE_FUNCTIONS

2014-10-21 Thread Adrien Nader
Hi Ray, On Tue, Oct 21, 2014, Ray Donnelly wrote: > On Tue, Oct 21, 2014 at 10:57 AM, JonY wrote: > > On 10/21/2014 17:50, JonY wrote: > >> On 10/21/2014 03:58, Ray Donnelly wrote: > >>> Comments welcome. > >> > >> Hi, > >> > >> Do you mind writing better comments for the patch? A single line > >

Re: [Mingw-w64-public] [PATCH 2/2] localtime_r guard to _POSIX or _POSIX_THREAD_SAFE_FUNCTIONS

2014-10-21 Thread Ray Donnelly
On Tue, Oct 21, 2014 at 10:57 AM, JonY wrote: > On 10/21/2014 17:50, JonY wrote: >> On 10/21/2014 03:58, Ray Donnelly wrote: >>> Comments welcome. >> >> Hi, >> >> Do you mind writing better comments for the patch? A single line >> followed by a blank line and then a longer description. >> > > Igno

Re: [Mingw-w64-public] [PATCH 2/2] localtime_r guard to _POSIX or _POSIX_THREAD_SAFE_FUNCTIONS

2014-10-21 Thread JonY
On 10/21/2014 17:50, JonY wrote: > On 10/21/2014 03:58, Ray Donnelly wrote: >> Comments welcome. > > Hi, > > Do you mind writing better comments for the patch? A single line > followed by a blank line and then a longer description. > Ignore the C11 part and mingw-w64-crt, a better description f

Re: [Mingw-w64-public] [PATCH 2/2] localtime_r guard to _POSIX or _POSIX_THREAD_SAFE_FUNCTIONS

2014-10-21 Thread JonY
On 10/21/2014 03:58, Ray Donnelly wrote: > Comments welcome. Hi, Do you mind writing better comments for the patch? A single line followed by a blank line and then a longer description. Do you also mind doing the implementations in mingw-w64-crt and replacing the time.h macros with prototypes? T

[Mingw-w64-public] [PATCH 2/2] localtime_r guard to _POSIX or _POSIX_THREAD_SAFE_FUNCTIONS

2014-10-20 Thread Ray Donnelly
Comments welcome. 0001-localtime_r-guard-to-_POSIX-or-_POSIX_THREAD_SAFE_FU.patch Description: Binary data -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS,