Re: [Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

On Mon, 6 May 2019, Jacek Caban wrote: On 5/6/19 1:10 PM, Martin Storsjö wrote: On Mon, 6 May 2019, Jacek Caban wrote: Hi Martin, All patches look good to me. Thanks! So you agree that it should practically be safe to change the value of this define and very few external users should be

Re: [Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

On 5/6/19 1:10 PM, Martin Storsjö wrote: On Mon, 6 May 2019, Jacek Caban wrote: Hi Martin, All patches look good to me. Thanks! So you agree that it should practically be safe to change the value of this define and very few external users should be hit by the change? (In practice I have

Re: [Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

On Mon, 6 May 2019, Jacek Caban wrote: Hi Martin, All patches look good to me. Thanks! So you agree that it should practically be safe to change the value of this define and very few external users should be hit by the change? (In practice I have only recently added such checks in one

Re: [Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

Hi Martin, All patches look good to me. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH 6/6] headers: Change __MSVCRT_VERSION__ to use proper hexadecimal values for CRTs >= 10

This tries to maintain backwards compatibility of enabling UCRT if either 0xE00 or 0x1400 is specified, but will break user code that check the value of __MSVCRT_VERSION__ >= 0x1400. This tries to correct the historical mistake in how the higher values of this constant is defined, before it goes