Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Jacek Caban
On 11/27/18 1:05 AM, Mateusz wrote: In all documentations about fseeko/fseek that I found it is clear stated that fseeko works exactly like fseek but it is better and preferable (because of _off_t instead of long). mingw implementation of fseeko64 looks too much simplified (it is possible

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Jacek Caban
On 11/27/18 2:41 PM, Martin Storsjö wrote: On Tue, 27 Nov 2018, Mateusz wrote: OK, I've attached minimal version -- inline helpers kept for ucrt, only _fseeki64 and _ftelli64 moved, I also removed 'DATA' guards for multiple definition in libmsvcr90 and 100. This version looks fine to me.

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Martin Storsjö
On Tue, 27 Nov 2018, Mateusz wrote: W dniu 26.11.2018 o 23:30, Jacek Caban pisze: On 11/26/18 10:31 PM, Martin Storsjö wrote: On Mon, 26 Nov 2018, Jacek Caban wrote: Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-27 Thread Mateusz
W dniu 26.11.2018 o 23:30, Jacek Caban pisze: > On 11/26/18 10:31 PM, Martin Storsjö wrote: >> On Mon, 26 Nov 2018, Jacek Caban wrote: >> >>> Hi Mateusz, >>> >>> >>> The patch looks mostly good to me. >>> >>> >>> On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Liu Hao
在 2018/11/27 上午6:30, Jacek Caban 写道: > On 11/26/18 10:31 PM, Martin Storsjö wrote: >> >> In general the patch (the latest version) looks rather straightforward >> to me, and I'm fine with it if Jacek is. > > > With inline helpers kept for ucrt builds, I will be fine with the patch. > >

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Mateusz
W dniu 26.11.2018 o 23:30, Jacek Caban pisze: > On 11/26/18 10:31 PM, Martin Storsjö wrote: >> On Mon, 26 Nov 2018, Jacek Caban wrote: >> >>> Hi Mateusz, >>> >>> >>> The patch looks mostly good to me. >>> >>> >>> On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Jacek Caban
On 11/26/18 10:31 PM, Martin Storsjö wrote: On Mon, 26 Nov 2018, Jacek Caban wrote: Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++ b/mingw-w64-headers/crt/stdio.h @@ -609,31 +609,20 @@ int vsnprintf (char

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Martin Storsjö
On Mon, 26 Nov 2018, Jacek Caban wrote: Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++ b/mingw-w64-headers/crt/stdio.h @@ -609,31 +609,20 @@ int vsnprintf (char *__stream, size_t __n, const char *__format,

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Mateusz
W dniu 26.11.2018 o 12:36, Jacek Caban pisze: > Hi Mateusz, > > > The patch looks mostly good to me. > > > On 23/11/2018 22:37, Mateusz wrote: >> --- a/mingw-w64-headers/crt/stdio.h >> +++ b/mingw-w64-headers/crt/stdio.h >> @@ -609,31 +609,20 @@ int vsnprintf (char *__stream, size_t __n, const

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Jacek Caban
Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++ b/mingw-w64-headers/crt/stdio.h @@ -609,31 +609,20 @@ int vsnprintf (char *__stream, size_t __n, const char *__format, __builtin_va_li /* Shouldn't be any

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-25 Thread Liu Hao
在 2018/11/24 上午5:37, Mateusz 写道: > I've attached new patch -- mingw-w64-crt/Makefile.am is changed so you should > use automake before testing. > > Now libmingwex.a is smaller (without _fseeki64 and _ftelli64 functions which > are moved to libmsvcrt.a). I can build and execute x265 linked to

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-23 Thread Mateusz
W dniu 22.11.2018 o 09:51, Mateusz pisze: > W dniu 21.11.2018 o 23:39, Martin Storsjö pisze: >> On Wed, 21 Nov 2018, Mateusz wrote: >> >>> Problem is in libstdc++.a which uses fseeko64 from libmingwex. >>> >>> My proposition is: >>> we could build two libmingwex -- libmingwex for msvcrt and

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-22 Thread Mateusz
W dniu 21.11.2018 o 23:39, Martin Storsjö pisze: > On Wed, 21 Nov 2018, Mateusz wrote: > >> Problem is in libstdc++.a which uses fseeko64 from libmingwex. >> >> My proposition is: >> we could build two libmingwex -- libmingwex for msvcrt and libmingwex10 for >> msvcr100 and above, leave fseeko64

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-21 Thread Martin Storsjö
On Wed, 21 Nov 2018, Mateusz wrote: Problem is in libstdc++.a which uses fseeko64 from libmingwex. My proposition is: we could build two libmingwex -- libmingwex for msvcrt and libmingwex10 for msvcr100 and above, leave fseeko64 in libmingwex* and remove _fseeki64 and _ftelli64 from

[Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-21 Thread Mateusz
Hello, When I try to build x265 with ucrtbase (instead of msvcrt) I get errors: f:/msys/m64-82/bin/../lib/gcc/x86_64-w64-mingw32/8.2.0/../../../../x86_64-w64-mingw32/lib/../lib/libucrt.a(dtwcs00041.o):(.text+0x0): multiple definition of `_fseeki64';