On 23.04.2024 13:39, Martin Storsjö wrote:
On Tue, 16 Apr 2024, Jacek Caban wrote:
But in this particular case, I think we may improve things on
mingw-w64-crt side and move __sinl_internal to msvcr* importlibs.
Something like the attached (untested) patch should help.
Unfortunately, we
On Tue, 16 Apr 2024, Jacek Caban wrote:
But in this particular case, I think we may improve things on
mingw-w64-crt side and move __sinl_internal to msvcr* importlibs.
Something like the attached (untested) patch should help.
Unfortunately, we can't really do this; __sinl_internal and
Le mercredi 17 avril 2024 à 23:13:18 UTC+2, Martin Storsjö
a écrit :
On Tue, 16 Apr 2024, philippe renon via Mingw-w64-public wrote:
> All this to ask whether that "breaking" change was intentional ?
The change itself was quite intentional, the breakage obviously wasn't
intentional.
On Tue, 16 Apr 2024, philippe renon via Mingw-w64-public wrote:
All this to ask whether that "breaking" change was intentional ?
The change itself was quite intentional, the breakage obviously wasn't
intentional.
We have a fair bit of these kinds of circular dependencies between
I don't know how we can check that.
The test that failed has nothing to do with math:
https://github.com/rust-lang/rust/issues/2214 and I suppose lgamma was picked
somewhat randomly as a function that requires FFI and should be universally
available.
Moving sin and log internal
The Rust test that failed uses the gamma function that depends on sin and log.
So sin and log showed up in the link failure.
I would expect cos to be problematic too.But I can't provide an exhaustive list.
Le mardi 16 avril 2024 à 17:40:34 UTC+2, philippe renon via
Mingw-w64-public a écrit
Note that there are more math functions involved (not just sin).
See the commit that introduced the issue for a full list:
https://github.com/mingw-w64/mingw-w64/commit/a64c1f4b969cff5f9e81c9a760117dc1b92d6ee1
Le mardi 16 avril 2024 à 16:44:31 UTC+2, Jacek Caban
a écrit :
On
On 16.04.2024 17:29, philippe renon wrote:
Note that there are more math functions involved (not just sin).
See the commit that introduced the issue for a full list:
https://github.com/mingw-w64/mingw-w64/commit/a64c1f4b969cff5f9e81c9a760117dc1b92d6ee1
I know, but only the ones that depend
On 16.04.2024 15:51, philippe renon via Mingw-w64-public wrote:
The error seems to happen because Rust pulls in lgamma from
libmingwex.a, which pulls in sin from libmsvcrt.a, which in turn tries
to pull in __sinl_internal from libmingwex.a and fails because of how
Rust links MinGW libs:
let
Forgot to mention that this issue affects the MSYS2 build of Rust.See
https://github.com/msys2/MINGW-packages/pull/20397#issuecomment-2050581972
Le mardi 16 avril 2024 à 14:29:22 UTC+2, philippe renon via
Mingw-w64-public a écrit :
One of the Rust unit test fails because of this
One of the Rust unit test fails because of this change :
https://github.com/mingw-w64/mingw-w64/commit/a64c1f4b969cff5f9e81c9a760117dc1b92d6ee1
The test that fails is externally linking the lgamma function :
11 matches
Mail list logo
