Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-24 Thread Kirill Makurin
; Kirill Makurin Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-08 01:06, Kirill Makurin 写道: > From 87951029ce19f763ebf28262bf0bb3a48fbed0c2 Mon Sep 17 00:00:00 2001 > From: Kirill Makurin > Date: Sat, 8 Feb 2025 01:45:40 +090

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-19 Thread LIU Hao
在 2025-02-19 22:48, Kirill Makurin 写道: Make executes each line of a recipe in a new shell and we need to pass the whole recipe in a single shell invocation, so that's the point of `;\`. I could align slashes to make it more readable. I think using `printf %s` instead of `echo` is less likely to

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-19 Thread Kirill Makurin
ts to be cautious. - Kirill Makurin From: LIU Hao Sent: Tuesday, February 18, 2025 10:37 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-16

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-18 Thread LIU Hao
在 2025-02-16 20:27, Kirill Makurin 写道: +# Handle -lpthread alias when installing +install-exec-hook: + . $(builddir)/libwinpthread.la; \ + if test -n "$${library_names}"; then \ + alias=$$(printf %s "$${library_names}" | $(SED) 's|winpthread|pthread|'); \ +

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread Kirill Makurin
w-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-16 19:38, Kirill Makurin 写道: > If you're good with that patch, I would like to update it to also remove > lines in `configure.ac` > which define `COPY_STATIC` and `COPY_SHARED` Automake condition

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread Kirill Makurin
U Hao Sent: Sunday, February 16, 2025 8:46 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-16 19:38, Kirill Makurin 写道: > If you're good with that patch, I would like to

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread LIU Hao
在 2025-02-16 19:38, Kirill Makurin 写道: If you're good with that patch, I would like to update it to also remove lines in `configure.ac` which define `COPY_STATIC` and `COPY_SHARED` Automake conditionals. Let me know what you decide. Yes it makes sense. `LT_OBJDIR` also seems unused thereafte

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread Kirill Makurin
ry 16, 2025 1:31 AM To: LIU Hao ; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h It slipped my mind back then that we can source .la files to get the variables. I attached modified patch. The only issue that

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-15 Thread Kirill Makurin
From: LIU Hao Sent: Sunday, February 16, 2025 12:30 AM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-15 23:23, Kirill Makurin 写道: > What do you think if we just guard th

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-15 Thread LIU Hao
在 2025-02-15 23:23, Kirill Makurin 写道: What do you think if we just guard those rules for `libptrhead[.dll].a` with `if !MSVC`? Libtool has a silly behavior with MSVC tools. When you create a shared library which depends on another (non-libtool) shared library, when it handles `-l{name}` it se

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-15 Thread Kirill Makurin
? - Kirill Makurin From: LIU Hao Sent: Saturday, February 15, 2025 11:36 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-10 15:31, Kirill Mak

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-15 Thread LIU Hao
在 2025-02-10 15:31, Kirill Makurin 写道: It seems defining variables like `{libname}_AR` has no effect if {libname} is defined as `LTLIBRARIES` target, libtool script just used AR set during configuration. This method works only with `LIBRARIES` targets. The best I could achieve with `LTLIBRARIE

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-09 Thread Kirill Makurin
18 PM To: mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-09 19:10, LIU Hao 写道: > libpthread_a_AR = ${LIBTOOL} --tag=CCLD --mode=link -static \ > $(LN_S) libwi

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-09 Thread LIU Hao
在 2025-02-09 19:10, LIU Hao 写道:    libpthread_a_AR = ${LIBTOOL} --tag=CCLD --mode=link -static  \ $(LN_S) libwinpthread.la libpthread.la    libpthread_dll_a_AR = ${LIBTOOL} --tag=CCLD --mode=link  \ $(LN_S) libwinpthread.la libpthread

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-09 Thread LIU Hao
在 2025-02-09 18:30, Kirill Makurin 写道: A little off-thread, but could you please take a look at attached patches? I sent them to the list a few months ago addressing issues with winpthreads' Makefile.am when using MSVC. The following part of Makefile.am causes build failure when using MSVC: T

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-09 Thread Kirill Makurin
a and libpthread.dll.a so winpthreads can be linked with usual `-lpthread`. Any ideas? - Kirill Makurin From: LIU Hao Sent: Sunday, February 9, 2025 6:58 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_A

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-09 Thread LIU Hao
在 2025-02-09 16:40, Kirill Makurin 写道: You make a good point here. Move both guarded declaration of `clockid_t` and definition of `WINPTHREAD_API ` to pthread_compat.h and include it from both pthread.h and pthread_time.h. How does this look? Thanks! These patches look good to me. Pushed

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-09 Thread Kirill Makurin
, 2025 4:46 PM To: Kirill Makurin ; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h 在 2025-02-09 03:18, Kirill Makurin 写道: > I think the idea of including pthread_time.h through pthread_compat.h f

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-08 Thread LIU Hao
在 2025-02-09 03:18, Kirill Makurin 写道: I think the idea of including pthread_time.h through pthread_compat.h from pthread.h is to make `clock_gettime` and other time functions available for MSVC users without explicitly including pthread_time.h, which is a non-standard header file. Declaration

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-08 Thread LIU Hao
在 2025-02-08 01:06, Kirill Makurin 写道: From 87951029ce19f763ebf28262bf0bb3a48fbed0c2 Mon Sep 17 00:00:00 2001 From: Kirill Makurin Date: Sat, 8 Feb 2025 01:45:40 +0900 Subject: [PATCH] winpthreads: make sure WINPTHREAD_API is correctly defined in pthread_time.h When building with MSVC, pthrea

[Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-07 Thread Kirill Makurin
See attached patch. - Kirill Makurin From 87951029ce19f763ebf28262bf0bb3a48fbed0c2 Mon Sep 17 00:00:00 2001 From: Kirill Makurin Date: Sat, 8 Feb 2025 01:45:40 +0900 Subject: [PATCH] winpthreads: make sure WINPTHREAD_API is correctly defined in pthread_time.h When building with MSVC, pthread_ti