Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

2018-09-14 Thread Jacek Caban
On 09/14/2018 03:45 PM, Liu Hao wrote: > 在 2018/9/14 21:30, Jacek Caban 写道: >> My patch is 32-bit only and so is importlib alias. >> >> Jacek >> > Oh I didn't notice this difference. And thanks for the reminder. > > The patch looks good. Please apply. Pushed, thanks for review. Jacek

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

2018-09-14 Thread Liu Hao
在 2018/9/14 21:30, Jacek Caban 写道: > My patch is 32-bit only and so is importlib alias. > > Jacek > Oh I didn't notice this difference. And thanks for the reminder. The patch looks good. Please apply. -- Best regards, LH_Mouse ___ Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

2018-09-14 Thread Jacek Caban
On 09/14/2018 03:25 PM, Liu Hao wrote: > 在 2018-09-14 20:22, Jacek Caban 写道: >> On 09/14/2018 02:21 PM, Liu Hao wrote: >>> 在 2018/9/14 20:08, Jacek Caban 写道: *32 variants are handled by importlibs for crts that need it anyway and unsuffixed variants don't exist in ucrt runtime. >>>

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

2018-09-14 Thread Liu Hao
在 2018-09-14 20:22, Jacek Caban 写道: > On 09/14/2018 02:21 PM, Liu Hao wrote: >> 在 2018/9/14 20:08, Jacek Caban 写道: >>> *32 variants are handled by importlibs for crts that need it anyway and >>> unsuffixed variants don't exist in ucrt runtime. >>> >> This could break code that makes use of MSVCRT,

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

2018-09-14 Thread Liu Hao
在 2018/9/14 20:08, Jacek Caban 写道: > > *32 variants are handled by importlibs for crts that need it anyway and > unsuffixed variants don't exist in ucrt runtime. > This could break code that makes use of MSVCRT, as it is only in MSVCRT that `_fstat32` is absent. It exists in all MSVCR* DLLs