Re: [Mingw-w64-public] [PATCH] dhcpcsvc.def: Add missing entries.

On 09/14/2018 04:52 PM, Liu Hao wrote: > 在 2018-09-14 22:17, Jacek Caban 写道: >> Signed-off-by: Jacek Caban >> --- >> mingw-w64-crt/lib32/dhcpcsvc.def | 63 >> >> 1 file changed, 63 insertions(+) >> >> > It looks good to me. Pushed, thanks. Jacek

Re: [Mingw-w64-public] [PATCH] dhcpcsvc.def: Add missing entries.

在 2018-09-14 22:17, Jacek Caban 写道: > Signed-off-by: Jacek Caban > --- > mingw-w64-crt/lib32/dhcpcsvc.def | 63 > > 1 file changed, 63 insertions(+) > > It looks good to me. -- Best regards, LH_Mouse

[Mingw-w64-public] [PATCH] dhcpcsvc.def: Add missing entries.

Signed-off-by: Jacek Caban --- mingw-w64-crt/lib32/dhcpcsvc.def | 63 1 file changed, 63 insertions(+) diff --git a/mingw-w64-crt/lib32/dhcpcsvc.def b/mingw-w64-crt/lib32/dhcpcsvc.def index 84023c7a..d1e733ca 100644 ---

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

在 2018/9/14 20:08, Jacek Caban 写道: > > *32 variants are handled by importlibs for crts that need it anyway and > unsuffixed variants don't exist in ucrt runtime. > This could break code that makes use of MSVCRT, as it is only in MSVCRT that `_fstat32` is absent. It exists in all MSVCR* DLLs

[Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

*32 variants are handled by importlibs for crts that need it anyway and unsuffixed variants don't exist in ucrt runtime. Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/_mingw_stat64.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

在 2018-09-14 20:22, Jacek Caban 写道: > On 09/14/2018 02:21 PM, Liu Hao wrote: >> 在 2018/9/14 20:08, Jacek Caban 写道: >>> *32 variants are handled by importlibs for crts that need it anyway and >>> unsuffixed variants don't exist in ucrt runtime. >>> >> This could break code that makes use of MSVCRT,

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

On 09/14/2018 03:25 PM, Liu Hao wrote: > 在 2018-09-14 20:22, Jacek Caban 写道: >> On 09/14/2018 02:21 PM, Liu Hao wrote: >>> 在 2018/9/14 20:08, Jacek Caban 写道: *32 variants are handled by importlibs for crts that need it anyway and unsuffixed variants don't exist in ucrt runtime. >>>

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

在 2018/9/14 21:30, Jacek Caban 写道: > My patch is 32-bit only and so is importlib alias. > > Jacek > Oh I didn't notice this difference. And thanks for the reminder. The patch looks good. Please apply. -- Best regards, LH_Mouse ___ Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.

On 09/14/2018 03:45 PM, Liu Hao wrote: > 在 2018/9/14 21:30, Jacek Caban 写道: >> My patch is 32-bit only and so is importlib alias. >> >> Jacek >> > Oh I didn't notice this difference. And thanks for the reminder. > > The patch looks good. Please apply. Pushed, thanks for review. Jacek