On Sun, 16 May 2021, Liu Hao wrote:
LGTM
// Martin
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
From 12d026984d097182a49b950a1cbdd8f64d2ce659 Mon Sep 17 00:00:00 2001
From: Biswapriyo Nath
Date: Sun, 16 May 2021 18:58:54 +0530
Subject: [PATCH] headers: Add missing interfaces in mfidl.idl.
Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/include/mfidl.idl | 174
--
Best regards,
Liu Hao
From dbdc6232eb45a8a3f8830c3664b41efd49388d04 Mon Sep 17 00:00:00 2001
From: Liu Hao
Date: Sun, 16 May 2021 20:25:06 +0800
Subject: [PATCH] include/stdio: Move macro push/pops outside any
`#if...#endif` blocks
Some projects have `#define snprintf _snprintf`, which
On Sun, May 16, 2021 at 11:58 AM Liu Hao wrote:
> Who was it that added the `#define`? Users should have known that `_snprintf`
> does not
> null-terminate the output string if there is no enough room in the output
> buffer, which is rather
> dangerous.
Some projects I've seen it in: gimp,
On 5/16/21 10:52 AM, Liu Hao wrote:
在 2021-05-16 18:49, JonY via Mingw-w64-public 写道:
Updated.
Thanks. LGTM.
Thanks for the review, pushed to master.
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
在 2021-05-16 18:49, JonY via Mingw-w64-public 写道:
Updated.
Thanks. LGTM.
--
Best regards,
Liu Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
On 5/16/21 9:36 AM, Liu Hao wrote:
在 2021-05-16 17:21, JonY via Mingw-w64-public 写道:
diff --git a/mingw-w64-headers/crt/math.h b/mingw-w64-headers/crt/math.h
index 3754dc64..b9277bd0 100644
--- a/mingw-w64-headers/crt/math.h
+++ b/mingw-w64-headers/crt/math.h
@@ -143,8 +143,12 @@ extern "C" {
在 2021-05-15 13:19, Biswapriyo Nath 写道:
Subject: [PATCH] headers: Add more GUIDs in mfidl.idl.
Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/include/mfidl.idl | 55 +
1 file changed, 55 insertions(+)
Thanks. This patch looks good to me. Pushed.
--
Best
在 2021-05-16 17:21, JonY via Mingw-w64-public 写道:
diff --git a/mingw-w64-headers/crt/math.h b/mingw-w64-headers/crt/math.h
index 3754dc64..b9277bd0 100644
--- a/mingw-w64-headers/crt/math.h
+++ b/mingw-w64-headers/crt/math.h
@@ -143,8 +143,12 @@ extern "C" {
#endif
#ifndef _HUGE
+#ifdef
在 2021-05-15 15:01, Christoph Reiter 写道:
Hey,
while trying to get everything to build with UCRT in MSYS2 we noticed
quite a few errors that come down to the following:
// gcc -D__USE_MINGW_ANSI_STDIO=1 a.c
#define snprintf _snprintf
#include
int main (){return 0;}
i.e. snprintf is defined
On 5/16/21 8:25 AM, Liu Hao wrote:
在 2021-05-15 23:23, JonY via Mingw-w64-public 写道:
The prototype declares it as a non-const, will it be a problem?
In addition, it looks like UCRT doesn't declare it as an imported symbol
any more. It's plain `extern double const _HUGE;` now.
Patch
在 2021-05-15 23:23, JonY via Mingw-w64-public 写道:
The prototype declares it as a non-const, will it be a problem?
Yes, I think it should be `const double` instead of plain `double`.
--
Best regards,
Liu Hao
OpenPGP_signature
Description: OpenPGP digital signature
在 2021-05-15 23:23, JonY via Mingw-w64-public 写道:
The prototype declares it as a non-const, will it be a problem?
In addition, it looks like UCRT doesn't declare it as an imported symbol any more. It's plain
`extern double const _HUGE;` now.
--
Best regards,
Liu Hao
OpenPGP_signature
13 matches
Mail list logo
