Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/coremessaging.def | 33 ++
mingw-w64-crt/lib32/Makefile.am| 1 +
mingw-w64-crt/lib32/coremessaging.def | 33 ++
mingw-w64-crt/lib64/Makefile.am| 1 +
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/xinputuap.def | 11 +++
mingw-w64-crt/lib32/Makefile.am| 1 +
mingw-w64-crt/lib32/xinputuap.def | 11 +++
mingw-w64-crt/lib64/Makefile.am| 1 +
mingw-w64-crt/libarm32/Makefile.am | 1 +
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/d2d1.def | 1 +
mingw-w64-crt/lib32/d2d1.def | 8
2 files changed, 9 insertions(+)
diff --git a/mingw-w64-crt/lib-common/d2d1.def
b/mingw-w64-crt/lib-common/d2d1.def
index 1cd27c095..f3f06e326 100644
---
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/d2d1.def | 12 ++--
mingw-w64-crt/lib32/d2d1.def | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/mingw-w64-crt/lib-common/d2d1.def
b/mingw-w64-crt/lib-common/d2d1.def
index 8d5b753c6..1cd27c095
> Very much a nitpick/subjective preference; there's no need to use shouty
> uppercase for the /INCLUDE directive, lowercase should work just as well.
And shouting at the linker doesn't fix its bugs :/
> Other than that, this patch looks good to me now, thanks!
Thanks a lot for the reviews!
--
> These changes here aren't accounted for in the commit message; the typo
> fixes are straightforward, but it might be good also to mention that
> you're expressing the license with a specific version
That's probably me being overzealous! My intent was to use the ZPL
SPDX identifier [1].
There's
Unfortunately I somehow forgot to test this new patch with clang-cl,
which warns about the snippet. It requires a previous declaration of
the variable. I'm not sure if both declaration and definition require
the attributes too.
src/thread.c(540,84): error: no previous extern declaration for
