Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

On 2017/4/4 2:11, Jacek Caban wrote: > I'm sorry to jump into discussion so late. The patch looks good to me. OK I pushed it to master. -- Best regards, LH_Mouse -- Check out the vibrant tech community on one of the

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

On 03.04.2017 19:02, Liu Hao wrote: > On 2017/4/4 0:48, David Grayson wrote: >> I'm a bit confused about the different inlining keywords. From the GCC >> documentation for inlining in the C language ( >> https://gcc.gnu.org/onlinedocs/gcc/Inline.html ) it seemed like "extern >> inline" (i.e.

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

On Mon, Apr 3, 2017 at 10:02 AM, Liu Hao wrote: > On 2017/4/4 0:48, David Grayson wrote: > > I'm a bit confused about the different inlining keywords. From the GCC > > documentation for inlining in the C language ( > > https://gcc.gnu.org/onlinedocs/gcc/Inline.html ) it seemed

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

On 2017/4/4 0:48, David Grayson wrote: > I'm a bit confused about the different inlining keywords. From the GCC > documentation for inlining in the C language ( > https://gcc.gnu.org/onlinedocs/gcc/Inline.html ) it seemed like "extern > inline" (i.e. __CRT_INLINE) would be the best thing to use,

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

I looked into it a little more. __NO_INLINE__ is a macro provided by GCC that is documented to be defined if "no functions will be inlined into their callers". This seems to be defined by GCC by default, but it is not defined when you provide the "-O2" option. __CRT__NO_INLINE is defined in

[Mingw-w64-public] [PATCH] stralign: cast ua_wcschr and ua_wcsrchr returns to wchar_t *

I made another attempt to build libc++ with mingw-w64 and stumbled across Clang errors: |D:\msys64\mingw64\x86_64-w64-mingw32\include\windows.h:114: D:\msys64\mingw64\x86_64-w64-mingw32\include\stralign.h:121:37: error: cannot initialize return object of type 'PUWSTR_C' (aka 'wchar_t *') with an

Re: [Mingw-w64-public] [PATCH] intrin-impl.h: Fix mismatched ifdefs

Hi Martin, The patch looks good to me, thanks for fixing it. Jacek On 03.04.2017 10:24, Martin Storsjö wrote: > 072254d added mismatched ifdefs for _InterlockedCompareExchange64 > (only added an #if with no matching #endif) and for __readfsdword > (only added a new #endif to an #if that already

[Mingw-w64-public] [PATCH] intrin-impl.h: Fix mismatched ifdefs

072254d added mismatched ifdefs for _InterlockedCompareExchange64 (only added an #if with no matching #endif) and for __readfsdword (only added a new #endif to an #if that already had a matching #endif). This fixes compilation for arm. --- mingw-w64-headers/include/psdk_inc/intrin-impl.h | 2 +-