Re: [Mingw-w64-public] [PATCH 2/2] dwrite_1.h: Fix build in C mode

2020-05-15 Thread Jacek Caban 

On 08.05.2020 12:18, Ruslan Garipov wrote:

-enum DWRITE_BASELINE
+typedef enum DWRITE_BASELINE
  {
  DWRITE_BASELINE_DEFAULT,
  DWRITE_BASELINE_ROMAN,
@@ -25,40 +70,40 @@ enum DWRITE_BASELINE
  DWRITE_BASELINE_IDEOGRAPHIC_TOP,
  DWRITE_BASELINE_MINIMUM,
  DWRITE_BASELINE_MAXIMUM,
-};
+} DWRITE_BASELINE;



WinSDK doesn't have those typedefs and I think we should stay compatible 
on that. I can see that dwrite.h has such typedefs, but it's probably a 
mistake.



+STDMETHOD(GetDesignGlyphAdvances)(IDWriteFontFace1 *This, UINT32,UINT16 
const*,INT32*,BOOL isSideways __MINGW_DEF_ARG_VAL(FALSE)) PURE;



You don't need default value in C version, it will not be used anyway.
 


Thanks,

Jacek



___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/2] dwrite.h: Fix build in C mode

2020-05-15 Thread Jacek Caban 

Hi Ruslan,

The patch looks good to me, I pushed it.

Thanks,
Jacek


___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public