Re: [Mingw-w64-public] [PATCH v3] crt: Remove duplicate entries from DEF files

2022-05-01 Thread LIU Hao
在 2022-05-02 05:22, Martin Storsjö 写道: On Sun, 1 May 2022, LIU Hao wrote: Some more issues addressed:  * 'api-ms-win-crt-math-l1-1-0.def.in' contained both `hypot == _hypot` and `hypot`.  * 'api-ms-win-crt-math-l1-1-0.def.in' contained both `nextafter == _nextafter` and `nextafter`.  *

Re: [Mingw-w64-public] [PATCH v3] crt: Remove duplicate entries from DEF files

2022-05-01 Thread Martin Storsjö
On Sun, 1 May 2022, LIU Hao wrote: Some more issues addressed: * 'api-ms-win-crt-math-l1-1-0.def.in' contained both `hypot == _hypot` and `hypot`. * 'api-ms-win-crt-math-l1-1-0.def.in' contained both `nextafter == _nextafter` and `nextafter`. * 'kernel32.def.in' contained both

[Mingw-w64-public] [PATCH v3] crt: Remove duplicate entries from DEF files

2022-05-01 Thread LIU Hao
Some more issues addressed: * 'api-ms-win-crt-math-l1-1-0.def.in' contained both `hypot == _hypot` and `hypot`. * 'api-ms-win-crt-math-l1-1-0.def.in' contained both `nextafter == _nextafter` and `nextafter`. * 'kernel32.def.in' contained both `F_X64(EnterUmsSchedulingMode)` and

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread LIU Hao
On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: I think dllexport should be replaced by dllimport in the above statement. Yes it was a typo. Revised patch attached. On Sun, May 1, 2022 at 9:36 AM Martin Storsjö wrote: FWIW, I think this will break a number of users, who currently

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread JonY via Mingw-w64-public
On 5/1/22 07:55, Vincent Torri wrote: But if you really really prefer this setup, then fine, go ahead. But I did warn that it will inconvenirnce users. should winpthread be used by users ? i thought it was written for c++11 threads Vincent Torri You can still use winpthreads directly, it

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread Vincent Torri
On Sun, May 1, 2022 at 9:36 AM Martin Storsjö wrote: > > On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: > > > On 5/1/22 05:19, LIU Hao wrote: > >> 在 2022-05-01 13:15, LIU Hao 写道: > >>> This is the alternative patch as discussed with jon_y on IRC. > >>> > >>> > >> > >> I forgot to update the

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread Martin Storsjö
On Sun, 1 May 2022, JonY via Mingw-w64-public wrote: On 5/1/22 05:19, LIU Hao wrote: 在 2022-05-01 13:15, LIU Hao 写道: This is the alternative patch as discussed with jon_y on IRC. I forgot to update the commit message. Here is the revised patch. +Programs are usually linked against the

Re: [Mingw-w64-public] [PATCH] winpthreads: Do not use `dllimport` when building 3rd-party DLLs

2022-05-01 Thread JonY via Mingw-w64-public
On 5/1/22 05:19, LIU Hao wrote: 在 2022-05-01 13:15, LIU Hao 写道: This is the alternative patch as discussed with jon_y on IRC. I forgot to update the commit message. Here is the revised patch. +Programs are usually linked against the winpthreads DLL, and winpthreads +headers expose