Re: [Mingw-w64-public] [PATCH 2/2] crt: Add missing API sets to windowsapp.lib
On 2023-09-29 10:33, Martin Storsjö wrote: On Fri, 29 Sep 2023, Steve Lhomme wrote: For the record, I some scripts to generate/update the files. Mostly using the "dumpbin /linkmember" results to generate them and check the changes depending on the Windows SDK version for each official Windows 10/11 builds. Yeah, I think I've got a script that does something similar to that as well. My main issue was that there was so many changes in the same patch making it hard to get an overview. As mentioned, there are many minor details that easily drown in the patches, like removal of RtlVirtualUnwind from lib-common, even if it does exist on x64 (but not x86). Anyway, Mark's patches reach essentially the same state as your patches, except for removals of symbols and def files. If those removals are important for your setup, let's handle them as separate patches later. Nope. Especially if they are wrong. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] crt: Add an i686 version of api-ms-win-security-provider-ansi-l1-1-0.def
On Fri, 29 Sep 2023, LIU Hao wrote: 在 2023-09-27 20:51, Martin Storsjö 写道: This goes along with the version in lib-common added in b57b0420e16c5811dff576d7fb8932ab871ccf00. The def file is extracted from another (yet unapplied) patch by Steve Lhomme. Signed-off-by: Martin Storsjö --- .../lib32/api-ms-win-security-provider-ansi-l1-1-0.def| 8 1 file changed, 8 insertions(+) create mode 100644 mingw-w64-crt/lib32/api-ms-win-security-provider-ansi-l1-1-0.def This patch looks good to me. Thanks, I pushed these both patches. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 1/2] crt: Add an i686 version of api-ms-win-core-registry-l2-1-0.def
在 2023-09-27 20:51, Martin Storsjö 写道: This goes along with the version in lib-common added in f83a1f7d991957d4ee84e1198412a2154084ffe7. The def file is extracted from another (yet unapplied) patch by Steve Lhomme. Signed-off-by: Martin Storsjö --- .../lib32/api-ms-win-core-registry-l2-1-0.def | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 mingw-w64-crt/lib32/api-ms-win-core-registry-l2-1-0.def LGTM, too. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/process: fix bare DllMain/_CRT_INIT signature
在 2023-09-27 20:20, Steve Lhomme 写道: The DWORD reason corresponds to an "unsigned long", not an "unsigned". This is also how it's defined in the Windows SDK. --- mingw-w64-headers/crt/process.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] crt: Add an i686 version of api-ms-win-security-provider-ansi-l1-1-0.def
在 2023-09-27 20:51, Martin Storsjö 写道: This goes along with the version in lib-common added in b57b0420e16c5811dff576d7fb8932ab871ccf00. The def file is extracted from another (yet unapplied) patch by Steve Lhomme. Signed-off-by: Martin Storsjö --- .../lib32/api-ms-win-security-provider-ansi-l1-1-0.def| 8 1 file changed, 8 insertions(+) create mode 100644 mingw-w64-crt/lib32/api-ms-win-security-provider-ansi-l1-1-0.def This patch looks good to me. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Include more d3d11 and d3d12 headers in dxguid library
在 2023-09-28 15:25, Biswapriyo Nath 写道: From f85fc5b8a85edd6d626785822833902db514db55 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Thu, 28 Sep 2023 07:24:12 + Subject: [PATCH] crt: Include more d3d11 and d3d12 headers in dxguid library Signed-off-by: Biswapriyo Nath --- mingw-w64-crt/libsrc/dxguid.c | 6 ++ 1 file changed, 6 insertions(+) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] crt: Add missing API sets to windowsapp.lib
On Wed, 27 Sep 2023, Martin Storsjö wrote: On Mon, 25 Sep 2023, Mark Harmstone wrote: Some of these were added by the previous patch, and some are new. Signed-off-by: Mark Harmstone --- diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 7f137b4f0..1b2caeab5 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -2029,6 +2029,7 @@ endif %/libapi-ms-win-core-com-l1-1-2.a \ %/libapi-ms-win-core-com-l1-1-3.a \ %/libapi-ms-win-core-com-midlproxystub-l1-1-0.a \ + %/libapi-ms-win-core-com-l1-1-0.a \ %/libapi-ms-win-core-comm-l1-1-0.a \ This is a stray change (it adds a duplicate l1-1-0.a dependency on mincore, while this patch touches windowsapp). Other than, I think this patchset looks good. Steve Lhomme sent a similar patchset on June 26th. I reviewed it (quite belatedly, sorry about that) on July 20th, where I requested it to be split into smaller pieces; that patchset both added new symbols and new def files, and removed other def files that weren't reachable with the mincore/windowsapp headers that he had compared with. I compared the end result of this patchset and Steve's, and this one should be a superset (after adding the extra two patches I just sent); there are still def files that might not be reachable with current MS import libraries, but if important, those can be pruned in a separate step. So if there aren't any objections to it, I would go ahead and push these two patches sometime soon. Pushed now, thanks! // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] crt: Add missing API sets to windowsapp.lib
On Fri, 29 Sep 2023, Steve Lhomme wrote: For the record, I some scripts to generate/update the files. Mostly using the "dumpbin /linkmember" results to generate them and check the changes depending on the Windows SDK version for each official Windows 10/11 builds. Yeah, I think I've got a script that does something similar to that as well. My main issue was that there was so many changes in the same patch making it hard to get an overview. As mentioned, there are many minor details that easily drown in the patches, like removal of RtlVirtualUnwind from lib-common, even if it does exist on x64 (but not x86). Anyway, Mark's patches reach essentially the same state as your patches, except for removals of symbols and def files. If those removals are important for your setup, let's handle them as separate patches later. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
