Re: [Mingw-w64-public] [PATCH] winpthreads: Check GetModuleHandle return value before calling GetProcAddress

2023-11-10 Thread Martin Storsjö

On Thu, 9 Nov 2023, LIU Hao wrote:


在 2023-11-09 21:27, Martin Storsjö 写道:

On Tue, 31 Oct 2023, Martin Storsjö wrote:


In Windows Store builds with the winstorecompat library,
GetModuleHandle returns null, and GetProcAddress is not documented
to allow passing null.

Signed-off-by: Martin Storsjö 
---
mingw-w64-libraries/winpthreads/src/clock.c  | 8 +---
mingw-w64-libraries/winpthreads/src/misc.c   | 4 +++-
mingw-w64-libraries/winpthreads/src/thread.c | 6 --
3 files changed, 12 insertions(+), 6 deletions(-)


Ping



This patch looks good to me. Sorry for overlooking.


Thanks, pushed now, and no problem - there wasn't any rush about this.

// Martin

___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


Re: [Mingw-w64-public] Determine whether a mingw-w64 port of gcc is UCRT or MSVCRT

2023-11-10 Thread LIU Hao

在 2023/11/10 14:51, sisyphus 写道:

Given that I have, in my path, a mingw-w64 port of version 13.2.0 of
gcc.exe, is there a gcc command that I can run to determine whether this
gcc uses UCRT ?

I thought that running "gcc --version" would do that - and it does for
Brecht Sanders builds ... but niXman's UCRT and MSVCRT builds both report
the same for "gcc --version".

Is there instead something in "gcc -v" that I should be looking for ?



```
echo '#include ' | x86_64-w64-mingw32-gcc -E -dM -xc - | fgrep _UCRT
```

gives `#define _UCRT` if the headers have been configured to use UCRT by 
default.


--
Best regards,
LIU Hao



OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public