[Mingw-w64-public] [PATCH] d2d1.h: Work around GCC not being compatible with MSVC in aggregate retuns handling.

Based on patch by Tom Ritter. Tom explained it here: https://sourceforge.net/p/mingw-w64/mailman/message/36238073/ I added WIDL_EXPLICIT_AGGREGATE_RETURNS preprocessor guards so that it's not used then not needed. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/i

Re: [Mingw-w64-public] Error in CD3D11_BLEND_DESC in D3D11 Header

On 04/20/2018 05:34 PM, Jacek Caban wrote: > On 04/19/2018 04:31 PM, Tom Ritter wrote: >> I feel pretty confident that this line has a bug, and the for >> initialization should be 'target = RenderTarget' >> >> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree

Re: [Mingw-w64-public] Error in CD3D11_BLEND_DESC in D3D11 Header

On 04/19/2018 04:31 PM, Tom Ritter wrote: > I feel pretty confident that this line has a bug, and the for > initialization should be 'target = RenderTarget' > > https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/direct-x/include/d3d11.h#l1644 > > I was getting errors in

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

On 03/15/2018 02:54 PM, Ebrahim Byagowi wrote: > Oh, I see, done. Looks good to me. I pushed that to Git. Thanks, Jacek -- Check out the vibrant tech community on one of the world's most engaging tech sites,

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

Hi Ebrahim, #ifndef __cplusplus inside IDWriteTextAnalyzer1 should be around all parent interfaces' methods (IDWriteTextAnalyzer in this case), not just IUnknown. Thanks, Jacek On 3/14/18 12:19 AM, Ebrahim Byagowi wrote: Spotted one minor issue on the patch, here is another On Wed,

Re: [Mingw-w64-public] [PATCH] uianimation.h: Add missed defines

Hi Ruslan, On 2/17/18 5:45 PM, Ruslan Garipov wrote: diff --git a/mingw-w64-headers/include/uianimation.h b/mingw-w64-headers/include/uianimation.h index 5fce04b9..7893ba56 100644 --- a/mingw-w64-headers/include/uianimation.h +++ b/mingw-w64-headers/include/uianimation.h Please fix the IDL

Re: [Mingw-w64-public] [PATCH] uianimation.h: Add missed defines

. "result file" of the 'widl'). Can you help me with that? On February 19, 2018 2:07:03 AM Jacek Caban <ja...@codeweavers.com> wrote: Hi Ruslan, On 2/17/18 5:45 PM, Ruslan Garipov wrote: diff --git a/mingw-w64-headers/include/uianimation.h b/mingw-w64-headers/include/uian

[Mingw-w64-public] [PATCH] uianimation.idl: Added missing constants.

Based on patch by Ruslan Garipov. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/uianimation.idl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mingw-w64-headers/include/uianimation.idl b/mingw-w64-headers/include/uianimation.idl index e0

Re: [Mingw-w64-public] Patch: work around stdcall function returning an aggregate is incompatible with MS ABI issue

Hi Tom, On 2/27/18 6:04 AM, Tom Ritter wrote: This patch adds wrapper functions around methods that are affected by the stdcall function returning an aggregate is incompatible with MS ABI gcc bug Background https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64384

[Mingw-w64-public] [PATCH] Make _execute_onexit_table thread safe.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/misc/onexit_table.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/misc/onexit_table.c b/mingw-w64-crt/misc/onexit_table.c index 50d9f3d0..69f2ea71 100644 --- a/mingw-w64-cr

[Mingw-w64-public] [PATCH] wine-import.sh: Run autoconf after updating widl version.

This reverts 9b27e7e9ce13d05de3527878031e47cfe6eca06b. We update VERSION file to Wine version, which is imported into configure script. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-tools/widl/wine-import.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/min

Re: [Mingw-w64-public] [PATCH] intrin-impl.h: do not define _xgetbv for GCC 8

Hi Mateusz, On 1/22/18 9:18 PM, Mateusz wrote: GCC 8 from r248028 has defined function _xgetbv and we should avoid double definition of this function. Please review. The patch looks good to me. Thanks, Jacek --

Re: [Mingw-w64-public] [PATCH 3/4] dwrite1_1.h: Added DWRITE_PANOSE declaration.

On 01/22/2018 09:30 PM, Kai Tietz via Mingw-w64-public wrote: > Hmm, ok. Shouldn't we special case unnamed union/struct? Unless I'm missing something, all structs are named in this patch. Thanks for reviews, Jacek

Re: [Mingw-w64-public] Defining additional Constants

Hi Tom, On 01/22/2018 07:15 PM, Tom Ritter wrote: > mingw-w64-headers/include/error.h| 1 + > mingw-w64-headers/include/winerror.h | 1 + > mingw-w64-headers/include/winnt.h| 29 - > mingw-w64-tools/widl/include/winnt.h | 1 + The version in widl/

[Mingw-w64-public] [PATCH 4/4] dwrite_3.h: Added new header file.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/dwrite_3.h | 587 +++ 1 file changed, 587 insertions(+) create mode 100644 mingw-w64-headers/include/dwrite_3.h diff --git a/mingw-w64-headers/include/dwrite_3.h b/mingw-w64-h

[Mingw-w64-public] [PATCH 3/4] dwrite1_1.h: Added DWRITE_PANOSE declaration.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/dwrite_1.h | 53 1 file changed, 53 insertions(+) diff --git a/mingw-w64-headers/include/dwrite_1.h b/mingw-w64-headers/include/dwrite_1.h index c0d15acb..56728da1

[Mingw-w64-public] [PATCH 2/4] dcommon.h: Moved more declarations to dcommon.h.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/d2d1_1.h | 1 - mingw-w64-headers/include/d2dbasetypes.h | 9 - mingw-w64-headers/include/dcommon.h | 22 ++ 3 files changed, 22 insertions(+), 10 deletions(-) diff

[Mingw-w64-public] [PATCH 1/4] dwrite.h: Added DWRITE_DECLARE_INTERFACE define.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/dwrite.h | 4 1 file changed, 4 insertions(+) diff --git a/mingw-w64-headers/include/dwrite.h b/mingw-w64-headers/include/dwrite.h index 122d0bf6..7269dff5 100644 --- a/mingw-w64-headers/include/dwrite.h

Re: [Mingw-w64-public] [PATCH] stdio.h: Don't use ms_* and gnu_* format attributes on clang.

On 01/21/2018 05:26 PM, Kai Tietz via Mingw-w64-public wrote: > Patch is ok. But this is indeed problematic that clang doesn't support > different scanf/printf warning API. > For C99 printf/canf formatter diagnostic the produced warnings will be > wrong for this compiler. Yeah, I hope it will be

[Mingw-w64-public] [PATCH] stdio.h: Don't use ms_* and gnu_* format attributes on clang.

clang doesn't support it, so it emits tons of warnings. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/crt/stdio.h | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/mingw-w64-headers/crt/stdio.h b/mingw-w64-headers/crt/s

Re: [Mingw-w64-public] About [PATCH] intrin-impl.h: Use volatile argument for __buildbittesti-based functions.

Hi, On 1/20/18 8:54 PM, Mateusz wrote: Hello, The patch "intrin-impl.h: Use volatile argument for __buildbittesti-based functions." is not working well for me (I can't compile GCC with this patch). The problem is with one extra 'volatile': @@ -615,28 +614,28 @@ __buildstos(__stosq,

[Mingw-w64-public] [PATCH] intrin-impl.h: Use volatile argument for __buildbittesti-based functions.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/psdk_inc/intrin-impl.h | 83 1 file changed, 41 insertions(+), 42 deletions(-) diff --git a/mingw-w64-headers/include/psdk_inc/intrin-impl.h b/mingw-w64-headers/include/psdk_inc/

Re: [Mingw-w64-public] [PATCH] intrin-impl.h: Added missing volatile to _interlockedbittestandset and _interlockedbittestandset64 declarations.

On 01/12/2018 03:25 AM, Liu Hao wrote: > On 2018/1/12 4:28, Jacek Caban wrote: >> Fixes compilation with clang. >> >> Signed-off-by: Jacek Caban <ja...@codeweavers.com> >> --- >> mingw-w64-headers/include/psdk_inc/intrin-impl.h | 16

Re: [Mingw-w64-public] [PATCH 6/6] widl: Don't run autoconf as part of wine-import.sh

On 01/12/2018 09:14 AM, Martin Storsjö wrote: > None of the imported files actually are part of the autoconf/automake > source files, so no import currently would actually require > rerunning this. > > If the import script is adjusted to touch Makefile.am or configure.ac, > such a command probably

Re: [Mingw-w64-public] [PATCH 5/6] widl: Add a local patch for reapplying "widl: Relocate DEFAULT_INCLUDE_DIR" after imports

On 01/12/2018 09:14 AM, Martin Storsjö wrote: > This patch doesn't make much sense for use in wine and probably > can't be upstreamed as such. Well, I think that such feature could be accepted to Wine, but current code doesn't seem to be in a shape acceptable upstream. > This also reapplies the

Re: [Mingw-w64-public] [PATCH 4/6] widl: Allow importing wine sources from an out of tree wine build

On 01/12/2018 09:14 AM, Martin Storsjö wrote: > Some of the imported source files are autogenerated, and if wine > was built outside of the source tree, the caller of wine-import.sh > needs to provide paths to both trees. > > In such an import, the generated bison/flex files will have stray >

Re: [Mingw-w64-public] [PATCH 3/6] widl: Don't try to import libloaderapi.h

On 01/12/2018 09:14 AM, Martin Storsjö wrote: > There is no such file present in upstream wine, nor in the current > mingw-w64 tree either. > > Signed-off-by: Martin Storsjö > --- > mingw-w64-tools/widl/wine-import.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mingw-w64-public] [PATCH 1/6] widl: Readd CFLAGS for optimization

On 01/12/2018 09:14 AM, Martin Storsjö wrote: > These seem to have been removed by mistake as part of a change > touching the line above, in 4581de347f. > > Signed-off-by: Martin Storsjö > --- > mingw-w64-tools/widl/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mingw-w64-public] [PATCH 3/5] libmsvcr*.a: Added compatibility implementation of onexit table functions.

On 01/12/2018 03:36 AM, Liu Hao wrote: > On 2018/1/12 4:31, Jacek Caban wrote: >> Signed-off-by: Jacek Caban <ja...@codeweavers.com> >> --- >> mingw-w64-crt/Makefile.am | 1 + >> mingw-w64-crt/misc/onexit_table.c | 74 >>

Re: [Mingw-w64-public] [PATCH 5/5] ucrtbase_compat.c: Get rid of no longer needed _lock, _unlock and __dllonexit.

On 01/11/2018 10:00 PM, Martin Storsjö wrote: > On Thu, 11 Jan 2018, Jacek Caban wrote: > >> Signed-off-by: Jacek Caban <ja...@codeweavers.com> >> --- >> mingw-w64-crt/crt/ucrtbase_compat.c | 58 >> - >> 1 file changed,

[Mingw-w64-public] [PATCH 5/5] ucrtbase_compat.c: Get rid of no longer needed _lock, _unlock and __dllonexit.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/crt/ucrtbase_compat.c | 58 - 1 file changed, 58 deletions(-) diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c b/mingw-w64-crt/crt/ucrtbase_compat.c index 9b63565e..fcdc8cae

[Mingw-w64-public] [PATCH 4/5] crt: Use onexit table functions for atexit implementation.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/Makefile.am| 2 +- mingw-w64-crt/crt/atonexit.c | 60 mingw-w64-crt/crt/crtdll.c | 29 ++--- mingw-w64-crt/crt/crtexe.c | 9 --- 4 files chang

[Mingw-w64-public] [PATCH 3/5] libmsvcr*.a: Added compatibility implementation of onexit table functions.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/Makefile.am | 1 + mingw-w64-crt/misc/onexit_table.c | 74 +++ 2 files changed, 75 insertions(+) create mode 100644 mingw-w64-crt/misc/onexit_table.c diff --git a/mingw-w

[Mingw-w64-public] [PATCH 1/5] corecrt_startup.h: Moved _PVFV, _PIFV and _PVFI declarations to corecrt_startup.h.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/crt/atonexit.c| 1 + mingw-w64-crt/crt/charmax.c | 3 ++- mingw-w64-crt/crt/tlssup.c | 8 +--- mingw-w64-crt/crt/ucrtbase_compat.c | 1 + mingw-w64-crt/include/internal.h

[Mingw-w64-public] [PATCH 2/5] corecrt_startup.h: Added _onexit_table_t and related functions declarations.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/crt/corecrt_startup.h | 12 1 file changed, 12 insertions(+) diff --git a/mingw-w64-headers/crt/corecrt_startup.h b/mingw-w64-headers/crt/corecrt_startup.h index bd51b61b..2f47cb51 100644 --- a/min

[Mingw-w64-public] [PATCH] intrin-impl.h: Added missing volatile to _interlockedbittestandset and _interlockedbittestandset64 declarations.

Fixes compilation with clang. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/psdk_inc/intrin-impl.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mingw-w64-headers/include/psdk_inc/intrin-impl.h b/mingw-w64-h

Re: [Mingw-w64-public] [PATCH] intrin-impl.h: Added missing volatile to _interlockedbittestandset and _interlockedbittestandset64 declarations.

On 01/11/2018 04:45 AM, Liu Hao wrote: > On 2018/1/11 6:21, Jacek Caban wrote: >> Signed-off-by: Jacek Caban <ja...@codeweavers.com> >> --- >> mingw-w64-headers/include/psdk_inc/intrin-impl.h | 16 >> 1 file changed, 8 insertions(+), 8 deletions(

[Mingw-w64-public] [PATCH] intrin-impl.h: Added missing volatile to _interlockedbittestandset declaration.

Fixes compilation with clang. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/include/psdk_inc/intrin-impl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-headers/include/psdk_inc/intrin-impl.h b/mingw-w64-headers/include/psdk_inc/

Re: [Mingw-w64-public] [PATCH 2/2] wine-import.sh: Added Wine import script.

On 22.12.2017 16:48, shinchiro wrote: > Looking into the import script, dxva2api.idl doesn't exist there. Is > it possible to add that too since there some functions missing > compared to wine's version? Sure, we could do that. However, we need to make sure that Wine version is not missing

Re: [Mingw-w64-public] [PATCH] Updated widl to Wine 3.0-rc2 version.

On 18.12.2017 21:57, Martin Storsjö wrote: > On Mon, 18 Dec 2017, Jacek Caban wrote: > >> We were unable to do that for a long time, because of additional >> mingw-w64 patches that were committed on top of upstream version. Those >> patches started implementing winrt

Re: [Mingw-w64-public] [PATCH] Always use __p__fmode for _fmode.

On 18.12.2017 21:56, Martin Storsjö wrote: > On Mon, 18 Dec 2017, Jacek Caban wrote: > >> >> It requires adding compatibility code for x86_64 msvcrt version. I don't >> have arm setup to test, but I assume it's present there. > > Based on the msvcrt.dll from Win10

Re: [Mingw-w64-public] [PATCH 1/2] _mingw.h.in: Use __has_builtin in widl-friendly way.

On 18.12.2017 21:50, Martin Storsjö wrote: > On Mon, 18 Dec 2017, Jacek Caban wrote: > >> This is a workaround, widl can't handle parametrized macro as #if >> expression. Ideally, widl preprocessor should support this syntax. >> >> Signed-off-by: Jace

[Mingw-w64-public] [PATCH] Always use __p__fmode for _fmode.

It requires adding compatibility code for x86_64 msvcrt version. I don't have arm setup to test, but I assume it's present there. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/Makefile.am | 1 + mingw-w64-crt/crt/crtexe.c | 2 +- mingw-w64-c

[Mingw-w64-public] [PATCH] Updated widl to Wine 3.0-rc2 version.

. That said, I propose to use upstream Wine upstream version and resurrect import script in the tree. Dropped patches (needed for some winrt IDLs) are easy to get from Git (just use a commit prior to this one). We could even create a separated branch for that, if desired. Signed-off-by: Jacek Caban <

[Mingw-w64-public] [PATCH 2/2] wine-import.sh: Added Wine import script.

it again. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/wine-import.sh | 189 +++ 1 file changed, 189 insertions(+) create mode 100755 mingw-w64-headers/wine-import.sh diff --git a/mingw-w64-headers/wine-import.sh b/min

[Mingw-w64-public] [PATCH 1/2] _mingw.h.in: Use __has_builtin in widl-friendly way.

This is a workaround, widl can't handle parametrized macro as #if expression. Ideally, widl preprocessor should support this syntax. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/crt/_mingw.h.in | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [Mingw-w64-public] [PATCH] headers: Fix the definition of _sys_errlist for ucrtbase

Looks good as well. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com> -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/sl

Re: [Mingw-w64-public] [PATCH] headers: Hook up getc/putc_nolock for ucrtbase

Looks good to me. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com> -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/sl

Re: [Mingw-w64-public] [PATCH] crt: Provide fallback implementations of __p__acmdln/__p__wcmdln

On 11/28/17 10:30 AM, Kai Tietz via Mingw-w64-public wrote: Hello Martin, patch is ok. Please go ahead and commit, if Jacek has no objections. The patch looks good to me as well. Thanks a lot for taking care of that! Jacek

Re: [Mingw-w64-public] [PATCH 1/2] Remove vsnprintf forward from libmingwex.

On 24.11.2017 20:45, Martin Storsjö wrote: > On Fri, 24 Nov 2017, Jacek Caban wrote: > >> >> It's properly forwarded by crt import libs. >> >> Signed-off-by: Jacek Caban <ja...@codeweavers.com> >> --- >> mingw-w64-crt/Makefile.am  

[Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/crt/ucrtbase_compat.c | 8 mingw-w64-crt/include/internal.h| 12 2 files changed, 20 deletions(-) diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c b/mingw-w64-crt/crt/ucrtbase_compat.c index cb

[Mingw-w64-public] [PATCH 1/2] corecrt_startup.h: Added a new file with _acmdln and _wcmdln declarations.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/crt/corecrt_startup.h | 23 +++ mingw-w64-headers/crt/process.h | 1 + 2 files changed, 24 insertions(+) create mode 100644 mingw-w64-headers/crt/corecrt_startup.h diff --git a/min

[Mingw-w64-public] [PATCH 2/2] Use .def files to forward vsnprintf_s to _vsnprintf_s.

Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/def-include/msvcrt-common.def.in | 2 ++ mingw-w64-crt/stdio/vsnprintf_s.c | 16 3 files changed, 3 insertions(+), 17 deletions(-)

[Mingw-w64-public] [PATCH 1/2] Remove vsnprintf forward from libmingwex.

It's properly forwarded by crt import libs. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/stdio/vsnprintf.c | 13 - 2 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 mingw-w64-crt/stdio/vsnpr

Re: [Mingw-w64-public] [PATCH] headers: Implement the conio.h printf/scanf functions for ucrtbase

On 24.11.2017 11:37, Martin Storsjö wrote: > MSVC doesn't provide these functions as global symbols at the linker > level, but there you must include a header to make them work. > > Additionally, for the wchar versions, you can currently override the > behaviour by setting

Re: [Mingw-w64-public] [PATCH] headers: Implement the conio.h printf/scanf functions for ucrtbase

Hi Martin, On 11/24/17 11:03 AM, Martin Storsjö wrote: --- mingw-w64-headers/crt/conio.h | 214 +- 1 file changed, 209 insertions(+), 5 deletions(-) Since we already know that we often need such functions in libucrtbase.a, wouldn't it make more

Re: [Mingw-w64-public] Importing other IDLs from wine

Hi Shinchiro, On 20.11.2017 10:46, Shinchiro Shinchiro wrote: > Actually, I tried to create diff between wine's widl and mingw-w64's > widl before but maybe it's difficult to cherry-pick changes that never > got upstreamed I can see that your patches remove changes from mingw-w64 branch. If

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

Hi Martin, On 11/17/17 9:20 PM, Martin Storsjö wrote: We can't redirect these to the function calls via defines, since "#define timezone _timezone" will break any code that uses e.g. "struct timezone", since "_timezone" is a define that expands into "(* __timezone())". We can provide compat

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

On 17.11.2017 18:45, Martin Storsjö wrote: > On Fri, 17 Nov 2017, Jacek Caban wrote: > >> On 17.11.2017 10:12, Martin Storsjö wrote: >>> +  HANDLE ucrt; >>> + >>> +  ucrt = GetModuleHandle("ucrtbase.dll"); >>> +  real__tzset =

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

On 17.11.2017 10:12, Martin Storsjö wrote: > + HANDLE ucrt; > + > + ucrt = GetModuleHandle("ucrtbase.dll"); > + real__tzset = (void __cdecl (*)(void)) GetProcAddress(ucrt, "_tzset"); Can we get away without GetModuleHandle()/GetProcAddress()? For example: keep _tzset in .def file and call it

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

On 16.11.2017 20:46, Martin Storsjö wrote: > So even with the latest MSVC, _snprintf retains the legacy behaviour, > and the same goes for vsnprintf vs _vsnprintf. That good to know. Thanks for testing. Jacek --

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

On 16.11.2017 14:59, Martin Storsjö wrote: > On Thu, 16 Nov 2017, Jacek Caban wrote: > >> Hi Martin, >> >> The patch looks generally good to me. I'm fine with committing it. >> >> As a side note, I expect this patch to also fix winpthread (built with >&g

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

On 16.11.2017 14:40, Martin Storsjö wrote: > On Thu, 16 Nov 2017, Jacek Caban wrote: > >> Hi Martin, >> >> On 15.11.2017 21:06, Martin Storsjö wrote: >>> diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c >>> b/mingw-w64-crt/crt/ucrtbase_compat.c >>>

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

Hi Martin, The patch looks generally good to me. I'm fine with committing it. As a side note, I expect this patch to also fix winpthread (built with toolchain defaulting default msvcrt.dll) linking problems that I saw when tried your patches. On 15.11.2017 23:11, Martin Storsjö wrote: > This

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

Hi Martin, On 15.11.2017 21:06, Martin Storsjö wrote: > diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c > b/mingw-w64-crt/crt/ucrtbase_compat.c > index c02c476..4f840ea 100644 > --- a/mingw-w64-crt/crt/ucrtbase_compat.c > +++ b/mingw-w64-crt/crt/ucrtbase_compat.c > @@ -24,6 +24,7 @@ > #include

Re: [Mingw-w64-public] Importing other IDLs from wine

On 14.11.2017 11:29, Shinchiro Shinchiro wrote: > So how about the status of this issue? It still needs debugging, AFAIK. Cheers, Jacek -- Check out the vibrant tech community on one of the world's most engaging tech

Re: [Mingw-w64-public] [PATCH 1/2] headers: Allow setting the default __MSVCRT_VERSION__

I would prefer to have the same names for headers and crt configure arguments. Other than that, it looks good to me. Thanks, Jacek On 11/10/17 10:07 PM, Kai Tietz via Mingw-w64-public wrote: Patch looks ok to me. Jacek any comments? Thanks Kai Am 10.11.2017 21:50 schrieb "Martin Storsjö"

Re: [Mingw-w64-public] [PATCHv3 1/2] crt: Use __acrt_iob_func for accessing __iob in all msvcrt versions

| 8 +-- > mingw-w64-headers/crt/stdio.h | 9 --- > mingw-w64-headers/crt/wchar.h | 9 --- > 6 files changed, 135 insertions(+), 56 deletions(-) > create mode 100644 mingw-w64-crt/stdio/acrt_iob_func.c Looks good now. Thanks,

Re: [Mingw-w64-public] [PATCHv2 1/2] crt: Use __acrt_iob_func for accessing __iob in all msvcrt versions

Hi Martin, On 09.11.2017 20:33, Martin Storsjö wrote: > if !W32API > -lib32_DATA += lib32/libglut.a lib32/libmsvcp60.a lib32/libmsvcr80.a > lib32/libmsvcr90.a lib32/libmsvcr90d.a lib32/libmsvcr100.a \ > - lib32/libmsvcr110.a lib32/libmsvcr120.a > lib32/libmsvcr120d.a

Re: [Mingw-w64-public] [PATCH 2/2] headers: Always map e.g. time to _time32 or _time64 for ucrtbase

TIME_INLINE __CRT_INLINE > +#endif As an unrelated side note, I'd be tempted to say that it would be a nice thing to do for other versions as well. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com>

Re: [Mingw-w64-public] [PATCH 1/2] crt: Don't add extra timezone related exports to ucrtbase.def

-) Looks good to me. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com> -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___

Re: [Mingw-w64-public] [PATCH 1/2] headers: Allow setting the default __MSVCRT_VERSION__

Hi Martin, On 09.11.2017 15:59, Martin Storsjö wrote: > +AC_MSG_CHECKING([default __MSVCRT_VERSION__]) > +AC_ARG_WITH([default-msvcrt-version], > + [AS_HELP_STRING([--with-default-msvcrt-version=VER], > +[Default value of __MSVCRT_VERSION__ (default: 0x700)])], > + [], > +

Re: [Mingw-w64-public] [PATCH 2/2] crt: Stop building with -fno-builtin-fprintf

sjö <mar...@martin.st> > --- > mingw-w64-crt/Makefile.am | 4 > 1 file changed, 4 deletions(-) As soon as patch 1/2 is committed, this looks good. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com> --

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use __acrt_iob_func for accessing __iob in all msvcrt versions

Hi Martin, On 09.11.2017 16:00, Martin Storsjö wrote: > This makes sure that all code in libmingwex that refers to stderr > etc will work correctly even if linked to ucrtbase. > > Signed-off-by: Martin Storsjö > --- > mingw-w64-crt/Makefile.am | 121 >

Re: [Mingw-w64-public] [PATCH] headers: Default to the legacy wide string mode for ucrtbase, unless __USE_MINGW_ANSI_STDIO is defined

On 11/9/17 1:08 PM, Martin Storsjö wrote: Just one detail: Note that supporting legacy behavior in this care is easy. One can achieve that with -D__USE_MINGW_ANSI_STDIO=0. Not quite - if you're in an environment that defaults to ucrtbase, you need to set

Re: [Mingw-w64-public] [PATCH] headers: Default to the legacy wide string mode for ucrtbase, unless __USE_MINGW_ANSI_STDIO is defined

Hello, On 11/9/17 11:10 AM, Martin Storsjö wrote: On Thu, 9 Nov 2017, Kai Tietz via Mingw-w64-public wrote: Hmm, C99 support is pretty important for the gnu world.  Nevertheless patch ok. Please go ahead. Yup, I know. However, right now if you build with msvcrt.dll and use e.g. wprintf(),

Re: [Mingw-w64-public] [PATCH 0/7] Ucrtbase/__argv/__p___* functions

On 08.11.2017 23:19, Martin Storsjö wrote: > - Fix getopt by using __p___argv there instead of __argv, as Jacek > suggested. In order to do this, I ended up cleaning up a few other > inconsistencies surrounding the build of msvcr* dlls/defs while > I was touching that area, cleanly separated

Re: [Mingw-w64-public] [PATCH 7/7] crt: Use __p___argv instead of __argv in getopt

On 08.11.2017 23:19, Martin Storsjö wrote: > We provide a version of __p___argv in all msvcrt versions now. This > allows linking getopt from libmingwex against ucrtbase. > > Signed-off-by: Martin Storsjö > --- > mingw-w64-crt/misc/getopt.c | 2 +- > 1 file changed, 1

Re: [Mingw-w64-public] [PATCH 3/7] crt: Only expose the __p___* functions in msvcrt.def on i386

..@martin.st> > --- > mingw-w64-crt/lib-common/msvcrt.def.in | 2 ++ > 1 file changed, 2 insertions(+) Looks good to me. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com> -- Check out

Re: [Mingw-w64-public] [PATCH 2/7] crt: Skip an i386 specific wrapper function for arm/arm64 msvcrt

changed, 2 insertions(+), 2 deletions(-) Looks good to me. Thanks, Jacek Signed-off-by: Jacek Caban <ja...@codeweavers.com> -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slash

Re: [Mingw-w64-public] [PATCH 6/7] crt: Provide __p___argv in all msvcrt versions

On 08.11.2017 23:19, Martin Storsjö wrote: > + // We have a fallback definition of __p___argv for msvcrt versions that > + // lack it, so always declare it as available, but without _CRTIMP. > + char ***__cdecl __p___argv(void); How about using __MINGW_IMP_SYMBOL in compat implementation so

Re: [Mingw-w64-public] [PATCH 1/7] crt: Include LIBRARY in the def files for crtdll and msvcr80

t/lib32/crtdll.def | 1 + > mingw-w64-crt/lib32/msvcr80.def.in | 1 + > mingw-w64-crt/lib64/crtdll.def | 1 + > mingw-w64-crt/lib64/msvcr80.def.in | 1 + > 5 files changed, 4 insertions(+), 16 deletions(-) Looks good to me. Thanks, Jacek Signed-off

Re: [Mingw-w64-public] [PATCH 00/11] More fixes for ucrtbase

On 08.11.2017 14:30, Martin Storsjö wrote: > On Wed, 8 Nov 2017, Jacek Caban wrote: > >> Hi Martin, >> >> >> On 11/7/17 10:29 PM, Martin Storsjö wrote: >>> I've tested our support for ucrtbase.dll a bit further by trying >>> building >>> a

Re: [Mingw-w64-public] [PATCH 11/11] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

Hi Martin, On 07.11.2017 22:29, Martin Storsjö wrote: > Alternatively, we could just skip providing these when building with > ucrtbase, but that would require updating any calling code. That's a tempting solution. It seems to be deprecated for years now. Do you know a real code that needs it?

Re: [Mingw-w64-public] [PATCH 09/11] crt: Add compatibility for __imp___argv for ucrtbase

Hi Martin, On 11/7/17 10:29 PM, Martin Storsjö wrote: Normally calling code should use the right version of headers, but the getopt implementation in libmingwex will have a hardcoded reference to __imp___argv. I think it would be better to add __p___argv (a trivial wrapper around __argv) to

Re: [Mingw-w64-public] [PATCH 00/11] More fixes for ucrtbase

Hi Martin, On 11/7/17 10:29 PM, Martin Storsjö wrote: I've tested our support for ucrtbase.dll a bit further by trying building a handful of libraries with it, and fixing the issues I run into. With these patches, I'm able to build among others Qt (tested with 5.7.1). That's good to hear.

Re: [Mingw-w64-public] Importing other IDLs from wine

On 07.11.2017 17:03, Shinchiro Shinchiro wrote: > Forgot to mention the compiler, widl actually is working fine. The > culprit is in some idl files which might be outdated which produce > segfault (in dxgi1_6.idl case) That's interesting. Do you know which ones? BTW, widl crash is a bug in widl

Re: [Mingw-w64-public] Importing other IDLs from wine

On 07.11.2017 15:42, Liu Hao wrote: > On 2017/11/7 21:55, Jacek Caban wrote: >> On 07.11.2017 14:42, Shinchiro Shinchiro wrote: >> >>> There's bug in some mingw-w64's idls which give segfault with >>> widl which of course fixed in wine >> >> Yeah, imp

Re: [Mingw-w64-public] Importing other IDLs from wine

On 07.11.2017 14:42, Shinchiro Shinchiro wrote: > At the moment, only directx idl is imported from wine. I want to suggest > you to import other IDLs from wine/include too if it doesn't break > anything. That's not really true, there are some other IDLs. I occasionally import some more. If you

Re: [Mingw-w64-public] [PATCHv2 2/2] crt: Remove ucrtbase_compat workarounds for __mb_cur_max

On 07.11.2017 13:48, Martin Storsjö wrote: > This simplifies the compat wrapper quite significantly, and the > workarounds weren't sufficient in any case (the local __mb_cur_max > value only was updated if the current module set the locale). > > Signed-off-by: Martin Storsjö >

Re: [Mingw-w64-public] [PATCHv2 1/2] headers: Use ___mb_cur_max_func instead of __mb_cur_max

On 07.11.2017 13:48, Martin Storsjö wrote: > This avoids having libmingwex refer to the dllimported data symbol > from msvcrt.dll, easing linking to ucrtbase.dll which doesn't have > it exported as a data symbol. > > ___mb_cur_max_func didn't exist in msvcrt.dll until Windows XP, > while

Re: [Mingw-w64-public] [PATCH] Provide __debugbreak on clang >= 3.4 as well

Hi Martin, On 11/5/17 12:25 PM, Martin Storsjö wrote: #ifdef __MINGW_INTRIN_INLINE -#if !defined (__clang__) +#if !defined (__clang__) || (__clang_major__ > 3 || __clang_major__ == 3 && __clang_minor__ >= 4) Could __has_builtin be used instead? Thanks, Jacek

Re: [Mingw-w64-public] IDWriteFontFace1 Fix

On 26.10.2017 20:13, Tom Ritter wrote: > We missed one, here is the additional patch. Looks good, I pushed it to the repo. Thanks, Jacek -- Check out the vibrant tech community on one of the world's most engaging tech

Re: [Mingw-w64-public] IDWriteFontFace1 Fix

Hi Tom, On 10/17/17 7:16 AM, Tom Ritter wrote: Attached is a patch that I think, maybe, resolves the issue in https://bugzilla.mozilla.org/show_bug.cgi?id=1372958#c10 The attachment didn't make it to the mailing list. Thanks, Jacek

Re: [Mingw-w64-public] New directx header from wine?

On 11.10.2017 14:18, Shinchiro Shinchiro wrote: > On Wed, Oct 11, 2017 at 6:38 PM, Jacek Caban  wrote: > > Oh, right, I didn't mean to commit that at all. The problem is > that mingw-w64 version of widl crashes on that IDL. It needs an > investigation (and proba

Re: [Mingw-w64-public] Getting started and widl problems

On 11.10.2017 12:47, Leif AMO wrote: > On 2017-10-10 17:13, Jacek Caban wrote: >> Importing from Wine is scripted, but the script for that is not >> public for quite a while. We used to have it in experimental branch >> of SVN, but it didn't survive move to Git. I

Re: [Mingw-w64-public] New directx header from wine?

On 11.10.2017 12:25, Shinchiro Shinchiro wrote: > On Wed, Oct 11, 2017 at 5:23 PM, Jacek Caban wrote: > > They were not really excluded, but simply not added. The update > was huge already, I wanted to do that separately. I committed it > now, please give it a try. &g

Re: [Mingw-w64-public] New directx header from wine?

On 10/11/17 5:15 AM, Shinchiro Shinchiro wrote: Is there a reason why latest pull from wine doesn't include new directx file like d3d11_3 and such? They were not really excluded, but simply not added. The update was huge already, I wanted to do that separately. I committed it now, please

[Mingw-w64-public] [PATCH] stdio.h: Fixed misplaced #endif.

Please review. Signed-off-by: Jacek Caban <ja...@codeweavers.com> --- mingw-w64-headers/crt/stdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-w64-headers/crt/stdio.h b/mingw-w64-headers/crt/stdio.h index 34aae9ad..0d9cf1c7 100644 --- a/mingw-w64-heade

Re: [Mingw-w64-public] [PATCH 2/2] crt: Avoid optimizing fprintf calls into fwrite in crt startup code

Hi Martin, On 9/23/17 4:50 PM, Martin Storsjö wrote: --- a/mingw-w64-crt/crt/pseudo-reloc.c +++ b/mingw-w64-crt/crt/pseudo-reloc.c @@ -145,11 +145,13 @@ __report_error (const char *msg, ...) #else va_list argp; va_start (argp, msg); + /* Intentionally avoid optimizing fprintf with a

<    1   2   3   4   5   6   7   8   9   >