Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/crt/eh.h | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
Thanks for the patch. Looks good to me. Pushed.
The Microsoft header doesn't contain , but it is required by the C++
standard anyway.
--
Best regards,
LI
-crt/lib64/moldname-msvcrt.def
diff --git a/mingw-w64-crt/lib64/moldname-msvcrt.def
b/mingw-w64-crt/lib64/moldname-msvcrt.def
deleted file mode 100644
index 6f31518d5c82..
Thanks for the patch. Pushed.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital
ctions are always `DECLSPEC_IMPORT`. So,
when is `WINUSERAPI` defined empty? I suspect it's only effective when building USER32.DLL itself by
Microsoft.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64
/msvcrt-common.def.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Thanks for catching this. This patch looks good to me. Pushed.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64
which I think should be
avoided?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
/sample/ms.def
deleted file mode 100644
index 1cb08ef3e04d..
Hmm what does 'genstubdll' do? Looks like neither MSYS2 nor Debian builds it; maybe it can be
removed completely?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital
these patches (except the one for removal of 'ms.def'). Pushed to
master now.
I am a bit unsure about 'ms.def': If genstubdll is no longer useful nowadays, I think it had better
be removed.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenP
/include/systemmediatransportcontrolsinterop.idl
Thanks for the patch. Looks good to me. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
you to acknowledge the status of this
patch - see https://sourceforge.net/p/mingw-w64/mailman/message/37748083/.
I can apply it when I get a chance - I'm quite swamped at the moment but trying to catch up - or
then maybe someone else can push it.
Okay, pushed now.
--
Best regards,
LI
variable declared before '='
```
If you define `WIN32_LEAN_AND_MEAN` (either `#define` it or pass `-DWIN32_LEAN_AND_MEAN` to GCC)
before inclusion of , then the error will go away. This seems to be yet another reason
why `WIN32_LEAN_AND_MEAN` should be preferred.
-
在 2022/12/21 17:06, Alvin Wong via Mingw-w64-public 写道:
On 21/12/2022 16:45, LIU Hao wrote:
If you define `WIN32_LEAN_AND_MEAN` (either `#define` it or pass `-DWIN32_LEAN_AND_MEAN` to GCC)
before inclusion of , then the error will go away. This seems to be yet another reason
why
does not use COM will not get that unwanted macro; and when COM stuff is
needed, COM headers can be included explicitly after .
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw
在 2022-12-20 02:49, Pali Rohár 写道:
And I think that this decision is independent of tool itself if should
be removed too or not.
My point is that if this should be removed then we shouldn't behave as if it was being actively
maintained.
Patch attached. Thoughts?
--
Best regards,
LI
在 2022-12-22 02:04, Jacek Caban 写道:
Removal seems good to me.
Thanks. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
ossible to provide unified non-inline *printf
functions.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/list
dn't be built with `-flto`...
This patch shouldn't affect non-LTO builds, so pushed for now. If there are any issues, please let
me know.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-p
tested carefully.
At the moment, these are `__xl_b`, `__xl_c` and `_tls_used`, but there might be more.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
output.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
et when compiling Windows code.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
}
```
And with LTO it prints nothing. When I added __attribute__((used)) for
those 3 symbols then it started printing "ő<".
So the attribute seems necessary. Patches are welcome.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
在 2022-12-25 02:19, Pali Rohár 写道:
This patch fixes it! And also in LTO mode it prints "test thread atexit".
Mostly good. Should `__xl_d` be given an attribute as well?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital
there.
The only issue I see in this patch is that there is a trailing comma on the line
`BSOS_PREFERDESTINATIONSTREAM,` which we don't allow, so please remove that.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital sign
r.idl
This patch looks good to me. Pushed to master. Thanks.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/
--
Best regards,
LIU Hao
From 1288ab9f2a965bcca5513b36bd29e906c4b7ee2f Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Tue, 27 Dec 2022 14:32:37 +0800
Subject: [PATCH] crt: Preserve special variables when LTO is in effect
Variables that are required to be placed in explicit sections probably
have
ailed assert in LLVM's LTO, but this assert isn't enabled
in release builds of LLBM.)
So this patch is ok, and for LLVM LTO of the crt startup files, more work is
needed.
Thanks. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP di
Thanks for the update. Looks good to me now. Pushed.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists
在 2022-12-28 21:16, Biswapriyo Nath 写道:
xmldom and and xmldso do not have their corresponding headers. So,
those are not added in Makefile.am. Also make sure to match widl
version.
Thanks for the patch. Pushed.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital
eeded.
Alternatively, we should always use `__MINGW_LSYMBOL(_image_base__)` and get rid of that
`__ImageBase` thing.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Ming
在 2022-12-28 21:38, Pali Rohár 写道:
Hello! I'm really really sorry :-( but I totally messed up my devel env
during testing this change and this change in v2 does not work :-(
OK I reverted these patches on master. New ideas will always be welcome.
--
Best regards,
LI
,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
they work.
Looks like the patch didn't arrive. Please send it as a TXT file instead.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
);
These should be `WINBOOL` instead of `BOOL`, as the latter denotes something
different in Objective-C.
Other parts look good to me. Amended and pushed. Thanks for the work.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
/crt/excpt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for the patch. Looks good to me. pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/include/rpcdce.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for the patch. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
在 2023-01-15 13:23, Li Carter 写道:
I’m sorry, but I missed `WINAPI` specifier for WTSFreeMemoryEx*, which breaks
x86 build
Ah, yes. I was distracted by the `BOOL` thing. Fixed in
a57cacad31f5766d45959b6c0f9b122918d545fa.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP
e of these functions?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
-w64-headers/crt/sec_api/string_s.h | 4 ++--
mingw-w64-headers/crt/sec_api/wchar_s.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
These patches look good to me. Pushed now. Thanks for the work.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
t/ssp/mempcpy_chk.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
Thanks for catching this. Pushed now, too.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-publ
在 2023-01-23 22:19, Luca Bacci 写道:
Awesome! Thank you very much, LIU Hao and Martin Storsjö!
Yes, making both _set_controlfp, _set_doserrno available in MSVCRT
toolchains would be great! Should I prepare a patch?
Yes if you can, and we'll be happy to check it in.
--
Best regards
在 2023-01-24 00:07, Luca Bacci 写道:
Ok, first tentative here. Let me know if anything needs to be changed!
This patch looks good to me, but would you like to sign off your commit? You can do this with `git
commit -s`.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP
in dbgeng.h
Required for JDK
Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/include/dbgeng.h | 66 ++
1 file changed, 66 insertions(+)
Thanks. This patch looks good to me. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description
在 2023/1/24 00:07, Luca Bacci 写道:
Ok, first tentative here. Let me know if anything needs to be changed!
Thank you,
Luca
Hi Luca. If you are not willing to sign off this patch I will check it in without the
'Signed-off-by:' line.
--
Best regards,
LIU Hao
OpenPGP_signature
D
在 2023-01-31 22:05, Luca Bacci 写道:
Hi LIU, very sorry for the delay!
I have now attached a patch with a proper sign-off
Thanks for the patch. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
在 2023/2/2 06:41, Christian Franke 写道:
This patch allows to use _FORTIFY_SOURCE=3 which is also supported by GLIBC
headers.
Thanks. This patch looks good to me. Pushed now.
BTW does clang support this as well? I suspect we should add a check for clang
too.
--
Best regards,
LIU Hao
?
Done now. Thanks.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
windows.foundation.collections.h.
Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/Makefile.am | 1 +
1 file changed, 1 insertion(+)
Thanks for the patch. Pushed now.
Really, I thought I must have missed something...
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
在 2023-02-04 20:51, Théo Cavignac 写道:
Sorry, I misclicked and sent an half written mail.
So as I tried to expose, I am using MinGW with following configuration:
This looks like a GCC issue. Reported here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108673
--
Best regards,
LIU Hao
atch looks good to me. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
: warning: this 'if' clause does not guard...
[-Wmisleading-indentation]
Signed-off-by: Biswapriyo Nath
---
mingw-w64-crt/secapi/strerror_s.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Thanks for the patch. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
D
n the indention before `#define`? Pre-processor directives should not
be indented. I have heard that some ancient compilers did not accept such indention, although all
modern compilers seem fine about it.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital sign
/string_s.h | 1 +
1 file changed, 1 insertion(+)
Thanks. This patch looks good to me. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
---
mingw-w64-headers/include/winioctl.h | 161 ++-
1 file changed, 157 insertions(+), 4 deletions(-)
Thanks. This patch looks good to me. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
much sense. Thanks for the patch. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo
insertions(+), 1 deletion(-)
create mode 100644 mingw-w64-crt/ssp/gets_chk.c
LGTM. Thanks.
Side note: I am a bit curious how this function is supposed to be useful. Generally speaking `get()`
should never be used.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital
me. Pushed now. Thanks.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
was checked like `(defined(__USE_MINGW_ANSI_STDIO) &&
((__USE_MINGW_ANSI_STDIO + 0) != 0))` but that was changed in
a84fc015351e664519359214cbb08d6e21f42814 (which also contained a hunk against 'inttypes.h').
--
Best regards,
LIU Hao
OpenPGP_signature
Desc
/include/winbase.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the patch. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
: Martin Storsjö
---
mingw-w64-headers/crt/string.h | 4
1 file changed, 4 insertions(+)
LGTM. Thanks.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
//gcc.godbolt.org/z/6z11qTYa7
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
--
Best regards,
LIU Hao
From 00e46892b8e2407aa6ec47af4b5a793a170d5019 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Fri, 24 Feb 2023 23:38:52 +0800
Subject: [PATCH] headers/intrin-impl: Expand `__movsd` to `movsl` in default
AT&T syntax
This was originally reported on mailing lis
在 2023/2/24 23:45, LIU Hao 写道:
From 00e46892b8e2407aa6ec47af4b5a793a170d5019 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Fri, 24 Feb 2023 23:38:52 +0800
Subject: [PATCH] headers/intrin-impl: Expand `__movsd` to `movsl` in default
AT&T syntax
This was originally reported on mailing lis
在 2023/2/27 18:30, JonY via Mingw-w64-public 写道:
Makes sense to me, OK to commit.
Thanks.
Thanks for the review. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
}
```
should set `errno` if `x` is negative or is a NaN. If `-fno-math-errno` is set, GCC doesn't check
for NaN inputs and let the hardware propagate them.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
_
--
Best regards,
LIU Hao
From a3cda37eed7ded9650e96bf246e611c13ce0d7f7 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Thu, 2 Mar 2023 14:51:07 +0800
Subject: [PATCH] inttypes: Fix check for `__USE_MINGW_ANSI_STDIO`
Since a84fc015351e664519359214cbb08d6e21f42814 it's always defined,
as 0
在 2023/2/21 07:06, Ansel Sermersheim 写道:
I’m trying to cross compile MinGW and GCC from a Debian system for use on Windows, and I’m running
into trouble linking libgcc_s:
Would you please try removing `--enable-lto`?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital
在 2023/3/2 16:39, Martin Storsjö 写道:
On Thu, 2 Mar 2023, LIU Hao wrote:
--
LGTM, thank you!
Thanks. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64
bootstrapped GCC 12 and there are no such symbols. Did you enable half-precision somehow?
I am not familiar with half-precision floating point support; just guessing. Maybe you can get more
helpful replies on gcc-h...@gcc.gnu.org.
--
Best regards,
LIU Hao
OpenPGP_signature
Descrip
ooks like it was designed mainly for x86_64, in
5b99e86d446ae5971be734c1fa76a21c3adb7148?
It was introduced one day earlier in 6ef8b92929cc918dc50fb6802839be61c0cfab7c, but without wording a
purpose.
--
Best regards,
LIU Hao
OpenPGP_signature
Description:
that, there is really only function to call, so how is the
one-argument `_setjmp()` supposed to be useful?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-p
t out?
AFAICT the i686 `_setjmp()` takes one argument and the x86_64 one takes two; not sure about ARM. My
opinion is that those #if conditions should check for the actual target macro, instead of
`USE_NO_MINGW_SETJMP_TWO_ARGS` which can be removed thereafter.
--
Best regards,
LIU Hao
OpenPGP_sign
-headers/include/ntsecpkg.h | 2 ++
1 file changed, 2 insertions(+)
Thanks for the patch. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public
在 2023/3/8 20:18, Martin Storsjö 写道:
...
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/setjmp.h | 72 +++---
1 file changed, 31 insertions(+), 41 deletions(-)
These patches look good to me. Thanks for the work.
--
Best regards,
LIU Hao
/ntsecpkg.h | 369 ++-
1 file changed, 361 insertions(+), 8 deletions(-)
Thanks. This patch looks good to me. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64
: Biswapriyo Nath
---
mingw-w64-headers/wine-import.sh | 1 +
1 file changed, 1 insertion(+)
Thanks for the patch. Pushed now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64
where necessary.
This patch looks good to me. Pushed to master now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
e
default.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
wrong value.
After correcting the bad array index the result is correct.
---
mingw-w64-crt/misc/uchar_mbrtoc32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for catching this. This patch looks correct to me. Pushed to master now.
--
Best regards,
LIU Hao
ale, without actually modifying it. In your patch you discard its result so it does nothing.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
64-mingw32-gcc; not sure
whether anything goes wrong. Martin, would you please include this patch in your nightly tests?
`-masm=intel` requires the latest Clang, though. Older versions do not accept Intel syntax in inline
assembly (but they do output Intel syntax).
--
Best regards,
LI
seemed to want Intel syntax, but in that case it should look for the second
alternative within { | }, not the other. Does GCC also give the same error?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
at's not my experience.
Oh yeah, indeed. Noted. I think I will have to move that thing into a .S file,
or introduce more magic..
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing l
ks about that [1]; I hope I would not have to repeat myself [2].
[1] https://outerproduct.net/2021-02-13_att-asm.html
[2] https://gcc.gnu.org/pipermail/gcc/2022-November/240103.html
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
_
ith `-masm=att` and `-masm=intel`. No errors have been observed.
The file '_scprintf.c' has been compiled with GCC, target i686-w64-mingw32 (it's i386-only and MSYS2
doesn't have an i386 clang environment), with `-masm=att` and `-masm=intel`. No errors have been
observed.
some well established evilness, the patch is not bad itself. You may commit
it as appropriate.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
er a path separator), and will not a mistake
non-leading byte as a path separator.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
needs no special treatment.
I think I can propose a reimplementation when I have time.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge
--
Best regards,
LIU Hao
From 544a196787132e0ceae01fe2f0f6c62e76da0e05 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Fri, 24 Mar 2023 16:38:51 +0800
Subject: [PATCH] crt: Remove conversion functions between UTF-{16,32}
characters from MSVCRT
Microsoft documentation says these functions operate
cales; those are not something we can handle, because we can't know the encoding of the argument
string.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-
now.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
erroneous results if the argument path was not in
the default ANSI code page. (I don't think this is a bug though, just
a design flaw.)
--
Best regards,
LIU Hao
From 5ef71a3214b71032b442575a761436fbb9327040 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Sat, 25 Mar 2023 18:35:15
This is an updated to the third patch.
The previous one missed a check for string terminators while looking for a UNC
host.
--
Best regards,
LIU Hao
From 7ef8e1f7d49167de3b5b900f98f31788da5c32f9 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Sun, 26 Mar 2023 02:02:52 +0800
Subject: [PATCH 3/3
://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-170
--
Best regards,
LIU Hao
From 5b176b5327e898949eed3b38bf3440815081f1f9 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Sun, 26 Mar 2023 02:02:52 +0800
Subject: [PATCH] crt: Reimplement `dirname()` and `basename()`
Signed-off
ves `\\hostname.`. Should this be
converted to `\\hostname\.`?
--
Best regards,
LIU Hao
From ac4a2fc5c6c4ae36621695a115bbe66204ce0d6e Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Sun, 26 Mar 2023 02:02:52 +0800
Subject: [PATCH] crt: Reimplement `dirname()` and `basename()`
Signed-off-by: LIU Hao
allowed in their
non-UNC
form. This means now `dirname("C:")` returns "C:", while `dirname("\\?\C:")`
returns "\\?\C:\".
[1]
https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats#identify-the-path
--
Best regards,
LIU Hao
From 6b20
alternative patch.
--
Best regards,
LIU Hao
From c4f11d50c9abef455ac4ef334d7fa89de929a316 Mon Sep 17 00:00:00 2001
From: LIU Hao
Date: Sun, 26 Mar 2023 02:02:52 +0800
Subject: [PATCH] crt: Reimplement `dirname()` and `basename()`
It is necessary to re-implement these two functions because
1. They
在 2023/3/28 10:49, LIU Hao 写道:
According to Microsoft documentation about paths, which I linked yesterday, the `\\host\share` part
is the name of a volume, so I think only the CMD behavior is right: `dirname()` should not remove
`..` which would move to a different volume. And here is the
cept about 'volume prefix'. This path is taking as a sole prefix and
an empty component, and is absolute. Hence, `dirname()` returns the prefix with a backslash appended
i.e. `\\host\`, and `basename()` returns `\`.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenP
ut from an invalid input (e.g. `\\host\share` from `\\host\\share`) or
an invalid output from a valid input (e.g. `\\host` from `\\host\share`) is not acceptable?
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
ore than two leading
slashes shall be treated as a single slash."
Well, Windows paths have different semantics from POSIX paths - for example the 'volume' thing does
not exist in POSIX. Thus, largely, UNC paths and paths with DOS drive letters can't follow POSIX
semantics,
301 - 400 of 1977 matches
Mail list logo
