Re: [Mingw-w64-public] [PATCH] Add interfaces frm evr header to libamstrmid
在 2018/8/25 16:36, Alexey Pavlov 写道: > > I have talk with Jacek on IRC. He tell me that this is necessary to provide > IIDs from updated evr header. It solve issue with building Qt5 with latest > mingw-w64 > Pushed to master now. -- Best regards, LH_Mouse -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add interfaces frm evr header to libamstrmid
I have talk with Jacek on IRC. He tell me that this is necessary to provide IIDs from updated evr header. It solve issue with building Qt5 with latest mingw-w64 > 25 авг. 2018 г., в 11:04, Liu Hao написал(а): > >> 在 2018/8/25 7:07, JonY via Mingw-w64-public 写道: >> Can you explain it in your commit message why this change was done? >> Thanks. >> > > I compiled 'amstrmid.c' using > ``` > gcc amstrmid.c -c -o old.o > ``` > , then dumped all symbols defined into a text file using > ``` > nm --defined-only old.o > old.txt > ``` > . I then applied the patch and created another list of symbols, > 'new.txt', in a similar way. > > Now I have two lists. Diff'ing them reveals a few hundreds of symbols: > ``` > E:\SourceForge\mingw-w64\mingw-w64-crt\libsrc>git diff --no-index -- > old.txt new.txt > diff --git a/old.txt b/new.txt > index cfab366d..8bf0ed29 100644 > --- a/old.txt > +++ b/new.txt > @@ -1,4 +1,565 @@ > b .bss > d .data > + i .drectve > + r .rdata$CLSID_DirectDraw > + r .rdata$CLSID_DirectDraw7 > + r .rdata$CLSID_DirectDrawClipper > + r .rdata$CLSID_InMemoryPropertyStore > + r .rdata$CLSID_MFByteStreamProxyClassFactory > + r .rdata$CLSID_PropertySystem > (... ...) > ``` > > These symbols are defined by the MS library, but not ours: > ``` > C:\Program Files (x86)\Windows Kits\10\Lib\10.0.17134.0\um\x86>nm > --defined-only amstrmid.lib | grep CLSID_DirectDrawClipper > R _CLSID_DirectDrawClipper > ``` > > So, the patch seems necessary to me. > > -- > Best regards, > LH_Mouse > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add interfaces frm evr header to libamstrmid
在 2018/8/25 7:07, JonY via Mingw-w64-public 写道: > Can you explain it in your commit message why this change was done? > Thanks. > I compiled 'amstrmid.c' using ``` gcc amstrmid.c -c -o old.o ``` , then dumped all symbols defined into a text file using ``` nm --defined-only old.o > old.txt ``` . I then applied the patch and created another list of symbols, 'new.txt', in a similar way. Now I have two lists. Diff'ing them reveals a few hundreds of symbols: ``` E:\SourceForge\mingw-w64\mingw-w64-crt\libsrc>git diff --no-index -- old.txt new.txt diff --git a/old.txt b/new.txt index cfab366d..8bf0ed29 100644 --- a/old.txt +++ b/new.txt @@ -1,4 +1,565 @@ b .bss d .data + i .drectve + r .rdata$CLSID_DirectDraw + r .rdata$CLSID_DirectDraw7 + r .rdata$CLSID_DirectDrawClipper + r .rdata$CLSID_InMemoryPropertyStore + r .rdata$CLSID_MFByteStreamProxyClassFactory + r .rdata$CLSID_PropertySystem (... ...) ``` These symbols are defined by the MS library, but not ours: ``` C:\Program Files (x86)\Windows Kits\10\Lib\10.0.17134.0\um\x86>nm --defined-only amstrmid.lib | grep CLSID_DirectDrawClipper R _CLSID_DirectDrawClipper ``` So, the patch seems necessary to me. -- Best regards, LH_Mouse -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] Add interfaces frm evr header to libamstrmid
On 08/24/2018 08:05 PM, Alexey Pavlov wrote: > Can you explain it in your commit message why this change was done? Thanks. signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
